]> jfr.im git - irc/rqf/shadowircd.git/commitdiff
Reject SCAN UMODES if invalid parameters are given.
authorJilles Tjoelker <redacted>
Fri, 16 Jan 2009 17:33:38 +0000 (18:33 +0100)
committerJilles Tjoelker <redacted>
Fri, 16 Jan 2009 17:33:38 +0000 (18:33 +0100)
modules/m_scan.c

index f0ce7d870543c7fdbbabd85ff0744c9a647a14b7..bb90d559d2d43e9be43765e7c67a0768cf52134a 100644 (file)
@@ -135,6 +135,12 @@ scan_umodes(struct Client *client_p, struct Client *source_p, int parc,
                return -1;
        }
 
+       if (parv[2][0] != '+' && parv[2][0] != '-')
+       {
+               sendto_one_notice(source_p, ":SCAN UMODES: umodes parameter must start with '+' or '-'");
+               return -1;
+       }
+
        for (c = parv[2]; *c; c++)
        {
                switch(*c)
@@ -170,6 +176,16 @@ scan_umodes(struct Client *client_p, struct Client *source_p, int parc,
                                list_max = atoi(parv[++i]);
                        else if (!irccmp(parv[i], "mask"))
                                mask = parv[++i];
+                       else
+                       {
+                               sendto_one_notice(source_p, ":SCAN UMODES: invalid parameters");
+                               return -1;
+                       }
+               }
+               else
+               {
+                       sendto_one_notice(source_p, ":SCAN UMODES: invalid parameters");
+                       return -1;
                }
        }
        if (target_list == &global_client_list && list_users)