From: Jilles Tjoelker <redacted>
Date: Fri, 16 Jan 2009 17:33:38 +0000 (+0100)
Subject: Reject SCAN UMODES if invalid parameters are given.
X-Git-Tag: charybdis-3.1.0~45
X-Git-Url: https://jfr.im/git/irc/rqf/shadowircd.git/commitdiff_plain/9f811fcefd7764ba42e91d9036f4b8cb5891dd66

Reject SCAN UMODES if invalid parameters are given.
---

diff --git a/modules/m_scan.c b/modules/m_scan.c
index f0ce7d8..bb90d55 100644
--- a/modules/m_scan.c
+++ b/modules/m_scan.c
@@ -135,6 +135,12 @@ scan_umodes(struct Client *client_p, struct Client *source_p, int parc,
 		return -1;
 	}
 
+	if (parv[2][0] != '+' && parv[2][0] != '-')
+	{
+		sendto_one_notice(source_p, ":SCAN UMODES: umodes parameter must start with '+' or '-'");
+		return -1;
+	}
+
 	for (c = parv[2]; *c; c++)
 	{
 		switch(*c)
@@ -170,6 +176,16 @@ scan_umodes(struct Client *client_p, struct Client *source_p, int parc,
 				list_max = atoi(parv[++i]);
 			else if (!irccmp(parv[i], "mask"))
 				mask = parv[++i];
+			else
+			{
+				sendto_one_notice(source_p, ":SCAN UMODES: invalid parameters");
+				return -1;
+			}
+		}
+		else
+		{
+			sendto_one_notice(source_p, ":SCAN UMODES: invalid parameters");
+			return -1;
 		}
 	}
 	if (target_list == &global_client_list && list_users)