]> jfr.im git - irc/charybdis-ircd/charybdis.git/commitdiff
extensions/extb_ssl.c: make certfp parameter case-insensitive origin/release/3.5
authorAaron Jones <redacted>
Tue, 28 Jan 2020 20:43:48 +0000 (20:43 +0000)
committerAaron Jones <redacted>
Tue, 28 Jan 2020 20:47:04 +0000 (20:47 +0000)
I had the idea that maybe these should be case-sensitive because some
encodings (like Base-64) are. But it turns out it's better to
prioritise not breaking existing configurations / channel mode lists,
and just revisit this in future maybe.

[ci skip]

extensions/extb_ssl.c

index 83ab56a311a97d07d6aae89a195c02fdea1c0140..e4078dde8a448b89ff70f9f45d71580c9f09d13e 100644 (file)
@@ -44,7 +44,7 @@ static int eb_ssl(const char *data, struct Client *client_p,
                if (EmptyString(client_p->certfp))
                        return EXTBAN_NOMATCH;
 
-               if (strcmp(data, client_p->certfp) != 0)
+               if (irccmp(data, client_p->certfp) != 0)
                        return EXTBAN_NOMATCH;
        }