extensions/extb_ssl.c: clean up this logic

This should also be using strcmp(3), not irccmp().
No practical consequence (yet), it just makes more sense.

diff --git a/extensions/extb_ssl.c b/extensions/extb_ssl.c
index fcc0ba22e1d0de568f4bd2f9dcee0da8df5e7273..83ab56a311a97d07d6aae89a195c02fdea1c0140 100644 (file)
--- a/extensions/extb_ssl.c
+++ b/extensions/extb_ssl.c
@@ -36,13 +36,17 @@ static int eb_ssl(const char *data, struct Client *client_p,
        (void)chptr;
        (void)mode_type;
 
+       if (! IsSSLClient(client_p))
+               return EXTBAN_NOMATCH;
+
        if (data != NULL)
        {
                if (EmptyString(client_p->certfp))
                        return EXTBAN_NOMATCH;
 
-               return !irccmp(data, client_p->certfp) ? EXTBAN_MATCH : EXTBAN_NOMATCH;
+               if (strcmp(data, client_p->certfp) != 0)
+                       return EXTBAN_NOMATCH;
        }
 
-       return IsSSLClient(client_p) ? EXTBAN_MATCH : EXTBAN_NOMATCH;
+       return EXTBAN_MATCH;
 }