]> jfr.im git - z_archive/twitter.git/commitdiff
Bugfix: queries with retry=True return None when rate-limited
authorbtidor <redacted>
Mon, 29 Dec 2014 05:50:14 +0000 (00:50 -0500)
committerbtidor <redacted>
Mon, 29 Dec 2014 05:50:14 +0000 (00:50 -0500)
Because bool is a subclass of int, isinstance(retry, int) returns True and the
decrement results in retry=0, terminating the while loop. Patches 73a242d.

twitter/api.py

index 3a2964185e0c14f0ef2a3ac3e1af1cac8196f482..25d55c6ffa156f5325fea1cbdf29c98e21ccbefe 100644 (file)
@@ -351,7 +351,7 @@ class TwitterCall(object):
                     print("Service unavailable; waiting for %ds..." % delay, file=sys.stderr)
                 else:
                     raise
-                if isinstance(retry, int):
+                if isinstance(retry, int) and not isinstance(retry, bool):
                     if retry <= 0:
                         raise
                     retry -= 1