]> jfr.im git - yt-dlp.git/commitdiff
Revert "[build] Build Windows x86 version with py3.8"
authorpukkandan <redacted>
Wed, 9 Jun 2021 10:05:17 +0000 (15:35 +0530)
committerpukkandan <redacted>
Wed, 9 Jun 2021 10:07:15 +0000 (15:37 +0530)
This reverts commit aa75e51f992c206b07ab4de592f11a871827bf4b.

See #390

This is being reverted instead of modified due to #388

.github/workflows/build.yml
.github/workflows/core.yml
.github/workflows/download.yml
yt_dlp/YoutubeDL.py
yt_dlp/update.py

index 6c9eed6f82ab4e73053593e261b241e468794086..d4321da0dc7f084efb00361e0f40a42aa6fab28d 100644 (file)
@@ -137,15 +137,15 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Python 32-Bit
+    - name: Set up Python 3.4.4 32-Bit
       uses: actions/setup-python@v2
       with:
-          python-version: '3.8'
+          python-version: '3.4.4'
           architecture: 'x86'
     - name: Upgrade pip and enable wheel support
-      run: python -m pip install --upgrade pip setuptools wheel
-    - name: Install Requirements
-      run: pip install pyinstaller mutagen pycryptodome
+      run: python -m pip install pip==19.1.1 setuptools==43.0.0 wheel==0.33.6
+    - name: Install Requirements for 32 Bit
+      run: pip install pyinstaller==3.5 mutagen==1.42.0 pycryptodome==3.9.4 pefile==2019.4.18
     - name: Bump version
       id: bump_version
       run: python devscripts/update-version.py
index be932275a2811b83a0bf052d538b95db746b57bc..abf7739ebd77f4d706d2148703683bebbce0d934 100644 (file)
@@ -9,13 +9,11 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-18.04]
-        # py3.9 is in quick-test
-        python-version: [3.7, 3.8, pypy-3.6, pypy-3.7]
+        python-version: [3.6, 3.7, 3.8, 3.9, pypy-3.6, pypy-3.7]
         run-tests-ext: [sh]
         include:
-        # atleast one of the tests must be in windows
         - os: windows-latest
-          python-version: 3.6
+          python-version: 3.4  # Windows x86 build is still in 3.4
           run-tests-ext: bat
     steps:
     - uses: actions/checkout@v2
index 9e650d2dc48ea2408cfa76537267733fbfbc7d82..6b24ddd6b874be7cf667ffa0163569d618b9839a 100644 (file)
@@ -9,11 +9,11 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-18.04]
-        python-version: [3.7, 3.8, 3.9, pypy-3.6, pypy-3.7]
+        python-version: [3.6, 3.7, 3.8, 3.9, pypy-3.6, pypy-3.7]
         run-tests-ext: [sh]
         include:
         - os: windows-latest
-          python-version: 3.6
+          python-version: 3.4  # Windows x86 build is still in 3.4
           run-tests-ext: bat
     steps:
     - uses: actions/checkout@v2
index 92c078a391dda632853a71cb40109a030fa2e6b8..ad96cebcd80ce5f3cbb624e4244cafaca376bc21 100644 (file)
@@ -472,7 +472,8 @@ def __init__(self, params=None, auto_init=True):
 
         if sys.version_info < (3, 6):
             self.report_warning(
-                'Python version %d.%d is not supported! Please update to Python 3.6 or above' % sys.version_info[:2])
+                'Support for Python version %d.%d have been deprecated and will break in future versions of yt-dlp! '
+                'Update to Python 3.6 or above' % sys.version_info[:2])
 
         def check_deprecated(param, option, suggestion):
             if self.params.get(param) is not None:
index d3681b8323b5947650b392434e5179272cd2fe67..c49c78d4b28606f1e6c232273fe26f8730a540a8 100644 (file)
@@ -89,9 +89,13 @@ def calc_sha256sum(path):
 
     err = None
     if isinstance(globals().get('__loader__'), zipimporter):
-        pass
+        # We only support python 3.6 or above
+        if sys.version_info < (3, 6):
+            err = 'This is the last release of yt-dlp for Python version %d.%d! Please update to Python 3.6 or above' % sys.version_info[:2]
     elif hasattr(sys, 'frozen'):
-        pass
+        # Python 3.6 supports only vista and above
+        if sys.getwindowsversion()[0] < 6:
+            err = 'This is the last release of yt-dlp for your version of Windows. Please update to Windows Vista or above'
     else:
         err = 'It looks like you installed yt-dlp with a package manager, pip, setup.py or a tarball. Please use that to update'
     if err: