]> jfr.im git - yt-dlp.git/commitdiff
[ThumbnailsConvertor] Fix filename escaping
authorpukkandan <redacted>
Fri, 11 Nov 2022 08:38:12 +0000 (14:08 +0530)
committerpukkandan <redacted>
Fri, 11 Nov 2022 09:58:19 +0000 (15:28 +0530)
Closes #4604
Authored by: pukkandan, dirkf

yt_dlp/postprocessor/ffmpeg.py

index 76f9d29c5eead7a07f8ef0189a638d19b82ed810..7d55373e1818543c7da14da57e329499d28b0c66 100644 (file)
@@ -1081,9 +1081,9 @@ def fixup_webp(self, info, idx=-1):
 
     @staticmethod
     def _options(target_ext):
+        yield from ('-update', '1')
         if target_ext == 'jpg':
-            return ['-bsf:v', 'mjpeg2jpeg']
-        return []
+            yield from ('-bsf:v', 'mjpeg2jpeg')
 
     def convert_thumbnail(self, thumbnail_filename, target_ext):
         thumbnail_conv_filename = replace_extension(thumbnail_filename, target_ext)
@@ -1092,7 +1092,7 @@ def convert_thumbnail(self, thumbnail_filename, target_ext):
         _, source_ext = os.path.splitext(thumbnail_filename)
         self.real_run_ffmpeg(
             [(thumbnail_filename, [] if source_ext == '.gif' else ['-f', 'image2', '-pattern_type', 'none'])],
-            [(thumbnail_conv_filename.replace('%', '%%'), self._options(target_ext))])
+            [(thumbnail_conv_filename, self._options(target_ext))])
         return thumbnail_conv_filename
 
     def run(self, info):