]> jfr.im git - yt-dlp.git/commitdiff
Revert "Merge webm formats into mkv if thumbnails are to be embedded (#173)"
authorpukkandan <redacted>
Thu, 15 Jul 2021 18:00:49 +0000 (23:30 +0530)
committerpukkandan <redacted>
Thu, 15 Jul 2021 18:04:52 +0000 (23:34 +0530)
This reverts commit 4d971a16b831a45147b6ae7ce53b3e105d204da7 by @damianoamatruda
Closes #500

This was wrongly checking for `write_thumbnail`

yt_dlp/YoutubeDL.py

index 6cfcee455a951ac2be901c883510d0b4386bfd72..5b603690c3f5561effca261a7bb20a57c0bb3bd4 100644 (file)
@@ -2590,17 +2590,10 @@ def compatible_formats(formats):
 
                     requested_formats = info_dict['requested_formats']
                     old_ext = info_dict['ext']
-                    if self.params.get('merge_output_format') is None:
-                        if not compatible_formats(requested_formats):
-                            info_dict['ext'] = 'mkv'
-                            self.report_warning(
-                                'Requested formats are incompatible for merge and will be merged into mkv.')
-                        if (info_dict['ext'] == 'webm'
-                                and self.params.get('writethumbnail', False)
-                                and info_dict.get('thumbnails')):
-                            info_dict['ext'] = 'mkv'
-                            self.report_warning(
-                                'webm doesn\'t support embedding a thumbnail, mkv will be used.')
+                    if self.params.get('merge_output_format') is None and not compatible_formats(requested_formats):
+                        info_dict['ext'] = 'mkv'
+                        self.report_warning(
+                            'Requested formats are incompatible for merge and will be merged into mkv.')
 
                     def correct_ext(filename):
                         filename_real_ext = os.path.splitext(filename)[1][1:]