]> jfr.im git - solanum.git/commitdiff
authd: don't exit() on OPM duplicate scanner errors, just ignore it
authorAaron Jones <redacted>
Mon, 19 Dec 2016 04:56:54 +0000 (04:56 +0000)
committerAaron Jones <redacted>
Mon, 19 Dec 2016 04:57:58 +0000 (04:57 +0000)
I run into this code even with a single kind of scanner with a single
port, so I'm not even sure how it thinks it already exists.

Perhaps it's being parsed twice, or something similar.

c.f. issue #229

authd/providers/opm.c

index 8087bc972a64e9152990cc131c331e7d50a3bb0e..40985b307c38ee97e35e1444cf11c814cdc04685 100644 (file)
@@ -812,7 +812,8 @@ create_opm_scanner(const char *key __unused, int parc __unused, const char **par
        if(find_proxy_scanner(proxy->proto, proxy->port) != NULL)
        {
                warn_opers(L_CRIT, "OPM: got a duplicate scanner: %s (port %hu)", parv[0], proxy->port);
-               exit(EX_PROVIDER_ERROR);
+               rb_free(proxy);
+               return;
        }
 
        rb_dlinkAdd(proxy, &proxy->node, &proxy_scanners);