]> jfr.im git - solanum.git/commitdiff
server: Use rb_strlcpy() instead of strcpy().
authorJilles Tjoelker <redacted>
Sun, 23 Feb 2014 23:04:11 +0000 (00:04 +0100)
committerJilles Tjoelker <redacted>
Sun, 23 Feb 2014 23:04:11 +0000 (00:04 +0100)
An overflow should be impossible here, but be paranoid.

src/s_serv.c

index 1efc7eb05f2620a9ab293548249e237f3be33c9c..6bd4fcab5320bea69f00e1b88224ee12b0213043 100644 (file)
@@ -1191,7 +1191,8 @@ serv_connect(struct server_conf *server_p, struct Client *by)
        make_server(client_p);
        if(by && IsPerson(by))
        {
-               strcpy(client_p->serv->by, by->name);
+               rb_strlcpy(client_p->serv->by, by->name,
+                               sizeof client_p->serv->by);
                if(client_p->serv->user)
                        free_user(client_p->serv->user, NULL);
                client_p->serv->user = by->user;
@@ -1199,7 +1200,8 @@ serv_connect(struct server_conf *server_p, struct Client *by)
        }
        else
        {
-               strcpy(client_p->serv->by, "AutoConn.");
+               rb_strlcpy(client_p->serv->by, "AutoConn.",
+                               sizeof client_p->serv->by);
                if(client_p->serv->user)
                        free_user(client_p->serv->user, NULL);
                client_p->serv->user = NULL;