authd: Avoid negative array indices

diff --git a/authd/provider.c b/authd/provider.c
index 28c4088a1d5f14b630f24ce3a58ec30436a5906f..57aa963d8778788c5ef37df5df2ca68d9eabd4f4 100644 (file)
--- a/authd/provider.c
+++ b/authd/provider.c
@@ -136,7 +136,7 @@ load_provider(struct auth_provider *provider)
        }
 
        if(provider->stats_handler.letter != '\0')
-               authd_stat_handlers[provider->stats_handler.letter] = provider->stats_handler.handler;
+               authd_stat_handlers[(unsigned char)provider->stats_handler.letter] = provider->stats_handler.handler;
 
        if(provider->init != NULL)
                provider->init();
@@ -156,7 +156,7 @@ unload_provider(struct auth_provider *provider)
        }
 
        if(provider->stats_handler.letter != '\0')
-               authd_stat_handlers[provider->stats_handler.letter] = NULL;
+               authd_stat_handlers[(unsigned char)provider->stats_handler.letter] = NULL;
 
        if(provider->destroy != NULL)
                provider->destroy();

diff --git a/ircd/authproc.c b/ircd/authproc.c
index 77ef669f3743e293dd3f21f940b86b8e78e01007..80a1cf756b8e0162bd612fe33e3143b607f1e9e5 100644 (file)
--- a/ircd/authproc.c
+++ b/ircd/authproc.c
@@ -284,7 +284,7 @@ parse_authd_reply(rb_helper * helper)
                struct authd_cb *cmd;
 
                parc = rb_string_to_array(buf, parv, MAXPARA+1);
-               cmd = &authd_cmd_tab[*parv[0]];
+               cmd = &authd_cmd_tab[(unsigned char)*parv[0]];
                if(cmd->fn != NULL)
                {
                        if(cmd->min_parc > parc)

diff --git a/wsockd/wsockd.c b/wsockd/wsockd.c
index 1ab3120ce7fdd7b478aed58b3c2d65c5a88eff36..048f6f4b8981804035a3fb9f38fb5f214d19c7d6 100644 (file)
--- a/wsockd/wsockd.c
+++ b/wsockd/wsockd.c
@@ -731,7 +731,7 @@ conn_mod_read_cb(rb_fde_t *fd, void *data)
 
                length = rb_read(fd, inbuf, sizeof(inbuf));
 
-                if (length < 0)
+               if (length < 0)
                {
                        if (rb_ignore_errno(errno))
                        {