msgbuf_parse(struct MsgBuf *msgbuf, char *line)
{
char *ch;
- char *parv[MAXPARA];
+ char *parv[MAXPARA + 1];
size_t n_para;
- int i;
/* skip any leading spaces */
for (ch = line; *ch && *ch == ' '; ch++)
*ch++ = '\0';
}
+ else
+ ch = t;
}
/* skip any whitespace between tags and origin */
return 1;
msgbuf->cmd = parv[0];
- for (i = 0; i < n_para; i++)
+ for (size_t i = 0; i < n_para; i++)
msgbuf_append_para(msgbuf, parv[i]);
return 0;
}
-static int
-msgbuf_has_matching_tags(struct MsgBuf *msgbuf, unsigned int capmask)
-{
- int i;
-
- for (i = 0; i < msgbuf->n_tags; i++)
- {
- if ((msgbuf->tags[i].capmask & capmask) != 0)
- return 1;
- }
-
- return 0;
-}
-
static void
msgbuf_unparse_tags(char *buf, size_t buflen, struct MsgBuf *msgbuf, unsigned int capmask)
{
- int i;
-
- if (!msgbuf_has_matching_tags(msgbuf, capmask))
- return;
+ bool has_tags = false;
- *buf = '@';
-
- for (i = 0; i < msgbuf->n_tags; i++)
+ for (size_t i = 0; i < msgbuf->n_tags; i++)
{
if ((msgbuf->tags[i].capmask & capmask) == 0)
continue;
- if (i != 0)
+ if (has_tags) {
rb_strlcat(buf, ";", buflen);
+ } else {
+ *buf = '@';
+ has_tags = true;
+ }
rb_strlcat(buf, msgbuf->tags[i].key, buflen);
}
}
- rb_strlcat(buf, " ", buflen);
+ if (has_tags)
+ rb_strlcat(buf, " ", buflen);
}
void
int
msgbuf_unparse(char *buf, size_t buflen, struct MsgBuf *msgbuf, unsigned int capmask)
{
- int i;
-
msgbuf_unparse_prefix(buf, buflen, msgbuf, capmask);
- for (i = msgbuf->cmd != NULL ? 0 : 1; i < msgbuf->n_para; i++)
+ for (size_t i = msgbuf->cmd != NULL ? 0 : 1; i < msgbuf->n_para; i++)
{
if (i == (msgbuf->n_para - 1))
{