]> jfr.im git - solanum.git/blobdiff - ircd/newconf.c
authd: misc fixes
[solanum.git] / ircd / newconf.c
index 42244f85f33bd294aa3ea80e1815c5a8ee72b329..347f0f255ad39d23ec41b7c8cbdc8ec457dee5c2 100644 (file)
@@ -1,5 +1,4 @@
 /* This code is in the public domain.
- * $Id: newconf.c 3550 2007-08-09 06:47:26Z nenolod $
  */
 
 #include "stdinc.h"
@@ -11,7 +10,6 @@
 
 #include "newconf.h"
 #include "ircd_defs.h"
-#include "common.h"
 #include "logger.h"
 #include "s_conf.h"
 #include "s_user.h"
@@ -26,7 +24,6 @@
 #include "cache.h"
 #include "ircd.h"
 #include "snomask.h"
-#include "blacklist.h"
 #include "sslproc.h"
 #include "privilege.h"
 #include "chmode.h"
@@ -57,8 +54,7 @@ static struct alias_entry *yy_alias = NULL;
 
 static char *yy_blacklist_host = NULL;
 static char *yy_blacklist_reason = NULL;
-static int yy_blacklist_ipv4 = 1;
-static int yy_blacklist_ipv6 = 0;
+static uint8_t yy_blacklist_iptype = 0;
 static rb_dlink_list yy_blacklist_filters;
 
 static char *yy_privset_extends = NULL;
@@ -240,7 +236,7 @@ conf_set_serverinfo_vhost(void *data)
 {
        if(rb_inet_pton(AF_INET, (char *) data, &ServerInfo.ip.sin_addr) <= 0)
        {
-               conf_report_error("Invalid netmask for server IPv4 vhost (%s)", (char *) data);
+               conf_report_error("Invalid IPv4 address for server vhost (%s)", (char *) data);
                return;
        }
        ServerInfo.ip.sin_family = AF_INET;
@@ -253,7 +249,7 @@ conf_set_serverinfo_vhost6(void *data)
 #ifdef RB_IPV6
        if(rb_inet_pton(AF_INET6, (char *) data, &ServerInfo.ip6.sin6_addr) <= 0)
        {
-               conf_report_error("Invalid netmask for server IPv6 vhost (%s)", (char *) data);
+               conf_report_error("Invalid IPv6 address for server vhost (%s)", (char *) data);
                return;
        }
 
@@ -291,7 +287,7 @@ conf_set_modules_module(void *data)
        m_bn = rb_basename((char *) data);
 
        if(findmodule_byname(m_bn) == -1)
-               load_one_module((char *) data, 0);
+               load_one_module((char *) data, MAPI_ORIGIN_EXTENSION, 0);
 
        rb_free(m_bn);
 }
@@ -391,6 +387,7 @@ static struct mode_table shared_table[] =
        { "rehash",     SHARED_REHASH   },
        { "grant",      SHARED_GRANT    },
        { "die",        SHARED_DIE      },
+       { "module",     SHARED_MODULE   },
        { "all",        SHARED_ALL      },
        { "none",       0               },
        {NULL, 0}
@@ -861,6 +858,11 @@ conf_set_listen_port_both(void *data, int ssl)
                }
                 if(listener_address == NULL)
                 {
+                       if (!ssl)
+                       {
+                               conf_report_warning("listener 'ANY/%d': support for plaintext listeners may be removed in a future release per RFC 7194.  "
+                                                    "It is suggested that users be migrated to SSL/TLS connections.", args->v.number);
+                       }
                        add_listener(args->v.number, listener_address, AF_INET, ssl, ssl || yy_defer_accept);
 #ifdef RB_IPV6
                        add_listener(args->v.number, listener_address, AF_INET6, ssl, ssl || yy_defer_accept);
@@ -876,8 +878,13 @@ conf_set_listen_port_both(void *data, int ssl)
 #endif
                                family = AF_INET;
 
-                       add_listener(args->v.number, listener_address, family, ssl, ssl || yy_defer_accept);
+                       if (!ssl)
+                       {
+                               conf_report_warning("listener '%s/%d': support for plaintext listeners may be removed in a future release per RFC 7194.  "
+                                                    "It is suggested that users be migrated to SSL/TLS connections.", listener_address, args->v.number);
+                       }
 
+                       add_listener(args->v.number, listener_address, family, ssl, ssl || yy_defer_accept);
                 }
 
        }
@@ -1315,7 +1322,7 @@ conf_set_connect_vhost(void *data)
 {
        if(rb_inet_pton_sock(data, (struct sockaddr *)&yy_server->my_ipnum) <= 0)
        {
-               conf_report_error("Invalid netmask for server vhost (%s)",
+               conf_report_error("Invalid IP address for server connect vhost (%s)",
                                  (char *) data);
                return;
        }
@@ -1543,7 +1550,7 @@ conf_set_general_kline_delay(void *data)
        ConfigFileEntry.kline_delay = *(unsigned int *) data;
 
        /* THIS MUST BE HERE to stop us being unable to check klines */
-       kline_queued = 0;
+       kline_queued = false;
 }
 
 static void
@@ -1770,7 +1777,7 @@ conf_end_alias(struct TopConf *tc)
                return -1;
        }
 
-       irc_dictionary_add(alias_dict, yy_alias->name, yy_alias);
+       rb_dictionary_add(alias_dict, yy_alias->name, yy_alias);
 
        return 0;
 }
@@ -1832,6 +1839,9 @@ conf_set_channel_autochanmodes(void *data)
 /* XXX for below */
 static void conf_set_blacklist_reason(void *data);
 
+#define IPTYPE_IPV4 1
+#define IPTYPE_IPV6 2
+
 static void
 conf_set_blacklist_host(void *data)
 {
@@ -1845,8 +1855,7 @@ conf_set_blacklist_host(void *data)
                return;
        }
 
-       yy_blacklist_ipv4 = 1;
-       yy_blacklist_ipv6 = 0;
+       yy_blacklist_iptype |= IPTYPE_IPV4;
        yy_blacklist_host = rb_strdup(data);
 }
 
@@ -1856,25 +1865,24 @@ conf_set_blacklist_type(void *data)
        conf_parm_t *args = data;
 
        /* Don't assume we have either if we got here */
-       yy_blacklist_ipv4 = 0;
-       yy_blacklist_ipv6 = 0;
+       yy_blacklist_iptype = 0;
 
        for (; args; args = args->next)
        {
                if (!strcasecmp(args->v.string, "ipv4"))
-                       yy_blacklist_ipv4 = 1;
+                       yy_blacklist_iptype |= IPTYPE_IPV4;
                else if (!strcasecmp(args->v.string, "ipv6"))
-                       yy_blacklist_ipv6 = 1;
+                       yy_blacklist_iptype |= IPTYPE_IPV6;
                else
                        conf_report_error("blacklist::type has unknown address family %s",
                                          args->v.string);
        }
 
        /* If we have neither, just default to IPv4 */
-       if (!yy_blacklist_ipv4 && !yy_blacklist_ipv6)
+       if (!yy_blacklist_iptype)
        {
                conf_report_error("blacklist::type has neither IPv4 nor IPv6 (defaulting to IPv4)");
-               yy_blacklist_ipv4 = 1;
+               yy_blacklist_iptype = IPTYPE_IPV4;
        }
 }
 
@@ -1882,13 +1890,13 @@ static void
 conf_set_blacklist_matches(void *data)
 {
        conf_parm_t *args = data;
+       enum filter_t { FILTER_NONE, FILTER_ALL, FILTER_LAST };
 
        for (; args; args = args->next)
        {
-               struct BlacklistFilter *filter;
                char *str = args->v.string;
                char *p;
-               int type = BLACKLIST_FILTER_LAST;
+               enum filter_t type = FILTER_LAST;
 
                if (CF_TYPE(args->type) != CF_QSTRING)
                {
@@ -1913,17 +1921,17 @@ conf_set_blacklist_matches(void *data)
                {
                        /* Check for validity */
                        if (*p == '.')
-                               type = BLACKLIST_FILTER_ALL;
-                       else if (!isalnum((unsigned char)*p))
+                               type = FILTER_ALL;
+                       else if (!isdigit((unsigned char)*p))
                        {
                                conf_report_error("blacklist::matches has invalid IP match entry %s",
                                                str);
-                               type = 0;
+                               type = FILTER_NONE;
                                break;
                        }
                }
 
-               if (type == BLACKLIST_FILTER_ALL)
+               if (type == FILTER_ALL)
                {
                        /* Basic IP sanity check */
                        struct rb_sockaddr_storage tmp;
@@ -1934,7 +1942,7 @@ conf_set_blacklist_matches(void *data)
                                continue;
                        }
                }
-               else if (type == BLACKLIST_FILTER_LAST)
+               else if (type == FILTER_LAST)
                {
                        /* Verify it's the correct length */
                        if (strlen(str) > 3)
@@ -1949,11 +1957,7 @@ conf_set_blacklist_matches(void *data)
                        continue; /* Invalid entry */
                }
 
-               filter = rb_malloc(sizeof(struct BlacklistFilter));
-               filter->type = type;
-               rb_strlcpy(filter->filterstr, str, sizeof(filter->filterstr));
-
-               rb_dlinkAdd(filter, &filter->node, &yy_blacklist_filters);
+               rb_dlinkAddAlloc(rb_strdup(str), &yy_blacklist_filters);
        }
 }
 
@@ -1965,7 +1969,7 @@ conf_set_blacklist_reason(void *data)
        if (yy_blacklist_host && data)
        {
                yy_blacklist_reason = rb_strdup(data);
-               if (yy_blacklist_ipv6)
+               if (yy_blacklist_iptype & IPTYPE_IPV4)
                {
                        /* Make sure things fit (64 = alnum count + dots) */
                        if ((64 + strlen(yy_blacklist_host)) > IRCD_RES_HOSTLEN)
@@ -1976,7 +1980,7 @@ conf_set_blacklist_reason(void *data)
                        }
                }
                /* Avoid doing redundant check, IPv6 is bigger than IPv4 --Elizabeth */
-               if (yy_blacklist_ipv4 && !yy_blacklist_ipv6)
+               if ((yy_blacklist_iptype & IPTYPE_IPV4) && !(yy_blacklist_iptype & IPTYPE_IPV6))
                {
                        /* Make sure things fit (16 = number of nums + dots) */
                        if ((16 + strlen(yy_blacklist_host)) > IRCD_RES_HOSTLEN)
@@ -1987,30 +1991,23 @@ conf_set_blacklist_reason(void *data)
                        }
                }
 
-               new_blacklist(yy_blacklist_host, yy_blacklist_reason, yy_blacklist_ipv4, yy_blacklist_ipv6,
-                               &yy_blacklist_filters);
+               add_blacklist(yy_blacklist_host, yy_blacklist_reason, yy_blacklist_iptype, &yy_blacklist_filters);
        }
 
 cleanup_bl:
-       if (data == NULL)
+       RB_DLINK_FOREACH_SAFE(ptr, nptr, yy_blacklist_filters.head)
        {
-               RB_DLINK_FOREACH_SAFE(ptr, nptr, yy_blacklist_filters.head)
-               {
-                       rb_dlinkDelete(ptr, &yy_blacklist_filters);
-                       rb_free(ptr);
-               }
-       }
-       else
-       {
-               yy_blacklist_filters = (rb_dlink_list){ NULL, NULL, 0 };
+               rb_free(ptr->data);
+               rb_dlinkDestroy(ptr, &yy_blacklist_filters);
        }
 
+       yy_blacklist_filters = (rb_dlink_list){ NULL, NULL, 0 };
+
        rb_free(yy_blacklist_host);
        rb_free(yy_blacklist_reason);
        yy_blacklist_host = NULL;
        yy_blacklist_reason = NULL;
-       yy_blacklist_ipv4 = 1;
-       yy_blacklist_ipv6 = 0;
+       yy_blacklist_iptype = 0;
 }
 
 /* public functions */
@@ -2020,10 +2017,10 @@ void
 conf_report_error(const char *fmt, ...)
 {
        va_list ap;
-       char msg[IRCD_BUFSIZE + 1] = { 0 };
+       char msg[BUFSIZE + 1] = { 0 };
 
        va_start(ap, fmt);
-       rb_vsnprintf(msg, IRCD_BUFSIZE, fmt, ap);
+       vsnprintf(msg, BUFSIZE, fmt, ap);
        va_end(ap);
 
        if (testing_conf)
@@ -2033,7 +2030,27 @@ conf_report_error(const char *fmt, ...)
        }
 
        ierror("\"%s\", line %d: %s", current_file, lineno + 1, msg);
-       sendto_realops_snomask(SNO_GENERAL, L_ALL, "\"%s\", line %d: %s", current_file, lineno + 1, msg);
+       sendto_realops_snomask(SNO_GENERAL, L_ALL, "error: \"%s\", line %d: %s", current_file, lineno + 1, msg);
+}
+
+void
+conf_report_warning(const char *fmt, ...)
+{
+       va_list ap;
+       char msg[BUFSIZE + 1] = { 0 };
+
+       va_start(ap, fmt);
+       vsnprintf(msg, BUFSIZE, fmt, ap);
+       va_end(ap);
+
+       if (testing_conf)
+       {
+               fprintf(stderr, "\"%s\", line %d: %s\n", current_file, lineno + 1, msg);
+               return;
+       }
+
+       iwarn("\"%s\", line %d: %s", current_file, lineno + 1, msg);
+       sendto_realops_snomask(SNO_GENERAL, L_ALL, "warning: \"%s\", line %d: %s", current_file, lineno + 1, msg);
 }
 
 int
@@ -2235,7 +2252,6 @@ remove_conf_item(const char *topconf, const char *name)
 static struct ConfEntry conf_serverinfo_table[] =
 {
        { "description",        CF_QSTRING, NULL, 0, &ServerInfo.description    },
-       { "hub",                CF_YESNO,   NULL, 0, &ServerInfo.hub            },
 
        { "network_name",       CF_QSTRING, conf_set_serverinfo_network_name,   0, NULL },
        { "name",               CF_QSTRING, conf_set_serverinfo_name,   0, NULL },
@@ -2427,6 +2443,7 @@ static struct ConfEntry conf_general_table[] =
        { "client_flood_message_time",  CF_INT,   NULL, 0, &ConfigFileEntry.client_flood_message_time   },
        { "max_ratelimit_tokens",       CF_INT,   NULL, 0, &ConfigFileEntry.max_ratelimit_tokens        },
        { "away_interval",              CF_INT,   NULL, 0, &ConfigFileEntry.away_interval               },
+       { "hide_opers_in_whois",        CF_YESNO, NULL, 0, &ConfigFileEntry.hide_opers_in_whois         },
        { "certfp_method",      CF_STRING, conf_set_general_certfp_method, 0, NULL },
        { "\0",                 0,        NULL, 0, NULL }
 };
@@ -2455,6 +2472,7 @@ static struct ConfEntry conf_channel_table[] =
        { "disable_local_channels", CF_YESNO, NULL, 0, &ConfigChannel.disable_local_channels },
        { "autochanmodes",      CF_QSTRING, conf_set_channel_autochanmodes, 0, NULL     },
        { "displayed_usercount",        CF_INT, NULL, 0, &ConfigChannel.displayed_usercount     },
+       { "strip_topic_colors", CF_YESNO, NULL, 0, &ConfigChannel.strip_topic_colors    },
        { "\0",                 0,        NULL, 0, NULL }
 };