ircd/packet.c: make function definition consistent with declaration (#301)

[solanum.git] / modules / m_privs.c

diff --git a/modules/m_privs.c b/modules/m_privs.c
index fff49a85224c7981141c3bff535a44d95d59c3c4..5e637576bd69f0b5aaa03dbe84f630c97fff0ef3 100644 (file)
--- a/modules/m_privs.c
+++ b/modules/m_privs.c
@@ -81,57 +81,44 @@ static struct mode_table auth_client_table[] = {
 
 DECLARE_MODULE_AV2(privs, NULL, NULL, privs_clist, NULL, NULL, NULL, NULL, privs_desc);
 
-static void append_priv(struct Client *source_p, struct Client *target_p, char *buf, const char *s1, const char *s2)
-{
-       /* 510 - ":" - " 270 " - " " - " :* " */
-       size_t sourcelen = strlen(source_p->name);
-       if (sourcelen < 9) sourcelen = 9;
-       size_t limit = 499 - strlen(me.name) - sourcelen - strlen(target_p->name);
-       if (strlen(s1) + strlen(s2) + strlen(buf) + 1 > limit)
-       {
-               sendto_one_numeric(source_p, RPL_PRIVS, "%s :* %s", target_p->name, buf);
-               buf[0] = '\0';
-       }
-       if (buf[0] != '\0')
-               rb_strlcat(buf, " ", BUFSIZE);
-       rb_strlcat(buf, s1, BUFSIZE);
-       rb_strlcat(buf, s2, BUFSIZE);
-}
-
 static void show_privs(struct Client *source_p, struct Client *target_p)
 {
-       char buf[BUFSIZE];
        struct mode_table *p;
 
-       buf[0] = '\0';
+       send_multiline_init(source_p, " ", form_str(RPL_PRIVS),
+                       get_id(&me, source_p),
+                       get_id(source_p, source_p),
+                       target_p->name,
+                       "* ");
+
+       send_multiline_remote_pad(source_p, &me);
+       send_multiline_remote_pad(source_p, source_p);
 
        if (target_p->user->privset)
-               for (char *s = target_p->user->privset->privs; s != NULL; (s = strchr(s, ' ')) && s++)
-               {
-                       char *c = strchr(s, ' ');
-                       if (c) *c = '\0';
-                       append_priv(source_p, target_p, buf, s, "");
-                       if (c) *c = ' ';
-               }
+               for (const char *const *s = privilegeset_privs(target_p->user->privset); *s != NULL; s++)
+                       send_multiline_item(source_p, "%s", *s);
 
        if (IsOper(target_p))
        {
                if (target_p->user->opername)
-                       append_priv(source_p, target_p, buf, "operator:", target_p->user->opername);
+                       send_multiline_item(source_p, "operator:%s", target_p->user->opername);
 
                if (target_p->user->privset)
-                       append_priv(source_p, target_p, buf, "privset:", target_p->user->privset->name);
+                       send_multiline_item(source_p, "privset:%s", target_p->user->privset->name);
        }
        p = &auth_client_table[0];
        while (p->name != NULL)
        {
                if (target_p->flags & p->mode)
-                       append_priv(source_p, target_p, buf, p->name, "");
+                       send_multiline_item(source_p, "%s", p->name);
                p++;
        }
 
-       if (buf[0] != '\0')
-               sendto_one_numeric(source_p, RPL_PRIVS, "%s :%s", target_p->name, buf);
+       send_multiline_fini(source_p, form_str(RPL_PRIVS),
+                       get_id(&me, source_p),
+                       get_id(source_p, source_p),
+                       target_p->name,
+                       "");
 }
 
 static void
@@ -177,6 +164,13 @@ mo_privs(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source
                }
        }
 
+       if (target_p != source_p && !HasPrivilege(source_p, "oper:privs"))
+       {
+               sendto_one(source_p, form_str(ERR_NOPRIVS),
+                          me.name, source_p->name, "privs");
+               return;
+       }
+
        if (!IsServer(server_p))
                server_p = server_p->servptr;