providers/ident: fix some nasty crashes

[solanum.git] / modules / m_help.c

diff --git a/modules/m_help.c b/modules/m_help.c
index 8dceed5bb8664cdebd3f5d3359ce949bc1927e56..251b20ca7bfea8049b80e91769fb7c548f704b10 100644 (file)
--- a/modules/m_help.c
+++ b/modules/m_help.c
@@ -36,9 +36,12 @@
 #include "cache.h"
 #include "rb_dictionary.h"
 
-static int m_help(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
-static int mo_help(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
-static int mo_uhelp(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static const char help_desc[] =
+       "Provides the help facility for commands, modes, and server concepts";
+
+static void m_help(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void mo_help(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void mo_uhelp(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
 static void dohelp(struct Client *, int, const char *);
 
 struct Message help_msgtab = {
@@ -52,41 +55,34 @@ struct Message uhelp_msgtab = {
 
 mapi_clist_av1 help_clist[] = { &help_msgtab, &uhelp_msgtab, NULL };
 
-static const char help_desc[] =
-       "Provides the help facility for commands, modes, and server concepts";
-
 DECLARE_MODULE_AV2(help, NULL, NULL, help_clist, NULL, NULL, NULL, NULL, help_desc);
 
 /*
  * m_help - HELP message handler
  */
-static int
+static void
 m_help(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
        dohelp(source_p, HELP_USER, parc > 1 ? parv[1] : NULL);
-
-       return 0;
 }
 
 /*
  * mo_help - HELP message handler
  */
-static int
+static void
 mo_help(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
        dohelp(source_p, HELP_OPER, parc > 1 ? parv[1] : NULL);
-       return 0;
 }
 
 /*
  * mo_uhelp - HELP message handler
  * This is used so that opers can view the user help file without deopering
  */
-static int
+static void
 mo_uhelp(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
        dohelp(source_p, HELP_USER, parc > 1 ? parv[1] : NULL);
-       return 0;
 }
 
 static void
@@ -127,5 +123,4 @@ dohelp(struct Client *source_p, int flags, const char *topic)
 
        sendto_one(source_p, form_str(RPL_ENDOFHELP),
                   me.name, source_p->name, topic);
-       return;
 }