extb_combi: More int to bool conversion

[solanum.git] / extensions / helpops.c

diff --git a/extensions/helpops.c b/extensions/helpops.c
index 2dad817ca8dd495df7e287de979bddddbc398300..c2a7e00cf96bfba4bd3db63b18c02052ce0afc16 100644 (file)
--- a/extensions/helpops.c
+++ b/extensions/helpops.c
@@ -14,15 +14,17 @@
 #include "s_newconf.h"
 #include "numeric.h"
 
+static const char helpops_desc[] = "The helpops system as used by freenode";
+
 static rb_dlink_list helper_list = { NULL, NULL, 0 };
 static void h_hdl_stats_request(hook_data_int *hdata);
 static void h_hdl_new_remote_user(struct Client *client_p);
 static void h_hdl_client_exit(hook_data_client_exit *hdata);
 static void h_hdl_umode_changed(hook_data_umode_changed *hdata);
 static void h_hdl_whois(hook_data_client *hdata);
-static int mo_dehelper(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
-static int me_dehelper(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
-static int do_dehelper(struct Client *source_p, struct Client *target_p);
+static void mo_dehelper(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void me_dehelper(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void do_dehelper(struct Client *source_p, struct Client *target_p);
 
 mapi_hfn_list_av1 helpops_hfnlist[] = {
        { "doing_stats", (hookfn) h_hdl_stats_request },
@@ -43,20 +45,21 @@ struct Message dehelper_msgtab = {
 
 mapi_clist_av1 helpops_clist[] = { &dehelper_msgtab, NULL };
 
-static int mo_dehelper(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char **parv)
+static void
+mo_dehelper(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char **parv)
 {
        struct Client *target_p;
 
        if (!IsOperAdmin(source_p))
        {
                sendto_one(source_p, form_str(ERR_NOPRIVS), me.name, source_p->name, "admin");
-               return 0;
+               return;
        }
 
        if(!(target_p = find_named_person(parv[1])))
        {
                sendto_one_numeric(source_p, ERR_NOSUCHNICK, form_str(ERR_NOSUCHNICK), parv[1]);
-               return 0;
+               return;
        }
 
        if(MyClient(target_p))
@@ -64,31 +67,30 @@ static int mo_dehelper(struct MsgBuf *msgbuf_p, struct Client *client_p, struct
        else
                sendto_one(target_p, ":%s ENCAP %s DEHELPER %s",
                                use_id(source_p), target_p->servptr->name, use_id(target_p));
-
-       return 0;
 }
 
-static int me_dehelper(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char **parv)
+static void
+me_dehelper(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char **parv)
 {
        struct Client *target_p = find_person(parv[1]);
        if(!target_p)
        {
                sendto_one_numeric(source_p, ERR_NOSUCHNICK, form_str(ERR_NOSUCHNICK), parv[1]);
-               return 0;
+               return;
        }
        if(!MyClient(target_p))
-               return 0;
+               return;
 
        do_dehelper(source_p, target_p);
-       return 0;
 }
 
-static int do_dehelper(struct Client *source_p, struct Client *target_p)
+static void
+do_dehelper(struct Client *source_p, struct Client *target_p)
 {
        const char *fakeparv[4];
 
        if(!(target_p->umodes & UMODE_HELPOPS))
-               return 0;
+               return;
 
        sendto_realops_snomask(SNO_GENERAL, L_NETWIDE, "%s is using DEHELPER on %s",
                        source_p->name, target_p->name);
@@ -98,7 +100,6 @@ static int do_dehelper(struct Client *source_p, struct Client *target_p)
        fakeparv[2] = "-H";
        fakeparv[3] = NULL;
        user_mode(target_p, target_p, 3, fakeparv);
-       return 0;
 }
 
 static int
@@ -200,4 +201,4 @@ h_hdl_whois(hook_data_client *hdata)
        }
 }
 
-DECLARE_MODULE_AV1(helpops, _modinit, _moddeinit, helpops_clist, NULL, helpops_hfnlist, "");
+DECLARE_MODULE_AV2(helpops, _modinit, _moddeinit, helpops_clist, NULL, helpops_hfnlist, NULL, NULL, helpops_desc);