static int
_modinit(void)
{
+ rb_dlink_node *ptr;
+
user_modes[UMODECHAR_HELPOPS] = find_umode_slot();
construct_umodebuf();
+ RB_DLINK_FOREACH (ptr, global_client_list.head)
+ {
+ struct Client *client_p = ptr->data;
+ if (IsPerson(client_p) && (client_p->umodes & user_modes[UMODECHAR_HELPOPS]))
+ helper_add(client_p);
+ }
+
return 0;
}
static void
_moddeinit(void)
{
+ rb_dlink_node *n, *tn;
+
user_modes[UMODECHAR_HELPOPS] = 0;
construct_umodebuf();
+
+ RB_DLINK_FOREACH_SAFE(n, tn, helper_list.head)
+ rb_dlinkDestroy(n, &helper_list);
}
static void
struct Client *source_p = hdata->client;
/* didn't change +H umode, we don't need to do anything */
- if (!((hdata->oldumodes ^ source_p->umodes) & user_modes[UMODECHAR_HELPOPS]))
- return;
+ bool changed = (hdata->oldumodes ^ source_p->umodes) & user_modes[UMODECHAR_HELPOPS];
if (source_p->umodes & user_modes[UMODECHAR_HELPOPS])
{
{
source_p->umodes &= ~user_modes[UMODECHAR_HELPOPS];
sendto_one(source_p, form_str(ERR_NOPRIVS), me.name, source_p->name, "usermode:helpops");
+ /* they didn't ask for +H so we must be removing it */
+ if (!changed)
+ helper_delete(source_p);
return;
}
- helper_add(source_p);
+ if (changed)
+ helper_add(source_p);
}
- else if (!(source_p->umodes & user_modes[UMODECHAR_HELPOPS]))
+ else if (changed)
+ {
helper_delete(source_p);
+ }
}
static void