parse: check IsServer() before firing off a remove_unknowns() call

[solanum.git] / modules / m_whois.c

diff --git a/modules/m_whois.c b/modules/m_whois.c
index cb2ed0d5dcd5c5fc5cc5ba511ed3e8d45cc5ec3a..3caf1330d92bda87b37522bdf2d1f33ef40edd99 100644 (file)
--- a/modules/m_whois.c
+++ b/modules/m_whois.c
@@ -20,8 +20,6 @@
  *  along with this program; if not, write to the Free Software
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
  *  USA
- *
- *  $Id: m_whois.c 3536 2007-07-14 21:50:21Z jilles $
  */
 
 #include "stdinc.h"
@@ -47,14 +45,17 @@
 #include "ratelimit.h"
 #include "s_assert.h"
 
+static const char whois_desc[] =
+       "Provides the WHOIS command to display information about a user";
+
 static void do_whois(struct Client *client_p, struct Client *source_p, int parc, const char *parv[]);
 static void single_whois(struct Client *source_p, struct Client *target_p, int operspy);
 
-static int m_whois(struct Client *, struct Client *, int, const char **);
-static int ms_whois(struct Client *, struct Client *, int, const char **);
+static void m_whois(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void ms_whois(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
 
 struct Message whois_msgtab = {
-       "WHOIS", 0, 0, 0, MFLG_SLOW,
+       "WHOIS", 0, 0, 0, 0,
        {mg_unreg, {m_whois, 2}, {ms_whois, 2}, mg_ignore, mg_ignore, {m_whois, 2}}
 };
 
@@ -70,14 +71,14 @@ mapi_hlist_av1 whois_hlist[] = {
        { NULL, NULL }
 };
 
-DECLARE_MODULE_AV1(whois, NULL, NULL, whois_clist, whois_hlist, NULL, "$Revision: 3536 $");
+DECLARE_MODULE_AV2(whois, NULL, NULL, whois_clist, whois_hlist, NULL, NULL, NULL, whois_desc);
 
 /*
  * m_whois
  *      parv[1] = nickname masklist
  */
-static int
-m_whois(struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
+static void
+m_whois(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
        static time_t last_used = 0;
 
@@ -87,7 +88,7 @@ m_whois(struct Client *client_p, struct Client *source_p, int parc, const char *
                {
                        sendto_one(source_p, form_str(ERR_NONICKNAMEGIVEN),
                                        me.name, source_p->name);
-                       return 0;
+                       return;
                }
 
                if(!IsOper(source_p))
@@ -99,7 +100,7 @@ m_whois(struct Client *client_p, struct Client *source_p, int parc, const char *
                                           me.name, source_p->name, "WHOIS");
                                sendto_one_numeric(source_p, RPL_ENDOFWHOIS,
                                                   form_str(RPL_ENDOFWHOIS), parv[2]);
-                               return 0;
+                               return;
                        }
                        else
                                last_used = rb_current_time();
@@ -107,14 +108,12 @@ m_whois(struct Client *client_p, struct Client *source_p, int parc, const char *
 
                if(hunt_server(client_p, source_p, ":%s WHOIS %s :%s", 1, parc, parv) !=
                   HUNTED_ISME)
-                       return 0;
+                       return;
 
                parv[1] = parv[2];
 
        }
        do_whois(client_p, source_p, parc, parv);
-
-       return 0;
 }
 
 /*
@@ -122,8 +121,8 @@ m_whois(struct Client *client_p, struct Client *source_p, int parc, const char *
  *      parv[1] = server to reply
  *      parv[2] = nickname to whois
  */
-static int
-ms_whois(struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
+static void
+ms_whois(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
        struct Client *target_p;
 
@@ -135,7 +134,7 @@ ms_whois(struct Client *client_p, struct Client *source_p, int parc, const char
        {
                sendto_one(source_p, form_str(ERR_NONICKNAMEGIVEN),
                                me.name, source_p->name);
-               return 0;
+               return;
        }
 
        /* check if parv[1] exists */
@@ -144,7 +143,7 @@ ms_whois(struct Client *client_p, struct Client *source_p, int parc, const char
                sendto_one_numeric(source_p, ERR_NOSUCHSERVER,
                                   form_str(ERR_NOSUCHSERVER),
                                   IsDigit(parv[1][0]) ? "*" : parv[1]);
-               return 0;
+               return;
        }
 
        /* if parv[1] isnt my client, or me, someone else is supposed
@@ -155,7 +154,7 @@ ms_whois(struct Client *client_p, struct Client *source_p, int parc, const char
                sendto_one(target_p, ":%s WHOIS %s :%s",
                           get_id(source_p, target_p),
                           get_id(target_p, target_p), parv[2]);
-               return 0;
+               return;
        }
 
        /* ok, the target is either us, or a client on our server, so perform the whois
@@ -164,8 +163,6 @@ ms_whois(struct Client *client_p, struct Client *source_p, int parc, const char
         */
        parv[1] = parv[2];
        do_whois(client_p, source_p, parc, parv);
-
-       return 0;
 }
 
 /* do_whois
@@ -214,7 +211,6 @@ do_whois(struct Client *client_p, struct Client *source_p, int parc, const char
 
        sendto_one_numeric(source_p, RPL_ENDOFWHOIS,
                           form_str(RPL_ENDOFWHOIS), parv[1]);
-       return;
 }
 
 /*
@@ -371,7 +367,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
                                           target_p->name, target_p->sockhost);
 
 #ifdef RB_IPV6
-               if (target_p->localClient->ip.ss_family == AF_INET6 &&
+               if (GET_SS_FAMILY(&target_p->localClient->ip) == AF_INET6 &&
                                (show_ip(source_p, target_p) ||
                                 (source_p == target_p && !IsIPSpoof(target_p))) &&
                                ipv4_from_ipv6((struct sockaddr_in6 *)&target_p->localClient->ip, &ip4))
@@ -420,6 +416,4 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
                call_hook(doing_whois_hook, &hdata);
        else
                call_hook(doing_whois_global_hook, &hdata);
-
-       return;
 }