]> jfr.im git - solanum.git/blobdiff - modules/core/m_server.c
m_info: Correct description of general::client_exit like in example confs.
[solanum.git] / modules / core / m_server.c
index f483509038e37b0b2019ef03194b4bf29a35bfc7..b9ae59c03db8c21116309883b36bd011ccdd51b2 100644 (file)
@@ -64,7 +64,6 @@ static int set_server_gecos(struct Client *, const char *);
 
 /*
  * mr_server - SERVER message handler
- *      parv[0] = sender prefix
  *      parv[1] = servername
  *      parv[2] = serverinfo/hopcount
  *      parv[3] = serverinfo
@@ -76,6 +75,8 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
        const char *name;
        struct Client *target_p;
        int hop;
+       unsigned int required_mask;
+       const char *missing;
 
        name = parv[1];
        hop = atoi(parv[2]);
@@ -85,7 +86,7 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
        {
                sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
                                "Server %s has unexpected name %s",
-                               get_server_name(client_p, HIDE_IP), name);
+                               client_p->name, name);
                ilog(L_SERVER, "Server %s has unexpected name %s",
                                log_client_name(client_p, SHOW_IP), name);
                exit_client(client_p, client_p, client_p, "Server name mismatch");
@@ -98,7 +99,7 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
        if(!DoesTS(client_p))
        {
                sendto_realops_snomask(SNO_GENERAL, L_ALL, "Link %s dropped, non-TS server",
-                                    get_server_name(client_p, HIDE_IP));
+                                    client_p->name);
                exit_client(client_p, client_p, client_p, "Non-TS server");
                return 0;
        }
@@ -119,7 +120,7 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
                        sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                             "Unauthorised server connection attempt from %s: "
                                             "No entry for servername %s",
-                                            get_server_name(client_p, HIDE_IP), name);
+                                            "[@255.255.255.255]", name);
 
                        ilog(L_SERVER, "Access denied, no connect block for server %s%s",
                             EmptyString(client_p->name) ? name : "",
@@ -134,14 +135,14 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
        case -2:
                sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
                                     "Unauthorised server connection attempt from %s: "
-                                    "Bad password for server %s",
-                                    get_server_name(client_p, HIDE_IP), name);
+                                    "Bad credentials for server %s",
+                                    "[@255.255.255.255]", name);
 
-               ilog(L_SERVER, "Access denied, invalid password for server %s%s",
+               ilog(L_SERVER, "Access denied, invalid credentials for server %s%s",
                     EmptyString(client_p->name) ? name : "",
                     log_client_name(client_p, SHOW_IP));
 
-               exit_client(client_p, client_p, client_p, "Invalid password.");
+               exit_client(client_p, client_p, client_p, "Invalid credentials.");
                return 0;
                /* NOT REACHED */
                break;
@@ -150,7 +151,7 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Unauthorised server connection attempt from %s: "
                                     "Invalid host for server %s",
-                                    get_server_name(client_p, HIDE_IP), name);
+                                    "[@255.255.255.255]", name);
 
                ilog(L_SERVER, "Access denied, invalid host for server %s%s",
                     EmptyString(client_p->name) ? name : "",
@@ -165,7 +166,7 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
        case -4:
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Invalid servername %s from %s",
-                                    name, get_server_name(client_p, HIDE_IP));
+                                    name, "[@255.255.255.255]");
                ilog(L_SERVER, "Access denied, invalid servername from %s",
                     log_client_name(client_p, SHOW_IP));
 
@@ -184,6 +185,37 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
                return 0;
        }
 
+       /* require TS6 for direct links */
+       if(!IsCapable(client_p, CAP_TS6))
+       {
+               sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
+                                       "Link %s dropped, TS6 protocol is required", name);
+               exit_client(client_p, client_p, client_p, "Incompatible TS version");
+               return 0;
+       }
+
+       /* check to ensure any "required" caps are set. --nenolod */
+       required_mask = capability_index_get_required(serv_capindex);
+       if (!IsCapable(client_p, required_mask))
+       {
+               missing = capability_index_list(serv_capindex, required_mask &
+                               ~client_p->localClient->caps);
+               sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
+                                       "Link %s dropped, required CAPABs [%s] are missing",
+                                       name, missing);
+               ilog(L_SERVER, "Link %s%s dropped, required CAPABs [%s] are missing",
+                               EmptyString(client_p->name) ? name : "",
+                               log_client_name(client_p, SHOW_IP), missing);
+               /* Do not use '[' in the below message because it would cause
+                * it to be considered potentially unsafe (might disclose IP
+                * addresses)
+                */
+               sendto_one(client_p, "ERROR :Missing required CAPABs (%s)", missing);
+               exit_client(client_p, client_p, client_p, "Missing required CAPABs");
+
+               return 0;
+       }
+
        if((target_p = find_server(NULL, name)))
        {
                /*
@@ -197,13 +229,24 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
                 * Definitely don't do that here. This is from an unregistered
                 * connect - A1kmm.
                 */
-               sendto_realops_snomask(SNO_GENERAL, L_ALL,
-                                    "Attempt to re-introduce server %s from %s",
-                                    name, get_server_name(client_p, HIDE_IP));
-               ilog(L_SERVER, "Attempt to re-introduce server %s from %s",
-                               name, log_client_name(client_p, SHOW_IP));
+               if (target_p->servptr->flags & FLAGS_SERVICE)
+               {
+                       /* Assume any servers introduced by services
+                        * are jupes.
+                        * -- jilles
+                        */
+                       sendto_one(client_p, "ERROR :Server juped.");
+               }
+               else
+               {
+                       sendto_realops_snomask(SNO_GENERAL, L_ALL,
+                                            "Attempt to re-introduce server %s from %s",
+                                            name, "[@255.255.255.255]");
+                       ilog(L_SERVER, "Attempt to re-introduce server %s from %s",
+                                       name, log_client_name(client_p, SHOW_IP));
 
-               sendto_one(client_p, "ERROR :Server already exists.");
+                       sendto_one(client_p, "ERROR :Server already exists.");
+               }
                exit_client(client_p, client_p, client_p, "Server Exists");
                return 0;
        }
@@ -211,14 +254,15 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
        if(has_id(client_p) && (target_p = find_id(client_p->id)) != NULL)
        {
                sendto_realops_snomask(SNO_GENERAL, is_remote_connect(client_p) ? L_NETWIDE : L_ALL,
-                                    "Attempt to re-introduce SID %s from %s%s",
+                                    "Attempt to re-introduce SID %s from %s%s (already in use by %s)",
                                     client_p->id,
                                     EmptyString(client_p->name) ? name : "",
-                                    get_server_name(client_p, HIDE_IP));
-               ilog(L_SERVER, "Attempt to re-introduce SID %s from %s%s",
+                                    client_p->name, target_p->name);
+               ilog(L_SERVER, "Attempt to re-introduce SID %s from %s%s (already in use by %s)",
                                client_p->id,
                                EmptyString(client_p->name) ? name : "",
-                               log_client_name(client_p, SHOW_IP));
+                               log_client_name(client_p, SHOW_IP),
+                               target_p->name);
 
                sendto_one(client_p, "ERROR :SID already exists.");
                exit_client(client_p, client_p, client_p, "SID Exists");
@@ -240,7 +284,6 @@ mr_server(struct Client *client_p, struct Client *source_p, int parc, const char
 
 /*
  * ms_server - SERVER message handler
- *      parv[0] = sender prefix
  *      parv[1] = servername
  *      parv[2] = serverinfo/hopcount
  *      parv[3] = serverinfo
@@ -258,6 +301,7 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
        int hlined = 0;
        int llined = 0;
        rb_dlink_node *ptr;
+       char squitreason[160];
 
        name = parv[1];
        hop = atoi(parv[2]);
@@ -283,21 +327,13 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
                 * doesnt exist, although ircd can handle it, its not a realistic
                 * solution.. --fl_ 
                 */
-               /* It is behind a host-masked server. Completely ignore the
-                * server message(don't propagate or we will delink from whoever
-                * we propagate to). -A1kmm */
-               if(irccmp(target_p->name, name) && target_p->from == client_p)
-                       return 0;
-
-               sendto_one(client_p, "ERROR :Server %s already exists", name);
-
-               sendto_realops_snomask(SNO_GENERAL, L_ALL,
-                                    "Link %s cancelled, server %s already exists",
-                                    get_server_name(client_p, SHOW_IP), name);
                ilog(L_SERVER, "Link %s cancelled, server %s already exists",
                        client_p->name, name);
 
-               exit_client(client_p, client_p, &me, "Server Exists");
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "Server %s already exists",
+                               name);
+               exit_client(client_p, client_p, &me, squitreason);
                return 0;
        }
 
@@ -315,7 +351,7 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
                sendto_one(client_p, "ERROR :Nickname %s already exists!", name);
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Link %s cancelled: Server/nick collision on %s",
-                                    get_server_name(client_p, HIDE_IP), name);
+                                    client_p->name, name);
                ilog(L_SERVER, "Link %s cancelled: Server/nick collision on %s",
                        client_p->name, name);
 
@@ -329,11 +365,6 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
         * add it to list and propagate word to my other
         * server links...
         */
-       if(parc == 1 || EmptyString(info))
-       {
-               sendto_one(client_p, "ERROR :No server info specified for %s", name);
-               return 0;
-       }
 
        /*
         * See if the newly found server is behind a guaranteed
@@ -376,16 +407,19 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
         * .edu's
         */
 
-       /* Ok, check client_p can hub the new server, and make sure it's not a LL */
+       /* Ok, check client_p can hub the new server */
        if(!hlined)
        {
                /* OOOPs nope can't HUB */
                sendto_realops_snomask(SNO_GENERAL, L_ALL, "Non-Hub link %s introduced %s.",
-                                    get_server_name(client_p, HIDE_IP), name);
+                                    client_p->name, name);
                ilog(L_SERVER, "Non-Hub link %s introduced %s.",
                        client_p->name, name);
 
-               exit_client(NULL, client_p, &me, "No matching hub_mask.");
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "No matching hub_mask for %s",
+                               name);
+               exit_client(NULL, client_p, &me, squitreason);
                return 0;
        }
 
@@ -395,11 +429,14 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
                /* OOOPs nope can't HUB this leaf */
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Link %s introduced leafed server %s.",
-                                    get_server_name(client_p, HIDE_IP), name);
+                                    client_p->name, name);
                ilog(L_SERVER, "Link %s introduced leafed server %s.",
                        client_p->name, name);  
 
-               exit_client(NULL, client_p, &me, "Leafed Server.");
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "Matching leaf_mask for %s",
+                               name);
+               exit_client(NULL, client_p, &me, squitreason);
                return 0;
        }
 
@@ -409,7 +446,7 @@ ms_server(struct Client *client_p, struct Client *source_p, int parc, const char
        {
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Link %s introduced server with invalid servername %s",
-                                    get_server_name(client_p, HIDE_IP), name);
+                                    client_p->name, name);
                ilog(L_SERVER, "Link %s introduced server with invalid servername %s",
                        client_p->name, name);
 
@@ -461,37 +498,39 @@ ms_sid(struct Client *client_p, struct Client *source_p, int parc, const char *p
        struct remote_conf *hub_p;
        hook_data_client hdata;
        rb_dlink_node *ptr;
-       int hop;
        int hlined = 0;
        int llined = 0;
-
-       hop = atoi(parv[2]);
+       char squitreason[160];
 
        /* collision on the name? */
        if((target_p = find_server(NULL, parv[1])) != NULL)
        {
-               sendto_one(client_p, "ERROR :Server %s already exists", parv[1]);
-               sendto_realops_snomask(SNO_GENERAL, L_ALL,
-                                    "Link %s cancelled, server %s already exists",
-                                    get_server_name(client_p, SHOW_IP), parv[1]);
                ilog(L_SERVER, "Link %s cancelled, server %s already exists",
                        client_p->name, parv[1]);
 
-               exit_client(NULL, client_p, &me, "Server Exists");
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "Server %s already exists",
+                               parv[1]);
+               exit_client(NULL, client_p, &me, squitreason);
                return 0;
        }
 
        /* collision on the SID? */
        if((target_p = find_id(parv[3])) != NULL)
        {
-               sendto_one(client_p, "ERROR :SID %s already exists", parv[3]);
-               sendto_realops_snomask(SNO_GENERAL, L_ALL,
-                                    "Link %s cancelled, SID %s already exists",
-                                    get_server_name(client_p, SHOW_IP), parv[3]);
-               ilog(L_SERVER, "Link %s cancelled, SID %s already exists",
-                       client_p->name, parv[3]);
-
-               exit_client(NULL, client_p, &me, "SID Exists");
+               sendto_wallops_flags(UMODE_WALLOP, &me,
+                                    "Link %s cancelled, SID %s for server %s already in use by %s",
+                                    client_p->name, parv[3], parv[1], target_p->name);
+               sendto_server(NULL, NULL, CAP_TS6, NOCAPS,
+                                    ":%s WALLOPS :Link %s cancelled, SID %s for server %s already in use by %s",
+                                    me.id, client_p->name, parv[3], parv[1], target_p->name);
+               ilog(L_SERVER, "Link %s cancelled, SID %s for server %s already in use by %s",
+                       client_p->name, parv[3], parv[1], target_p->name);
+
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "SID %s for %s already in use by %s",
+                               parv[3], parv[1], target_p->name);
+               exit_client(NULL, client_p, &me, squitreason);
                return 0;
        }
 
@@ -500,7 +539,7 @@ ms_sid(struct Client *client_p, struct Client *source_p, int parc, const char *p
                sendto_one(client_p, "ERROR :Invalid servername");
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Link %s cancelled, servername %s invalid",
-                                    get_server_name(client_p, SHOW_IP), parv[1]);
+                                    client_p->name, parv[1]);
                ilog(L_SERVER, "Link %s cancelled, servername %s invalid",
                        client_p->name, parv[1]);
 
@@ -514,7 +553,7 @@ ms_sid(struct Client *client_p, struct Client *source_p, int parc, const char *p
                sendto_one(client_p, "ERROR :Invalid SID");
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Link %s cancelled, SID %s invalid",
-                                    get_server_name(client_p, SHOW_IP), parv[3]);
+                                    client_p->name, parv[3]);
                ilog(L_SERVER, "Link %s cancelled, SID %s invalid",
                        client_p->name, parv[3]);
 
@@ -542,26 +581,32 @@ ms_sid(struct Client *client_p, struct Client *source_p, int parc, const char *p
        /* no matching hub_mask */
        if(!hlined)
        {
-               sendto_one(client_p, "ERROR :No matching hub_mask");
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Non-Hub link %s introduced %s.",
-                                    get_server_name(client_p, SHOW_IP), parv[1]);
+                                    client_p->name, parv[1]);
                ilog(L_SERVER, "Non-Hub link %s introduced %s.",
                        client_p->name, parv[1]);
-               exit_client(NULL, client_p, &me, "No matching hub_mask.");
+
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "No matching hub_mask for %s",
+                               parv[1]);
+               exit_client(NULL, client_p, &me, squitreason);
                return 0;
        }
 
        /* matching leaf_mask */
        if(llined)
        {
-               sendto_one(client_p, "ERROR :Matching leaf_mask");
                sendto_realops_snomask(SNO_GENERAL, L_ALL,
                                     "Link %s introduced leafed server %s.",
-                                    get_server_name(client_p, SHOW_IP), parv[1]);
+                                    client_p->name, parv[1]);
                ilog(L_SERVER, "Link %s introduced leafed server %s.",
                        client_p->name, parv[1]);       
-               exit_client(NULL, client_p, &me, "Leafed Server.");
+
+               rb_snprintf(squitreason, sizeof squitreason,
+                               "Matching leaf_mask for %s",
+                               parv[1]);
+               exit_client(NULL, client_p, &me, squitreason);
                return 0;
        }
 
@@ -589,10 +634,6 @@ ms_sid(struct Client *client_p, struct Client *source_p, int parc, const char *p
                      ":%s SID %s %d %s :%s%s",
                      source_p->id, target_p->name, target_p->hopcount + 1,
                      target_p->id, IsHidden(target_p) ? "(H) " : "", target_p->info);
-       sendto_server(client_p, NULL, NOCAPS, CAP_TS6,
-                     ":%s SERVER %s %d :%s%s",
-                     source_p->name, target_p->name, target_p->hopcount + 1,
-                     IsHidden(target_p) ? "(H) " : "", target_p->info);
 
        sendto_realops_snomask(SNO_EXTERNAL, L_ALL,
                             "Server %s being introduced by %s", target_p->name, source_p->name);
@@ -622,7 +663,6 @@ set_server_gecos(struct Client *client_p, const char *info)
        {
                char *p;
                char *s;
-               char *t;
 
                s = LOCAL_COPY(info);
 
@@ -631,7 +671,7 @@ set_server_gecos(struct Client *client_p, const char *info)
                        *p = '\0';
 
                /* check for a ] which would symbolise an [IP] */
-               if((t = strchr(s, ']')))
+               if(strchr(s, ']'))
                {
                        /* set s to after the first space */
                        if(p)