#include "logger.h"
#include "rb_radixtree.h"
+static const char list_desc[] = "Provides the LIST command to clients to view non-hidden channels";
+
static rb_dlink_list safelisting_clients = { NULL, NULL, 0 };
+static struct ev_entry *iterate_clients_ev = NULL;
+
static int _modinit(void);
static void _moddeinit(void);
-static int m_list(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
-static int mo_list(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void m_list(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void mo_list(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
static void list_one_channel(struct Client *source_p, struct Channel *chptr, int visible);
{NULL, NULL}
};
-DECLARE_MODULE_AV2(list, _modinit, _moddeinit, list_clist, NULL, list_hfnlist, NULL, NULL, NULL);
-
-static struct ev_entry *iterate_clients_ev = NULL;
+DECLARE_MODULE_AV2(list, _modinit, _moddeinit, list_clist, NULL, list_hfnlist, NULL, NULL, list_desc);
static int _modinit(void)
{
* XXX - With SAFELIST, do we really need to continue pacing?
* In theory, the server cannot be lagged by this. --nenolod
*/
-static int m_list(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
+static void
+m_list(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
{
static time_t last_used = 0L;
{
sendto_one_notice(source_p, ":/LIST aborted");
safelist_client_release(source_p);
- return 0;
+ return;
}
if (parc < 2 || !IsChannelName(parv[1]))
{
sendto_one(source_p, form_str(RPL_LOAD2HI), me.name, source_p->name, "LIST");
sendto_one(source_p, form_str(RPL_LISTEND), me.name, source_p->name);
- return 0;
+ return;
}
else
last_used = rb_current_time();
}
- return mo_list(msgbuf_p, client_p, source_p, parc, parv);
+ mo_list(msgbuf_p, client_p, source_p, parc, parv);
}
/* mo_list()
* parv[1] = channel
*/
-static int mo_list(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
+static void
+mo_list(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
{
struct ListClient *params;
char *p;
{
sendto_one_notice(source_p, ":/LIST aborted");
safelist_client_release(source_p);
- return 0;
+ return;
}
if (parc > 1)
if (args && IsChannelName(args))
{
safelist_channel_named(source_p, args, operspy);
- return 0;
+ return;
}
/* Multiple channels, possibly with parameters. */
}
safelist_client_instantiate(source_p, params);
-
- return 0;
}
/*
* safelist_sendq_exceeded()
*
* inputs - pointer to client that needs checking
- * outputs - 1 if a client has exceeded the reserved
- * sendq limit, 0 if not
+ * outputs - true if a client has exceeded the reserved
+ * sendq limit, false if not
* side effects - none
*
* When safelisting, we only use half of the SendQ at any
* given time.
*/
-static int safelist_sendq_exceeded(struct Client *client_p)
+static bool safelist_sendq_exceeded(struct Client *client_p)
{
- if (rb_linebuf_len(&client_p->localClient->buf_sendq) > (get_sendq(client_p) / 2))
- return YES;
- else
- return NO;
+ return rb_linebuf_len(&client_p->localClient->buf_sendq) > (get_sendq(client_p) / 2);
}
/*
* outputs - none
* side effects - the client is no longer being
* listed
- *
- * Please do not ever call this on a non-local client.
- * If you do, you will get SIGSEGV.
*/
static void safelist_client_release(struct Client *client_p)
{
+ if(!MyClient(client_p))
+ return;
+
s_assert(MyClient(client_p));
rb_dlinkFindDestroy(client_p, &safelisting_clients);
RB_RADIXTREE_FOREACH_FROM(chptr, &iter, channel_tree, source_p->localClient->safelist_data->chname)
{
- if (safelist_sendq_exceeded(source_p->from) == YES)
+ if (safelist_sendq_exceeded(source_p->from))
{
rb_free(source_p->localClient->safelist_data->chname);
source_p->localClient->safelist_data->chname = rb_strdup(chptr->chname);