]> jfr.im git - irc/weechat/weechat.git/log
irc/weechat/weechat.git
11 months agoVersion 4.0.1 v4.0.1
Sébastien Helleu [Fri, 30 Jun 2023 19:18:01 +0000 (21:18 +0200)] 
Version 4.0.1

11 months agoguile: fix crash on quit with Guile < 3 (closes #1965)
Sébastien Helleu [Tue, 27 Jun 2023 19:44:54 +0000 (21:44 +0200)] 
guile: fix crash on quit with Guile < 3 (closes #1965)

11 months agocore: update ChangeLog
Sébastien Helleu [Tue, 27 Jun 2023 19:28:46 +0000 (21:28 +0200)] 
core: update ChangeLog

11 months agocore: check for newline characters in string_is_whitespace_char
Trygve Aaberge [Mon, 26 Jun 2023 21:52:23 +0000 (23:52 +0200)] 
core: check for newline characters in string_is_whitespace_char

This fixes a bug where if you had multiple lines in the input and
pressed ctrl-w when the cursor was after the first word of any line but
the first, it would delete both the word before the cursor and the last
word on the preceding line.

11 months agoapi: do not convert option name to lower case in API functions config_set_plugin...
Sébastien Helleu [Tue, 27 Jun 2023 10:56:42 +0000 (12:56 +0200)] 
api: do not convert option name to lower case in API functions config_set_plugin and config_set_desc_plugin

11 months agoirc: sent "QUIT" message to servers connected with TLS on `/upgrade`
Sébastien Helleu [Mon, 26 Jun 2023 20:06:46 +0000 (22:06 +0200)] 
irc: sent "QUIT" message to servers connected with TLS on `/upgrade`

11 months agocore: fix level of section title in release notes
Sébastien Helleu [Mon, 26 Jun 2023 19:22:28 +0000 (21:22 +0200)] 
core: fix level of section title in release notes

11 months agocore: display actual key name and command with key Alt+k
Sébastien Helleu [Mon, 26 Jun 2023 17:30:42 +0000 (19:30 +0200)] 
core: display actual key name and command with key Alt+k

Key Alt+K (upper K) is removed as well as commands `/input grab_raw_key` and
`/input grab_raw_key_command`.

11 months agoirc: reply to a CTCP request sent to self nick (closes #1966)
Sébastien Helleu [Sun, 25 Jun 2023 20:05:03 +0000 (22:05 +0200)] 
irc: reply to a CTCP request sent to self nick (closes #1966)

11 months agocore: add missing space in French translation
Sébastien Helleu [Sun, 25 Jun 2023 17:14:48 +0000 (19:14 +0200)] 
core: add missing space in French translation

11 months agocore: force key "return" to command "/input return" when migrating legacy keys
Sébastien Helleu [Sun, 25 Jun 2023 17:14:15 +0000 (19:14 +0200)] 
core: force key "return" to command "/input return" when migrating legacy keys

11 months agocore: fix format in Czech translation
Sébastien Helleu [Sat, 24 Jun 2023 22:48:21 +0000 (00:48 +0200)] 
core: fix format in Czech translation

11 months agocore: add option weechat.color.status_name_insecure in ChangeLog and release notes
Sébastien Helleu [Sun, 25 Jun 2023 13:17:16 +0000 (15:17 +0200)] 
core: add option weechat.color.status_name_insecure in ChangeLog and release notes

11 months agoVersion 4.0.1-dev
Sébastien Helleu [Sun, 25 Jun 2023 13:12:34 +0000 (15:12 +0200)] 
Version 4.0.1-dev

11 months agoVersion 4.0.0 v4.0.0
Sébastien Helleu [Sat, 24 Jun 2023 20:00:30 +0000 (22:00 +0200)] 
Version 4.0.0

11 months agodoc/user: fix typo in French translation
Sébastien Helleu [Fri, 23 Jun 2023 10:01:56 +0000 (12:01 +0200)] 
doc/user: fix typo in French translation

11 months agocore: update German translations
Nils Görs [Fri, 23 Jun 2023 05:43:45 +0000 (07:43 +0200)] 
core: update German translations

11 months agocore: update ChangeLog
Sébastien Helleu [Mon, 19 Jun 2023 05:30:31 +0000 (07:30 +0200)] 
core: update ChangeLog

11 months agocore: ignore rest of config file if config version is invalid or not supported
Sébastien Helleu [Sat, 17 Jun 2023 11:13:11 +0000 (13:13 +0200)] 
core: ignore rest of config file if config version is invalid or not supported

11 months agocore: update German translations
Nils Görs [Fri, 16 Jun 2023 12:31:16 +0000 (14:31 +0200)] 
core: update German translations

11 months agoexec: fix URL to plugin API reference in /help exec
Sébastien Helleu [Thu, 15 Jun 2023 20:07:34 +0000 (22:07 +0200)] 
exec: fix URL to plugin API reference in /help exec

11 months agodoc/user: fix URL to plugin API reference
Sébastien Helleu [Thu, 15 Jun 2023 20:04:45 +0000 (22:04 +0200)] 
doc/user: fix URL to plugin API reference

11 months agorelay: add IPv6 example in /help relay.network.bind_address
Sébastien Helleu [Thu, 15 Jun 2023 20:04:16 +0000 (22:04 +0200)] 
relay: add IPv6 example in /help relay.network.bind_address

11 months agocore: replace Debian Bullseye by Bookworm in Debian build script
Sébastien Helleu [Mon, 12 Jun 2023 19:26:21 +0000 (21:26 +0200)] 
core: replace Debian Bullseye by Bookworm in Debian build script

11 months agodoc/user: update dependencies versions to Debian Bookworm
Sébastien Helleu [Mon, 12 Jun 2023 19:26:00 +0000 (21:26 +0200)] 
doc/user: update dependencies versions to Debian Bookworm

11 months agodoc/user: fix description of key ctrl+q in search context
Sébastien Helleu [Mon, 12 Jun 2023 16:38:21 +0000 (18:38 +0200)] 
doc/user: fix description of key ctrl+q in search context

11 months agocore: update German translations
Nils Görs [Sun, 11 Jun 2023 15:54:43 +0000 (17:54 +0200)] 
core: update German translations

11 months agorelay: fix crash on `/upgrade` when at least a client is connected with weechat protocol
Sébastien Helleu [Sun, 11 Jun 2023 12:33:32 +0000 (14:33 +0200)] 
relay: fix crash on `/upgrade` when at least a client is connected with weechat protocol

11 months agocore: add completions "filters_names_disabled" and "filters_names_enabled"
Sébastien Helleu [Sat, 10 Jun 2023 20:38:54 +0000 (22:38 +0200)] 
core: add completions "filters_names_disabled" and "filters_names_enabled"

They are used in completion of commands `/filter disable` and
`/filter enable`.

11 months agotrigger: add completions "trigger_names_disabled" and "trigger_names_enabled"
Sébastien Helleu [Sat, 10 Jun 2023 18:30:52 +0000 (20:30 +0200)] 
trigger: add completions "trigger_names_disabled" and "trigger_names_enabled"

They are used in completion of commands `/trigger disable` and
`/trigger enable`.

11 months agocore: update instructions in cygport file
Sébastien Helleu [Sat, 10 Jun 2023 16:16:24 +0000 (18:16 +0200)] 
core: update instructions in cygport file

11 months agoexec: remove trailing "M" (carriage return) in output of commands
Sébastien Helleu [Sat, 10 Jun 2023 07:49:11 +0000 (09:49 +0200)] 
exec: remove trailing "M" (carriage return) in output of commands

Regression was indirectly caused by commit
d18f68e497c4244404ff8f4f50de82717b178e09 in core that allows to display all
control chars in buffers.

But the fix is in exec plugin: end of line in command output can now be "\r\n"
in addition to a single "\n".

11 months agocore: add new IRC capabilities in release notes
Sébastien Helleu [Wed, 7 Jun 2023 16:23:42 +0000 (18:23 +0200)] 
core: add new IRC capabilities in release notes

11 months agodoc: increase sectnumlevels to 2 (user/scripting/quickstart/relay/dev)
Sébastien Helleu [Tue, 6 Jun 2023 17:13:20 +0000 (19:13 +0200)] 
doc: increase sectnumlevels to 2 (user/scripting/quickstart/relay/dev)

11 months agoguile: fix crash when plugin is loaded on GNU/Hurd (closes #1951)
Sébastien Helleu [Mon, 5 Jun 2023 19:09:27 +0000 (21:09 +0200)] 
guile: fix crash when plugin is loaded on GNU/Hurd (closes #1951)

11 months agodebian: update changelog
Sébastien Helleu [Mon, 5 Jun 2023 17:09:25 +0000 (19:09 +0200)] 
debian: update changelog

11 months agodoc: fix URLs to WeeChat docs
Sébastien Helleu [Mon, 5 Jun 2023 17:08:12 +0000 (19:08 +0200)] 
doc: fix URLs to WeeChat docs

11 months agotests: fix checks on integers in relay irc protocol tests
Sébastien Helleu [Mon, 5 Jun 2023 17:04:05 +0000 (19:04 +0200)] 
tests: fix checks on integers in relay irc protocol tests

11 months agotests: add missing include of string.h in logger tests
Sébastien Helleu [Mon, 5 Jun 2023 17:02:57 +0000 (19:02 +0200)] 
tests: add missing include of string.h in logger tests

11 months agodoc/relay: add option "escape_commands" in handshake response and examples
Sébastien Helleu [Mon, 5 Jun 2023 17:01:46 +0000 (19:01 +0200)] 
doc/relay: add option "escape_commands" in handshake response and examples

11 months agoVersion 4.0.0-rc1 v4.0.0-rc1
Sébastien Helleu [Mon, 5 Jun 2023 06:18:10 +0000 (08:18 +0200)] 
Version 4.0.0-rc1

11 months agologger: fix display of multiline messages in backlog (closes #1926)
Sébastien Helleu [Sun, 4 Jun 2023 23:07:16 +0000 (01:07 +0200)] 
logger: fix display of multiline messages in backlog (closes #1926)

11 months agotests: add tests on logger tail functions (issue #1926)
Sébastien Helleu [Sun, 4 Jun 2023 19:14:20 +0000 (21:14 +0200)] 
tests: add tests on logger tail functions (issue #1926)

11 months agologger: return arraylist instead of custom linked list in logger_tail_file (issue...
Sébastien Helleu [Sun, 4 Jun 2023 19:12:51 +0000 (21:12 +0200)] 
logger: return arraylist instead of custom linked list in logger_tail_file (issue #1926)

11 months agodoc: update German documentation
Nils Görs [Sun, 4 Jun 2023 09:17:53 +0000 (11:17 +0200)] 
doc: update German documentation

11 months agocore: update German translations
Nils Görs [Sun, 4 Jun 2023 09:12:59 +0000 (11:12 +0200)] 
core: update German translations

11 months agoirc: add tag "new_host_xxx" in message displayed for command CHGHOST (closes #1808)
Sébastien Helleu [Sun, 4 Jun 2023 07:45:47 +0000 (09:45 +0200)] 
irc: add tag "new_host_xxx" in message displayed for command CHGHOST (closes #1808)

12 months agocore: update ChangeLog (issue #1950)
Sébastien Helleu [Sat, 3 Jun 2023 19:40:29 +0000 (21:40 +0200)] 
core: update ChangeLog (issue #1950)

12 months agodoc/user: add new FIFO syntax (issue #1950)
Sébastien Helleu [Sat, 3 Jun 2023 19:38:15 +0000 (21:38 +0200)] 
doc/user: add new FIFO syntax (issue #1950)

12 months agofifo: allow using escape characters
Trygve Aaberge [Sat, 3 Jun 2023 13:20:05 +0000 (15:20 +0200)] 
fifo: allow using escape characters

This allows you to use escape characters if you start the fifo command
with \ instead of *, in the same way as the escape_commands option in
the relay protocol. This allows you to send commands consisting of
multiple lines by using \n if the buffer has input_multiline set.

12 months agoirc: add option irc.look.display_host_notice
Sébastien Helleu [Sat, 3 Jun 2023 19:15:58 +0000 (21:15 +0200)] 
irc: add option irc.look.display_host_notice

12 months agorelay: add handshake option "escape_commands" in weechat protocol
Sébastien Helleu [Sat, 3 Jun 2023 15:32:44 +0000 (17:32 +0200)] 
relay: add handshake option "escape_commands" in weechat protocol

12 months agocore: update German translations
Nils Görs [Sat, 3 Jun 2023 17:36:58 +0000 (19:36 +0200)] 
core: update German translations

12 months agocore: specify irc protocol for relay changes
Sébastien Helleu [Sat, 3 Jun 2023 15:28:15 +0000 (17:28 +0200)] 
core: specify irc protocol for relay changes

12 months agodoc: fix formatting issues with links that target a blank window
Sébastien Helleu [Sat, 3 Jun 2023 15:08:17 +0000 (17:08 +0200)] 
doc: fix formatting issues with links that target a blank window

12 months agorelay: add support of capability "echo-message" (closes #1949)
Sébastien Helleu [Sat, 3 Jun 2023 12:14:39 +0000 (14:14 +0200)] 
relay: add support of capability "echo-message" (closes #1949)

12 months agoirc: add infos "irc_server_cap" and "irc_server_cap_value" (issue #1949)
Sébastien Helleu [Sat, 3 Jun 2023 08:01:27 +0000 (10:01 +0200)] 
irc: add infos "irc_server_cap" and "irc_server_cap_value" (issue #1949)

12 months agotests: add tests on relay "irc" protocol
Sébastien Helleu [Fri, 2 Jun 2023 16:44:39 +0000 (18:44 +0200)] 
tests: add tests on relay "irc" protocol

12 months agoirc: add missing "user" in documentation of functions
Sébastien Helleu [Fri, 2 Jun 2023 16:38:01 +0000 (18:38 +0200)] 
irc: add missing "user" in documentation of functions

12 months agorelay: fix connection with IRC clients sending "CAP REQ :" (without capability) and...
Sébastien Helleu [Thu, 1 Jun 2023 20:05:42 +0000 (22:05 +0200)] 
relay: fix connection with IRC clients sending "CAP REQ :" (without capability) and not sending "CAP END" (issue #1040, issue #1796)

The bug was fixed in version 2.0 (issue #1040) but a regression in version 3.7
happened while using the new IRC parser for message arguments (issue #1796,
commit 96ed47126130ac62350aef4a9236009b7fc3cd5f).

12 months agorelay: add modifiers "relay_client_irc_in", "relay_client_irc_out1" and "relay_client...
Sébastien Helleu [Thu, 1 Jun 2023 19:39:29 +0000 (21:39 +0200)] 
relay: add modifiers "relay_client_irc_in", "relay_client_irc_out1" and "relay_client_irc_out"

12 months agocore: fix weechat.look.align_multiline_words not working
Trygve Aaberge [Tue, 30 May 2023 19:08:43 +0000 (21:08 +0200)] 
core: fix weechat.look.align_multiline_words not working

This option was broken with commit 031bd45e3.

12 months agotests: create and close server buffer in tests on function irc_join_split
Sébastien Helleu [Wed, 31 May 2023 21:39:19 +0000 (23:39 +0200)] 
tests: create and close server buffer in tests on function irc_join_split

12 months agotests: fix close of channel buffers after tests on function irc_join_split
Sébastien Helleu [Wed, 31 May 2023 21:00:34 +0000 (23:00 +0200)] 
tests: fix close of channel buffers after tests on function irc_join_split

12 months agoruby: fix crash in display of exception backtrace with Ruby 3 (issue #1631, issue...
Sébastien Helleu [Wed, 31 May 2023 18:56:14 +0000 (20:56 +0200)] 
ruby: fix crash in display of exception backtrace with Ruby 3 (issue #1631, issue #1886)

12 months agocore: update German translations
Nils Görs [Wed, 31 May 2023 05:18:00 +0000 (07:18 +0200)] 
core: update German translations

12 months agodoc: update Serbian documentation
Ivan Pešić [Tue, 30 May 2023 11:31:30 +0000 (15:31 +0400)] 
doc: update Serbian documentation

12 months agocore: update Serbian messages translation
Ivan Pešić [Tue, 30 May 2023 11:30:26 +0000 (15:30 +0400)] 
core: update Serbian messages translation

12 months agocore: send all command line parameters not beginning with a dash to all plugins,...
Sébastien Helleu [Tue, 30 May 2023 18:53:42 +0000 (20:53 +0200)] 
core: send all command line parameters not beginning with a dash to all plugins, add info "auto_load_scripts"

This fixes an issue with IRC URL given on command line when it starts with
`ircs://` or `irc6://`: the server is not created at all (only `irc://` works
fine).

12 months agofset: reset color immediately after the color name (issue #1920)
Sébastien Helleu [Tue, 30 May 2023 05:39:11 +0000 (07:39 +0200)] 
fset: reset color immediately after the color name (issue #1920)

12 months agocore: update ChangeLog (issue #1920)
Sébastien Helleu [Tue, 30 May 2023 05:37:18 +0000 (07:37 +0200)] 
core: update ChangeLog (issue #1920)

12 months agodoc: update German documentation
Nils Görs [Mon, 29 May 2023 15:39:29 +0000 (17:39 +0200)] 
doc: update German documentation

12 months agocore: set word_end_offset to character after word
Trygve Aaberge [Sun, 28 May 2023 12:56:56 +0000 (14:56 +0200)] 
core: set word_end_offset to character after word

It seemed strange to me to have word_end_offset point to the last
character in the word, rather than the character after the word,
especially now with the word stopping before a newline character which
meant word_end_offset would be -1 if there was no characters before the
newline character.

12 months agocore: fix chat colors at certain positions not being applied
Trygve Aaberge [Sun, 28 May 2023 12:34:38 +0000 (14:34 +0200)] 
core: fix chat colors at certain positions not being applied

The new rendering of multiline lines had some issues with colors at
certain positions not being applied. The color would not be applied if
the color code was at either of these positions:

  - At the start of a line after a newline character
  - At the end of a line after a space and before a newline character
  - At a line by itself before a newline character

The way I had done it by considering newline characters as a word in
gui_chat_get_word_info with a variable specifying that it's newline
characters became messy and didn't really make sense, so rather than
doing this, I changed gui_chat_get_word_info to stop before the first
newline character. That way, we can just check if we are at a newline
character at the start of the loop, and don't need any more special
handling.

Fixes #1928

12 months agotests: add tests on manual CTCP ACTION sent to IRC channel
Sébastien Helleu [Mon, 29 May 2023 09:13:49 +0000 (11:13 +0200)] 
tests: add tests on manual CTCP ACTION sent to IRC channel

12 months agoirc: fix display of CTCP ACTION sent without parameters nor space
Sébastien Helleu [Mon, 29 May 2023 09:10:25 +0000 (11:10 +0200)] 
irc: fix display of CTCP ACTION sent without parameters nor space

12 months agoirc: remove unneeded extra check on "\01ACTION " in irc_input_user_message_display
Sébastien Helleu [Mon, 29 May 2023 09:04:50 +0000 (11:04 +0200)] 
irc: remove unneeded extra check on "\01ACTION " in irc_input_user_message_display

12 months agoirc: hide password in messages to nickserv with cap echo-message enabled (issue ...
Sébastien Helleu [Mon, 29 May 2023 07:49:41 +0000 (09:49 +0200)] 
irc: hide password in messages to nickserv with cap echo-message enabled (issue #139)

12 months agoirc: add command `/action` (closes #201, issue #1577), remove alias `action`
Sébastien Helleu [Mon, 29 May 2023 07:44:13 +0000 (09:44 +0200)] 
irc: add command `/action` (closes #201, issue #1577), remove alias `action`

12 months agoalias: add option `missing` in command `/alias`
Sébastien Helleu [Sat, 27 May 2023 18:20:31 +0000 (20:20 +0200)] 
alias: add option `missing` in command `/alias`

12 months agoalias: add alias `action` to send a CTCP ACTION to a channel or a nick (issue #1577)
Sébastien Helleu [Sat, 27 May 2023 18:07:37 +0000 (20:07 +0200)] 
alias: add alias `action` to send a CTCP ACTION to a channel or a nick (issue #1577)

12 months agoirc: add missing host tag in self messages with cap echo-message enabled (issue ...
Sébastien Helleu [Sat, 27 May 2023 13:56:07 +0000 (15:56 +0200)] 
irc: add missing host tag in self messages with cap echo-message enabled (issue #139)

12 months agoirc: fix display of STATUSMSG CTCP ACTION to channel with cap echo-message enabled...
Sébastien Helleu [Sat, 27 May 2023 13:45:17 +0000 (15:45 +0200)] 
irc: fix display of STATUSMSG CTCP ACTION to channel with cap echo-message enabled (issue #139, issue #1577)

12 months agoirc: fix display of outgoing CTCP when channel/private buffer doesn't exist
Sébastien Helleu [Sat, 27 May 2023 11:59:23 +0000 (13:59 +0200)] 
irc: fix display of outgoing CTCP when channel/private buffer doesn't exist

12 months agoirc: fix display of outgoing STATUSMSG CTCP ACTION without arguments
Sébastien Helleu [Sat, 27 May 2023 09:57:17 +0000 (11:57 +0200)] 
irc: fix display of outgoing STATUSMSG CTCP ACTION without arguments

12 months agoirc: remove extra space in CTCP ACTION message sent without arguments
Sébastien Helleu [Sat, 27 May 2023 09:53:12 +0000 (11:53 +0200)] 
irc: remove extra space in CTCP ACTION message sent without arguments

Now when doing `/me` (without arguments), the message sent is:

  PRIVMSG #test :\x01ACTION\x01

instead of:

  PRIVMSG #test :\x01ACTION \x01

12 months agoirc: fix split of CTCP message with no arguments
Sébastien Helleu [Sat, 27 May 2023 09:52:57 +0000 (11:52 +0200)] 
irc: fix split of CTCP message with no arguments

12 months agoirc: display STATUSMSG actions differently from standard actions on channels (closes...
Sébastien Helleu [Sat, 27 May 2023 07:32:52 +0000 (09:32 +0200)] 
irc: display STATUSMSG actions differently from standard actions on channels (closes #1577, issue #139)

12 months agoirc: fix send of empty action with `/me` command
Sébastien Helleu [Sat, 27 May 2023 08:03:50 +0000 (10:03 +0200)] 
irc: fix send of empty action with `/me` command

12 months agocore: remove WeeChat website from SRC_URI in cygport file
Sébastien Helleu [Fri, 26 May 2023 16:03:20 +0000 (18:03 +0200)] 
core: remove WeeChat website from SRC_URI in cygport file

12 months agocore: update ChangeLog
Sébastien Helleu [Fri, 26 May 2023 16:03:08 +0000 (18:03 +0200)] 
core: update ChangeLog

12 months agotests: add tests on IRC message/notice/action/CTCP sent with cap echo-message enabled...
Sébastien Helleu [Fri, 26 May 2023 16:02:50 +0000 (18:02 +0200)] 
tests: add tests on IRC message/notice/action/CTCP sent with cap echo-message enabled (issue #139)

12 months agotests: remove capabilities added after the end of tests
Sébastien Helleu [Fri, 26 May 2023 16:02:01 +0000 (18:02 +0200)] 
tests: remove capabilities added after the end of tests

12 months agotests: add tests on IRC message/notice/action/CTCP sent (issue #139)
Sébastien Helleu [Fri, 26 May 2023 10:44:15 +0000 (12:44 +0200)] 
tests: add tests on IRC message/notice/action/CTCP sent (issue #139)

12 months agoirc: add missing nick tag in self CTCP ACTION displayed (issue #139)
Sébastien Helleu [Fri, 26 May 2023 10:36:01 +0000 (12:36 +0200)] 
irc: add missing nick tag in self CTCP ACTION displayed (issue #139)

12 months agoirc: display CTCP ACTION to channel on the channel buffer (issue #139, closes #207)
Sébastien Helleu [Fri, 26 May 2023 10:31:22 +0000 (12:31 +0200)] 
irc: display CTCP ACTION to channel on the channel buffer (issue #139, closes #207)

12 months agodoc/user: rewrite IRC smart filter chapter, add detail on all filtered messages
Sébastien Helleu [Fri, 26 May 2023 06:53:20 +0000 (08:53 +0200)] 
doc/user: rewrite IRC smart filter chapter, add detail on all filtered messages

12 months agodoc/user: display 3 levels instead of 2 in TOC
Sébastien Helleu [Fri, 26 May 2023 05:13:04 +0000 (07:13 +0200)] 
doc/user: display 3 levels instead of 2 in TOC

12 months agocore: update German translations
Nils Görs [Thu, 25 May 2023 20:58:59 +0000 (22:58 +0200)] 
core: update German translations

12 months agoirc: display actions sent with `/me` in private buffer instead of server buffer ...
Sébastien Helleu [Thu, 25 May 2023 20:43:54 +0000 (22:43 +0200)] 
irc: display actions sent with `/me` in private buffer instead of server buffer (issue #139)