]> jfr.im git - irc/weechat/weechat.git/commitdiff
api: do not convert option name to lower case in API functions config_set_plugin...
authorSébastien Helleu <redacted>
Tue, 27 Jun 2023 10:56:42 +0000 (12:56 +0200)
committerSébastien Helleu <redacted>
Tue, 27 Jun 2023 10:58:51 +0000 (12:58 +0200)
ChangeLog.adoc
ReleaseNotes.adoc
src/plugins/plugin-config.c

index a0a1f728b8e251bd78cf7668b6a54a5e2c24f84e..a72a5009c0d5c4518214a7ca43442ecbb5d3699a 100644 (file)
@@ -17,6 +17,7 @@ Bug fixes::
 
   * core: force key "return" to command "/input return" when migrating legacy keys
   * core: display actual key name and command with key kbd:[Alt+k], remove key kbd:[Alt+K] (grab raw key) and associated commands `/input grab_raw_key` and `/input grab_raw_key_command`
+  * api: do not convert option name to lower case in API functions config_set_plugin and config_set_desc_plugin
   * irc: reply to a CTCP request sent to self nick (issue #1966)
   * irc: sent "QUIT" message to servers connected with TLS on `/upgrade`
 
index 974644bbd1d048a591109f9639fe1b27facb7e54..52876327b3bafbeb2e2bbc4d8d8eb68a77235fa8 100644 (file)
@@ -14,6 +14,14 @@ For a complete list of changes, please look at ChangeLog.
 [[v4.0.1]]
 == Version 4.0.1 (under dev)
 
+[[v4.0.1_config_set_plugin]]
+=== Functions config_set_plugin and config_set_desc_plugin
+
+The functions link:https://weechat.org/doc/weechat/plugin/#_config_set_plugin[config_set_plugin]
+and link:https://weechat.org/doc/weechat/plugin/#_config_set_desc_plugin[config_set_desc_plugin]
+are not converting any more the option name to lower case because since version 4.0.0,
+the name of options is case sensitive.
+
 [[v4.0.1_grab_raw_key]]
 === Grab raw key and command
 
index 14f7174390e7c9b42056bce3e99a3fc08abf8eef..4e318e3da2ef724dde96bf6e5d67663404cebf43 100644 (file)
@@ -114,7 +114,7 @@ plugin_config_set (const char *plugin_name, const char *option_name,
                    const char *value)
 {
     int length, rc;
-    char *option_full_name, *option_full_name_lower;
+    char *option_full_name;
 
     rc = WEECHAT_CONFIG_OPTION_SET_ERROR;
 
@@ -124,12 +124,7 @@ plugin_config_set (const char *plugin_name, const char *option_name,
     {
         snprintf (option_full_name, length, "%s.%s",
                   plugin_name, option_name);
-        option_full_name_lower = string_tolower (option_full_name);
-        if (option_full_name_lower)
-        {
-            rc = plugin_config_set_internal (option_full_name_lower, value);
-            free (option_full_name_lower);
-        }
+        rc = plugin_config_set_internal (option_full_name, value);
         free (option_full_name);
     }
 
@@ -206,7 +201,7 @@ plugin_config_set_desc (const char *plugin_name, const char *option_name,
                         const char *description)
 {
     int length;
-    char *option_full_name, *option_full_name_lower;
+    char *option_full_name;
 
     length = strlen (plugin_name) + 1 + strlen (option_name) + 1;
     option_full_name = malloc (length);
@@ -214,13 +209,7 @@ plugin_config_set_desc (const char *plugin_name, const char *option_name,
     {
         snprintf (option_full_name, length, "%s.%s",
                   plugin_name, option_name);
-        option_full_name_lower = string_tolower (option_full_name);
-        if (option_full_name_lower)
-        {
-            plugin_config_set_desc_internal (option_full_name_lower,
-                                             description);
-            free (option_full_name_lower);
-        }
+        plugin_config_set_desc_internal (option_full_name, description);
         free (option_full_name);
     }
 }