]> jfr.im git - irc/weechat/weechat.git/commitdiff
tests: Use LONGS_EQUAL for version number tests
authorTrygve Aaberge <redacted>
Sat, 8 Oct 2022 15:42:22 +0000 (17:42 +0200)
committerSébastien Helleu <redacted>
Sat, 8 Oct 2022 16:13:00 +0000 (18:13 +0200)
util_version_number returns an int, but BYTES_EQUAL only compares the
last byte of the int, so it wouldn't test the rest of the int.

I see other tests for functions returning an int use LONGS_EQUAL, so
that seems correct to use.

tests/unit/core/test-core-util.cpp

index 768ad5c48c2d8f0d42e921cb422c6f5dcf67bce8..7db5f0f5b26d2e52ba4d7815bb4a5a17736ce47f 100644 (file)
@@ -229,19 +229,19 @@ TEST(CoreUtil, ParseDelay)
 
 TEST(CoreUtil, VersionNumber)
 {
-    BYTES_EQUAL(0x00030200, util_version_number ("0.3.2-dev"));
-    BYTES_EQUAL(0x00030200, util_version_number ("0.3.2-rc1"));
-    BYTES_EQUAL(0x00030200, util_version_number ("0.3.2"));
-    BYTES_EQUAL(0x00030101, util_version_number ("0.3.1.1"));
-    BYTES_EQUAL(0x00030100, util_version_number ("0.3.1"));
-    BYTES_EQUAL(0x00030000, util_version_number ("0.3.0"));
-    BYTES_EQUAL(0x01000000, util_version_number ("1.0"));
-    BYTES_EQUAL(0x01000000, util_version_number ("1.0.0"));
-    BYTES_EQUAL(0x01000000, util_version_number ("1.0.0.0"));
-    BYTES_EQUAL(0x01000100, util_version_number ("1.0.1"));
-    BYTES_EQUAL(0x01000200, util_version_number ("1.0.2"));
-    BYTES_EQUAL(0x01010000, util_version_number ("1.1"));
-    BYTES_EQUAL(0x01010100, util_version_number ("1.1.1"));
-    BYTES_EQUAL(0x01010200, util_version_number ("1.1.2"));
-    BYTES_EQUAL(0x01020304, util_version_number ("1.2.3.4"));
+    LONGS_EQUAL(0x00030200, util_version_number ("0.3.2-dev"));
+    LONGS_EQUAL(0x00030200, util_version_number ("0.3.2-rc1"));
+    LONGS_EQUAL(0x00030200, util_version_number ("0.3.2"));
+    LONGS_EQUAL(0x00030101, util_version_number ("0.3.1.1"));
+    LONGS_EQUAL(0x00030100, util_version_number ("0.3.1"));
+    LONGS_EQUAL(0x00030000, util_version_number ("0.3.0"));
+    LONGS_EQUAL(0x01000000, util_version_number ("1.0"));
+    LONGS_EQUAL(0x01000000, util_version_number ("1.0.0"));
+    LONGS_EQUAL(0x01000000, util_version_number ("1.0.0.0"));
+    LONGS_EQUAL(0x01000100, util_version_number ("1.0.1"));
+    LONGS_EQUAL(0x01000200, util_version_number ("1.0.2"));
+    LONGS_EQUAL(0x01010000, util_version_number ("1.1"));
+    LONGS_EQUAL(0x01010100, util_version_number ("1.1.1"));
+    LONGS_EQUAL(0x01010200, util_version_number ("1.1.2"));
+    LONGS_EQUAL(0x01020304, util_version_number ("1.2.3.4"));
 }