* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA
*
- * $Id: m_nick.c 3418 2007-04-22 11:22:10Z jilles $
+ * $Id: m_nick.c 3518 2007-06-22 21:59:09Z jilles $
*/
#include "stdinc.h"
#include "s_newconf.h"
#include "monitor.h"
+/* Give all UID nicks the same TS. This ensures nick TS is always the same on
+ * all servers for each nick-user pair, also if a user with a UID nick changes
+ * their nick but is collided again (the server detecting the collision will
+ * not propagate the nick change further). -- jilles
+ */
+#define SAVE_NICKTS 100
+
static int mr_nick(struct Client *, struct Client *, int, const char **);
static int m_nick(struct Client *, struct Client *, int, const char **);
static int mc_nick(struct Client *, struct Client *, int, const char **);
mapi_clist_av1 nick_clist[] = { &nick_msgtab, &uid_msgtab, &euid_msgtab,
&save_msgtab, NULL };
-DECLARE_MODULE_AV1(nick, NULL, NULL, nick_clist, NULL, NULL, "$Revision: 3418 $");
+DECLARE_MODULE_AV1(nick, NULL, NULL, nick_clist, NULL, NULL, "$Revision: 3518 $");
static int change_remote_nick(struct Client *, struct Client *, time_t,
const char *, int);
return 0;
}
- if(hash_find_nd(nick))
+ if(irc_dictionary_find(nd_dict, nick))
{
sendto_one(source_p, form_str(ERR_UNAVAILRESOURCE),
me.name, EmptyString(source_p->name) ? "*" : source_p->name, nick);
return 0;
}
- if(hash_find_nd(nick))
+ if(irc_dictionary_find(nd_dict, nick))
{
sendto_one(source_p, form_str(ERR_UNAVAILRESOURCE),
me.name, EmptyString(source_p->name) ? "*" : source_p->name, nick);
ServerStats->is_kill++;
sendto_realops_snomask(SNO_DEBUG, L_ALL,
"Bad Nick: %s From: %s(via %s)",
- parv[1], source_p->user->server, client_p->name);
+ parv[1], source_p->servptr->name, client_p->name);
sendto_one(client_p, ":%s KILL %s :%s (Bad Nickname)", me.name, parv[1], me.name);
/* bad nick change, issue kill for the old nick to the rest
del_from_client_hash(source_p->name, source_p);
/* invalidate nick delay when a remote client uses the nick.. */
- if((nd = hash_find_nd(nick)))
+ if((nd = irc_dictionary_retrieve(nd_dict, nick)))
free_nd_entry(nd);
strcpy(source_p->name, nick);
sendto_one(client_p, ":%s SAVE %s %ld", me.id,
uid, (long)newts);
register_client(client_p, source_p,
- uid, newts, parc, parv);
+ uid, SAVE_NICKTS, parc, parv);
}
else
{
sendto_one(client_p, ":%s SAVE %s %ld", me.id,
uid, (long)newts);
register_client(client_p, source_p,
- uid, newts, parc, parv);
+ uid, SAVE_NICKTS, parc, parv);
}
else if(uid)
sendto_one(client_p,
source_p->id, (long)newts);
/* don't send a redundant nick change */
if (!IsDigit(source_p->name[0]))
- change_remote_nick(client_p, source_p, CurrentTime, source_p->id, 1);
+ change_remote_nick(client_p, source_p, SAVE_NICKTS, source_p->id, 1);
}
else
{
* but not in other directions -- jilles */
sendto_one(client_p, ":%s SAVE %s %ld", me.id,
source_p->id, (long)newts);
- /* same CurrentTime as in save_user() */
/* send a :<id> NICK <id> <ts> (!) */
if (!IsDigit(source_p->name[0]))
- change_remote_nick(client_p, source_p, CurrentTime, source_p->id, 1);
+ change_remote_nick(client_p, source_p, SAVE_NICKTS, source_p->id, 1);
}
else
{
const char *m;
int flag;
+ if(server == NULL)
+ {
+ if((server = find_server(NULL, parv[7])) == NULL)
+ {
+ sendto_realops_snomask(SNO_GENERAL, L_ALL,
+ "Ghost killed: %s on invalid server %s",
+ nick, parv[7]);
+ sendto_one(client_p, ":%s KILL %s :%s (Server doesn't exist)",
+ get_id(&me, client_p), nick, me.name);
+ return 0;
+ }
+ }
+
source_p = make_client(client_p);
user = make_user(source_p);
dlinkAddTail(source_p, &source_p->node, &global_client_list);
if(parc == 12)
{
- user->server = find_or_add(server->name);
strlcpy(source_p->info, parv[11], sizeof(source_p->info));
strlcpy(source_p->sockhost, parv[7], sizeof(source_p->sockhost));
strlcpy(source_p->id, parv[8], sizeof(source_p->id));
}
else if(parc == 10)
{
- user->server = find_or_add(server->name);
strlcpy(source_p->info, parv[9], sizeof(source_p->info));
strlcpy(source_p->sockhost, parv[7], sizeof(source_p->sockhost));
strlcpy(source_p->id, parv[8], sizeof(source_p->id));
}
else
{
- user->server = find_or_add(parv[7]);
strlcpy(source_p->info, parv[8], sizeof(source_p->info));
}
/* remove any nd entries for this nick */
- if((nd = hash_find_nd(nick)))
+ if((nd = irc_dictionary_retrieve(nd_dict, nick)))
free_nd_entry(nd);
add_to_client_hash(nick, source_p);
- add_to_hostname_hash(source_p->host, source_p);
+ add_to_hostname_hash(source_p->orighost, source_p);
monitor_signon(source_p);
m = &parv[4][1];
DLINK_FOREACH(ptr, service_list.head)
{
- if(!irccmp((const char *) ptr->data, user->server))
+ if(!irccmp((const char *) ptr->data, server->name))
{
hit++;
break;
if(++Count.total > Count.max_tot)
Count.max_tot = Count.total;
- if(server == NULL)
- {
- if((source_p->servptr = find_server(NULL, user->server)) == NULL)
- {
- sendto_realops_snomask(SNO_GENERAL, L_ALL,
- "Ghost killed: %s on invalid server %s",
- source_p->name, user->server);
- kill_client(client_p, source_p, "%s (Server doesn't exist)", me.name);
- source_p->flags |= FLAGS_KILLED;
- return exit_client(NULL, source_p, &me, "Ghosted Client");
- }
- }
- else
- source_p->servptr = server;
+ source_p->servptr = server;
dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
"Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
client_p->name, source_p->name,
source_p->username, source_p->host,
- user->server, target_p->name, target_p->from->name);
+ server->name, target_p->name, target_p->from->name);
kill_client(client_p, source_p,
"%s (NICK from wrong direction (%s != %s))",
- me.name, user->server, target_p->from->name);
+ me.name, server->name, target_p->from->name);
source_p->flags |= FLAGS_KILLED;
return exit_client(source_p, source_p, &me, "USER server wrong direction");
}
sendto_server(client_p, NULL, CAP_SAVE|CAP_TS6, NOCAPS, ":%s SAVE %s %ld",
source_p->id, target_p->id, (long)target_p->tsinfo);
sendto_server(client_p, NULL, CAP_TS6, CAP_SAVE, ":%s NICK %s :%ld",
- target_p->id, target_p->id, (long)CurrentTime);
+ target_p->id, target_p->id, (long)SAVE_NICKTS);
sendto_server(client_p, NULL, NOCAPS, CAP_TS6, ":%s NICK %s :%ld",
- target_p->name, target_p->id, (long)CurrentTime);
+ target_p->name, target_p->id, (long)SAVE_NICKTS);
if (!IsMe(client_p))
sendto_realops_snomask(SNO_SKILL, L_ALL,
"Received SAVE message for %s from %s",
sendto_one_numeric(target_p, RPL_SAVENICK,
form_str(RPL_SAVENICK), target_p->id);
change_local_nick(target_p, target_p, target_p->id, 0);
+ target_p->tsinfo = SAVE_NICKTS;
}
else
- {
- /* XXX the uid nick gets garbage TS; shouldn't matter though */
- change_remote_nick(target_p, target_p, CurrentTime, target_p->id, 0);
- }
+ change_remote_nick(target_p, target_p, SAVE_NICKTS, target_p->id, 0);
}