Fix various leaks to the global scope.

[irc/quakenet/qwebirc.git] / js / ui / frontends / qui.js

diff --git a/js/ui/frontends/qui.js b/js/ui/frontends/qui.js
index 2f33b68ee03b54f9d4684bb63818be8f80a86221..31f8b2e1e56af3617c04fe51226a79a91255557f 100644 (file)
--- a/js/ui/frontends/qui.js
+++ b/js/ui/frontends/qui.js
@@ -21,11 +21,11 @@ qwebirc.ui.QUI = new Class({
     
     this.outerTabs = this.qjsui.top;
 
-    this.__createDropdownMenu();
-    this.__createDropdownHint();
-    
     this.tabs = new Element("div");
     this.tabs.addClass("tabbar");
+    
+    this.__createDropdownMenu();
+    
     this.outerTabs.appendChild(this.tabs);
     this.origtopic = this.topic = this.qjsui.topic;
     this.origlines = this.lines = this.qjsui.middle;
@@ -49,6 +49,9 @@ qwebirc.ui.QUI = new Class({
     
     this.createInput();
     this.reflow();
+
+    /* HACK, in Chrome this should work immediately but doesn't */
+    this.__createDropdownHint.delay(100, this);
   },
   __createDropdownMenu: function() {
     var dropdownMenu = new Element("span");
@@ -89,7 +92,7 @@ qwebirc.ui.QUI = new Class({
     dropdownEffect.start(1);
     
     this.outerTabs.appendChild(dropdown);
-    dropdownMenu.show = function(x){
+    dropdownMenu.show = function(x) {
       new Event(x).stop();
       this.hideHint();
       
@@ -109,7 +112,7 @@ qwebirc.ui.QUI = new Class({
     dropdown.addEvent("mousedown", function(e) { new Event(e).stop(); });
     dropdown.addEvent("click", dropdownMenu.show);
   },
-  __createDropdownHint: function() {    
+  __createDropdownHint: function() {
     var dropdownhint = new Element("div");
     dropdownhint.addClass("dropdownhint");
     dropdownhint.set("text", "Click the icon for the main menu.");
@@ -281,20 +284,20 @@ qwebirc.ui.QUI.JSUI = new Class({
     var mheight = (docsize.y - topsize.y - bottomsize.y - topicsize.y);
     var mwidth = (docsize.x - rightsize.x);
 
-    topic.setStyle("top", topsize.y + "px");
+    topic.setStyle("top", topsize.y);
     
-    middle.setStyle("top", (topsize.y + topicsize.y) + "px");
+    middle.setStyle("top", (topsize.y + topicsize.y));
     if(mheight > 0) {
-      middle.setStyle("height", mheight + "px");
-      right.setStyle("height", mheight + "px");
+      middle.setStyle("height", mheight);
+      right.setStyle("height", mheight);
     }
     
     if(mwidth > 0)
-      middle.setStyle("width", mwidth + "px");
-    right.setStyle("top", (topsize.y + topicsize.y) + "px");
-    right.setStyle("left", mwidth + "px");
+      middle.setStyle("width", mwidth);
+    right.setStyle("top", (topsize.y + topicsize.y));
+    right.setStyle("left", mwidth);
     
-    bottom.setStyle("top", (docsize.y - bottomsize.y) + "px");
+    bottom.setStyle("top", (docsize.y - bottomsize.y));
     this.fireEvent("reflow");
   },
   showChannel: function(state) {
@@ -481,10 +484,6 @@ qwebirc.ui.QUI.Window = new Class({
       e.menu = this.createMenu(x.realNick, e);
       new Event(x).stop();
     }.bind(this));
-    e.addEvent("dblclick", function(x) {
-      new Event(x).stop();
-      this.client.exec("/QUERY " + e.realNick);
-    }.bind(this));
     
     e.addEvent("focus", function() { this.blur() }.bind(e));
     this.moveMenuClass();
@@ -554,7 +553,7 @@ qwebirc.ui.QUI.Window = new Class({
     this.parent(type, line, colourClass, e);
   },
   setHilighted: function(state) {
-    laststate = this.hilighted;
+    var laststate = this.hilighted;
     
     this.parent(state);