CHANSERV: Added explicit message when allowing opers to issue commands on

[irc/quakenet/newserv.git] / chanserv / chanservprivs.c

diff --git a/chanserv/chanservprivs.c b/chanserv/chanservprivs.c
index 3b70fa71f62f59a1614ad79e72edb9a9298f8527..cd0976e715a4fc0804c5dec6da9bd02ac0297e87 100644 (file)
--- a/chanserv/chanservprivs.c
+++ b/chanserv/chanservprivs.c
@@ -21,6 +21,7 @@ int cs_privcheck(int privnum, nick *np) {
   case QPRIV_VIEWAUTOLIMIT:
   case QPRIV_VIEWBANTIMER:
   case QPRIV_VIEWUSERFLAGS:
+  case QPRIV_VIEWCHANSUSPENSION:
     return (rup && UHasHelperPriv(rup));
     
   case QPRIV_VIEWCOMMENTS:
@@ -31,6 +32,8 @@ int cs_privcheck(int privnum, nick *np) {
   case QPRIV_CHANGEAUTOLIMIT:
   case QPRIV_CHANGEBANTIMER:
   case QPRIV_CHANGEUSERFLAGS:
+  case QPRIV_VIEWSUSPENDEDBY:
+  case QPRIV_VIEWWALLMESSAGE: /* if you change VIEWWALLMESSAGE alter chanservwallmessage too */
     return (np && rup && IsOper(np) && UHasOperPriv(rup));
     
   default: /* By default opers can override anything */
@@ -57,19 +60,28 @@ chanindex *cs_checkaccess(nick *np, const char *chan, unsigned int flags,
     return NULL;
   }
   
-  if (!(rcp=cip->exts[chanservext]) || 
-      (CIsSuspended(rcp) && !cs_privcheck(QPRIV_SUSPENDBYPASS, np))) {
+  if (!(rcp=cip->exts[chanservext])) {
     if (!quiet) chanservstdmessage(np, QM_UNKNOWNCHAN, cip->name->content);
     return NULL;
   }
+  
+  
+  if (CIsSuspended(rcp)) {
+    if (cs_privcheck(QPRIV_SUSPENDBYPASS, np)) {
+      if (!quiet) chanservstdmessage(np, QM_BYPASSINGSUSPEND, cip->name->content);
+    } else {
+      if (!quiet) chanservstdmessage(np, QM_UNKNOWNCHAN, cip->name->content);
+      return NULL;
+    }
+  }
 
   if (rcp && rup)
     rcup=findreguseronchannel(rcp, rup);
   
-  if (!priv || !cs_privcheck(priv,np)) {
+  if (!cs_privcheck(priv,np)) {
     if ((flags & CA_VOICEPRIV) &&
        !(rcp && (CIsVoiceAll(rcp)) && 
-         !(cip->channel && (nickbanned(np, cip->channel) || IsInviteOnly(cip->channel)))) &&
+         !(cip->channel && (nickbanned_visible(np, cip->channel) || IsInviteOnly(cip->channel)))) &&
        !(rcup && (CUHasVoicePriv(rcup)))) {
       if (!quiet) chanservstdmessage(np, QM_NOACCESSONCHAN, cip->name->content, cmdname);
       return NULL;