]> jfr.im git - irc/freenode/ircd-seven.git/commitdiff
strip_unprintable: clarify type conversion origin/filter-module
authorJanik Kleinhoff <redacted>
Thu, 25 Oct 2018 20:31:46 +0000 (20:31 +0000)
committerJanik Kleinhoff <redacted>
Thu, 25 Oct 2018 20:31:46 +0000 (20:31 +0000)
This type conversion is more easily shown to work as intended than the
conversion introduced in 54985f955.

include/inline/stringops.h

index a3c018f0ce1325074c211280024ea60ef8e32b7f..889fd8fab5f96b5100ab992baf4d755d0bc42196 100644 (file)
@@ -81,9 +81,9 @@ strip_colour(char *string)
 static inline char *
 strip_unprintable(char *string)
 {
-       unsigned char *c = (unsigned char *)string;
-       unsigned char *c2 = (unsigned char *)string;
-       unsigned char *last_non_space = NULL;
+       char *c = string;
+       char *c2 = string;
+       char *last_non_space = NULL;
 
        /* c is source, c2 is target */
        for(; c && *c; c++)
@@ -107,7 +107,7 @@ strip_unprintable(char *string)
                        *c2++ = *c;
                        break;
                default:
-                       if (*c < 32)
+                       if ((unsigned char)*c < 32)
                                break;
                        *c2++ = *c;
                        last_non_space = c2;