]> jfr.im git - irc/charybdis-ircd/charybdis.git/commitdiff
extensions/extb_ssl.c: make certfp parameter case-insensitive origin/release/4
authorAaron Jones <redacted>
Tue, 28 Jan 2020 20:46:09 +0000 (20:46 +0000)
committerAaron Jones <redacted>
Tue, 28 Jan 2020 20:47:33 +0000 (20:47 +0000)
I had the idea that maybe these should be case-sensitive because some
encodings (like Base-64) are. But it turns out it's better to
prioritise not breaking existing configurations / channel mode lists,
and just revisit this in future maybe.

[ci skip]

extensions/extb_ssl.c

index 1e11a755e30426dbcb137a32b9fba1028d72bd47..aa6ea95505fa31f1ac4d688b0fa36c39488dfe8d 100644 (file)
@@ -42,7 +42,7 @@ static int eb_ssl(const char *data, struct Client *client_p,
                if (EmptyString(client_p->certfp))
                        return EXTBAN_NOMATCH;
 
-               if (strcmp(data, client_p->certfp) != 0)
+               if (irccmp(data, client_p->certfp) != 0)
                        return EXTBAN_NOMATCH;
        }