Janik Kleinhoff [Tue, 9 Dec 2014 13:48:49 +0000 (13:48 +0000)]
chanserv/help: include INFO in short help instead of RECOVER
The RECOVER command should rarely be needed unless handing out channel
access like popcorn is the norm in some channel, in which case we can't
really help them anyway; as such there's little point in listing it by
default. INFO on the other hand is widely used as *the* way to ask
services for basic information on a channel, so it makes sense to be in
the short help (which nickserv/help does as well).
(In fact, on freenode, the most common use of RECOVER seems to be by
people who use it as the primary way to get opped, given that network's
recommendation to avoid auto-op and their default flag set reflecting
this. I suppose some people misinterpret this as having lost control of
their channel. Presumably it's debatable who's to blame here, but maybe
removing RECOVER from the default short help listing will help avoid
that sort of problem. Either way, it shouldn't hurt.)
Max Teufel [Sat, 10 Sep 2016 14:25:28 +0000 (16:25 +0200)]
help/default/nickserv/cert: clarification about fingerprints
Add a note about the fact that the CertFP implementation is agnostic
with regards to the fingerprint algorithm used by the IRCd. Otherwise,
users could be confused due to the examples.
The code to deal with nick/account (un)registrations operated in the
following manner:
- retrieve the restored mark list for a name (creating one if there
isn't already)
- modify this list
- try to add the updated restored mark list for the used name
However, the list is already modified; the patricia needn't be updated.
In fact, the mowgli_patricia_add call was useless as it merely refused
to add a duplicate key,
(patricia.c:748 mowgli_patricia_elem_add): Key is already in dict, ignoring duplicate
There may be further room for improvement of the code for a future
release.
The code behaved fine anyway because the assertion failure could only
happen in cases where the returned pointer from multimark_list was
unused.
[msg(nickserv)] mark testacct01 list
-!- WALLOP svs.: (multimark.c:192 multimark_list): warning: assertion 'mu != ((void *)0)' failed.
-NickServ(-@.)- testacct01 is not registered anymore but was marked by ilbelkyr on Jul 29 01:49:37 2016 +0000: foo
James Lu [Tue, 12 Jul 2016 06:07:25 +0000 (23:07 -0700)]
protocols/unreal*: fix wrong source for SVSNICK
Apparently, UnrealIRCd SVSNICK is server only (at least on 3.2.10.6 and 4.0.3.1). When NickServ is used as a source, the following error is sent by the uplink and the SVSNICK command silently fails.
[2016-07-11 23:01:51] <- :NickServ NOTICE GL4 :GL has been released.
[2016-07-11 23:01:51] NickServ GL/AAAAAAAAB:GL4!gl@localhost[localhost] RELEASE: GL!GLolol@escape.the.dreamland.ca
[2016-07-11 23:01:51] -> :unreal.midnight.vpn 487 NickServ :SVSNICK is a server only command
William Pitcock [Fri, 15 Apr 2016 09:05:52 +0000 (04:05 -0500)]
libathemecore: flags: update_chanacs_flags(): do not assume that a protocol module is loaded.
this is fine because update_chanacs_flags() is called at a final point after it is guaranteed
that a protocol module is loaded or the process has gracefully exited.
This prevents transferring foundership to exttargets such as $registered
or $chanacs:#channel. This is already done in chanserv/flags and
friends.
Reported by @nyuszika7h.
Attila Molnar [Fri, 25 Mar 2016 11:26:44 +0000 (12:26 +0100)]
protocol/inspircd: Only set hideoper mode on oper pseudoclients
This fixes an issue when Atheme is used with an InspIRCd network with
the hideoper module loaded. InspIRCd adjusts the number of online
opers shown in reply to LUSERS according to the number of hidden opers
(+H clients). This breaks if non-oper clients have the (otherwise
oper-only) hideoper mode set. (Plus it also does not make much sense
to set the hideoper mode on non-opers.)
This patch changes the protocol module so that the hideoper mode is
only set on pseudoclients which are also opered.
Max Teufel [Sun, 6 Mar 2016 09:27:40 +0000 (10:27 +0100)]
chanserv/flags: make Anope FLAGS compatibility an option
Previously, ChanServ FLAGS behavior could be modified by registering or
dropping the keyword nicks "LIST", "CLEAR", and "MODIFY".
Now, a configuration option is available that when turned on (default),
disables registration of these keyword nicks and enables this
compatibility feature. When turned off, registration of these keyword
nicks is possible, and compatibility to Anope's FLAGS command is
disabled.
Austin Ellis [Fri, 4 Mar 2016 15:21:30 +0000 (09:21 -0600)]
CLONE should include MARK
CLONE after additional thought and discussion on IRC *should* transfer
the MARK to avoid channel from evading a MARK placed on it. (Referenced
atheme/atheme#462)
Austin Ellis [Fri, 4 Mar 2016 03:32:26 +0000 (21:32 -0600)]
Do not clone HOLD, MARK, ANTIFLOOD AKILL
When using ChanServ/CLONE, oper-only flags should not be cloned over.
Also, don't clone the MARK on the source channel (Fixes #462) Thanks
@shaynejellesma
Austin Ellis [Fri, 4 Mar 2016 02:15:40 +0000 (20:15 -0600)]
ChanServ CLONE should not copy HOLDs
Ensure that ChanServ/CLONE does not copy over HOLDs -- leave that up to
Services Operators on networks to decide. All other settings should be
cloned, however. (Fixes #462)
projects / irc / atheme / atheme.git / log
