configure: --enable-warnings: remove -Wno-missing-variable-declarations

Only GroupServ (to be addressed shortly) and NickServ LIST (ditto)
are the major remaining violators of using non-static symbols without
a previous extern declaration for them. Re-enable this warning so that
future changes that introduce more of this behaviour are caught.

diff --git a/configure b/configure
index dfa93434c92ff17bfa7d717d0c2db2fbcd0e3b26..33073ade8088c0e6b38060480c22fb91ebc304d3 100755 (executable)
--- a/configure
+++ b/configure
@@ -17231,6 +17231,47 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
 
 
 
+        { $as_echo "$as_me:${as_lineno-$LINENO}: checking for C compiler flag(s) -Wmissing-variable-declarations " >&5
+$as_echo_n "checking for C compiler flag(s) -Wmissing-variable-declarations ... " >&6; }
+
+        CFLAGS_SAVED="${CFLAGS}"
+        CFLAGS="${CFLAGS} -Wmissing-variable-declarations"
+
+        cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+
+int
+main ()
+{
+
+  ;
+  return 0;
+}
+
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+
+                ATHEME_CC_TEST_CFLAGS_RESULT='yes'
+
+                { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+$as_echo "yes" >&6; }
+
+else
+
+                ATHEME_CC_TEST_CFLAGS_RESULT='no'
+                CFLAGS="${CFLAGS_SAVED}"
+
+                { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+
+        unset CFLAGS_SAVED
+
+
+
         { $as_echo "$as_me:${as_lineno-$LINENO}: checking for C compiler flag(s) -Wmultistatement-macros " >&5
 $as_echo_n "checking for C compiler flag(s) -Wmultistatement-macros ... " >&6; }
 
@@ -18593,47 +18634,6 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
 
 
 
-        { $as_echo "$as_me:${as_lineno-$LINENO}: checking for C compiler flag(s) -Wno-missing-variable-declarations " >&5
-$as_echo_n "checking for C compiler flag(s) -Wno-missing-variable-declarations ... " >&6; }
-
-        CFLAGS_SAVED="${CFLAGS}"
-        CFLAGS="${CFLAGS} -Wno-missing-variable-declarations"
-
-        cat confdefs.h - <<_ACEOF >conftest.$ac_ext
-/* end confdefs.h.  */
-
-
-int
-main ()
-{
-
-  ;
-  return 0;
-}
-
-_ACEOF
-if ac_fn_c_try_compile "$LINENO"; then :
-
-                ATHEME_CC_TEST_CFLAGS_RESULT='yes'
-
-                { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
-$as_echo "yes" >&6; }
-
-else
-
-                ATHEME_CC_TEST_CFLAGS_RESULT='no'
-                CFLAGS="${CFLAGS_SAVED}"
-
-                { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-
-fi
-rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
-
-        unset CFLAGS_SAVED
-
-
-
         { $as_echo "$as_me:${as_lineno-$LINENO}: checking for C compiler flag(s) -Wno-packed " >&5
 $as_echo_n "checking for C compiler flag(s) -Wno-packed ... " >&6; }
 

diff --git a/m4/atheme-featuretest-warnings.m4 b/m4/atheme-featuretest-warnings.m4
index ae60ae51a50ce8621240a424d1ed498a78423170..1f7eb9ceecd15da9dd5547e46da74cbefb12d55e 100644 (file)
--- a/m4/atheme-featuretest-warnings.m4
+++ b/m4/atheme-featuretest-warnings.m4
@@ -50,6 +50,7 @@ AC_DEFUN([ATHEME_CC_ENABLE_WARNINGS], [
         ATHEME_CC_TEST_CFLAGS([-Wmissing-declarations])
         ATHEME_CC_TEST_CFLAGS([-Wmissing-format-attribute])
         ATHEME_CC_TEST_CFLAGS([-Wmissing-prototypes])
+        ATHEME_CC_TEST_CFLAGS([-Wmissing-variable-declarations])
         ATHEME_CC_TEST_CFLAGS([-Wmultistatement-macros])
         ATHEME_CC_TEST_CFLAGS([-Wnested-externs])
         ATHEME_CC_TEST_CFLAGS([-Wnormalized=nfkc])
@@ -89,7 +90,6 @@ AC_DEFUN([ATHEME_CC_ENABLE_WARNINGS], [
     ATHEME_CC_TEST_CFLAGS([-Wno-format-pedantic])
     ATHEME_CC_TEST_CFLAGS([-Wno-inline])
     ATHEME_CC_TEST_CFLAGS([-Wno-missing-include-dirs])
-    ATHEME_CC_TEST_CFLAGS([-Wno-missing-variable-declarations])
     ATHEME_CC_TEST_CFLAGS([-Wno-packed])
     ATHEME_CC_TEST_CFLAGS([-Wno-padded])
     ATHEME_CC_TEST_CFLAGS([-Wno-pedantic])