libathemecore/ptasks.c: STATS:T: make nonsensitive data available

The statistics for server, user, and chan can already be obtained via
the LUSERS command on IRC, so it does not make sense for services to
prevent accessing these by requiring services privileges.

Furthermore, the number of registered accounts, nicknames, and channels
should also not be considered sensitive data. The Atheme project does
not condone hiding such basic and non-sensitive data from network users.

Finally, put missing mynicks count in default MOTD file.

diff --git a/dist/atheme.motd.example b/dist/atheme.motd.example
index fabddd6070dc3c0a7702c6d78c75f4316f8b7e7e..cf013fc36fc1b7ad6a64ce91648a728ac4ed4f3a 100644 (file)
--- a/dist/atheme.motd.example
+++ b/dist/atheme.motd.example
@@ -4,6 +4,7 @@ Nickname registrations will expire after &nickexpiry& days.
 Channel registrations will expire after &chanexpiry& days.
 
 Registered users: &myusers&
+Registered nicks: &mynicks&
 Registered channels: &mychans&
 
 The services administrator can add additional information

diff --git a/libathemecore/ptasks.c b/libathemecore/ptasks.c
index ee4a3d169e19891e4c4514e1ebdfffe0b080b4a0..c42d233bdf663727dcc7a2cd7b4ef26dd8cade4c 100644 (file)
--- a/libathemecore/ptasks.c
+++ b/libathemecore/ptasks.c
@@ -245,6 +245,16 @@ handle_stats(struct user *u, char req)
 
          case 'T':
          case 't':
+                 // These 3 are not sensitive; and can already be obtained with /LUSERS on IRC
+                 numeric_sts(me.me, 249, u, "T :server     %7u", cnt.server);
+                 numeric_sts(me.me, 249, u, "T :user       %7u", cnt.user);
+                 numeric_sts(me.me, 249, u, "T :chan       %7u", cnt.chan);
+
+                 // These 3 are not sensitive
+                 numeric_sts(me.me, 249, u, "T :myuser     %7u", cnt.myuser);
+                 numeric_sts(me.me, 249, u, "T :mynick     %7u", cnt.mynick);
+                 numeric_sts(me.me, 249, u, "T :mychan     %7u", cnt.mychan);
+
                  if (!has_priv_user(u, PRIV_SERVER_AUSPEX))
                          break;
 
@@ -256,15 +266,9 @@ handle_stats(struct user *u, char req)
                  numeric_sts(me.me, 249, u, "T :tld        %7u", cnt.tld);
                  numeric_sts(me.me, 249, u, "T :kline      %7u", cnt.kline);
                  numeric_sts(me.me, 249, u, "T :xline      %7u", cnt.xline);
-                 numeric_sts(me.me, 249, u, "T :server     %7u", cnt.server);
-                 numeric_sts(me.me, 249, u, "T :user       %7u", cnt.user);
-                 numeric_sts(me.me, 249, u, "T :chan       %7u", cnt.chan);
                  numeric_sts(me.me, 249, u, "T :chanuser   %7u", cnt.chanuser);
-                 numeric_sts(me.me, 249, u, "T :myuser     %7u", cnt.myuser);
                  numeric_sts(me.me, 249, u, "T :myuser_acc %7u", cnt.myuser_access);
-                 numeric_sts(me.me, 249, u, "T :mynick     %7u", cnt.mynick);
                  numeric_sts(me.me, 249, u, "T :myuser_nam %7u", cnt.myuser_name);
-                 numeric_sts(me.me, 249, u, "T :mychan     %7u", cnt.mychan);
                  numeric_sts(me.me, 249, u, "T :chanacs    %7u", cnt.chanacs);
 
 #ifdef OBJECT_DEBUG