software/!RELEASES/ircservices/achurch.org/services/lists/ircservices/2008/005658.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] Patch: Flush write buffer on connect
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20Patch%3A%20Flush%20write%20buffer%20on%20connect&In-Reply-To=">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="005668.html">
  11    <LINK REL="Next"  HREF="005660.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] Patch: Flush write buffer on connect</H1>
  15     <B>Alexander Barton</B>
  16     <A HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20Patch%3A%20Flush%20write%20buffer%20on%20connect&In-Reply-To="
  17        TITLE="[IRCServices] Patch: Flush write buffer on connect">alex at barton.de
  18        </A><BR>
  19     <I>Tue Nov 11 09:14:57 PST 2008</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="005668.html">[IRCServices] Patch: Make IRCServices 5.1.13 compile on Mac OS X
  22 </A></li>
  23         <LI>Next message: <A HREF="005660.html">[IRCServices] Patch: Flush write buffer on connect
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#5658">[ date ]</a>
  27               <a href="thread.html#5658">[ thread ]</a>
  28               <a href="subject.html#5658">[ subject ]</a>
  29               <a href="author.html#5658">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>Hi!
  35
  36 The attached patch fixes the problem that IRCServices don't flush the
  37 write buffer when the connection to the server is establised and data
  38 has already been written to the buffer.
  39
  40 This caused the server to disconnect IRCServices after a timeout
  41 because of no data has been sent. Solution has been to send
  42 IRCServices a HUP signal right after starting it. I was able to
  43 reproduce this problem on all of my machines (Linux on HPPA, Linux on
  44 amd64, and Mac OS X on i386).
  45
  46 I think these messages describe the same problem:
  47 &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005283.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005283.html</A>&gt;
  48 &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005288.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005288.html</A>&gt;
  49 &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005318.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005318.html</A>&gt;
  50 &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005319.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005319.html</A>&gt;
  51 &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005287.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005287.html</A>&gt;
  52
  53 Regards
  54 Alex
  55
  56
  57 diff -rup ircservices-5.1.13-orig/sockets.c ircservices-5.1.13/sockets.c
  58 --- ircservices-5.1.13-orig/sockets.c   2008-11-07 18:11:57.000000000
  59 +0100
  60 +++ ircservices-5.1.13/sockets.c        2008-11-09 15:53:35.000000000 +0100
  61 @@ -691,6 +691,10 @@ void check_sockets(void)
  62                  }
  63                  s-&gt;flags &amp;= ~SF_CONNECTING;
  64                  s-&gt;flags |= SF_CONNECTED;
  65 +
  66 +               /* Flush already cached data for this socket */
  67 +               flush_write_buffer(s);
  68 +
  69                  FD_CLR(i, &amp;write_fds);
  70                  if (!(s-&gt;flags &amp; SF_MUTE))
  71                      FD_SET(i, &amp;sock_fds);
  72
  73 </PRE>
  74
  75
  76
  77
  78
  79
  80 <!--endarticle-->
  81     <HR>
  82     <P><UL>
  83         <!--threads-->
  84         <LI>Previous message: <A HREF="005668.html">[IRCServices] Patch: Make IRCServices 5.1.13 compile on Mac OS X
  85 </A></li>
  86         <LI>Next message: <A HREF="005660.html">[IRCServices] Patch: Flush write buffer on connect
  87 </A></li>
  88          <LI> <B>Messages sorted by:</B>
  89               <a href="date.html#5658">[ date ]</a>
  90               <a href="thread.html#5658">[ thread ]</a>
  91               <a href="subject.html#5658">[ subject ]</a>
  92               <a href="author.html#5658">[ author ]</a>
  93          </LI>
  94        </UL>
  95
  96 </body></html>