]> jfr.im git - irc.git/blob - software/!RELEASES/ircservices/achurch.org/services/lists/ircservices/2008/005605.html
RELEASE -> !RELEASE
[irc.git] / software / !RELEASES / ircservices / achurch.org / services / lists / ircservices / 2008 / 005605.html
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
2 <HTML>
3 <HEAD>
4 <TITLE> [IRCServices] Kick war with ChanServ, for the 135175631861th time..
5 </TITLE>
6 <LINK REL="Index" HREF="index.html" >
7 <LINK REL="made" HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20Kick%20war%20with%20ChanServ%2C%0A%09for%20the%20135175631861th%20time..&In-Reply-To=b19eae4e0801051548ldcfe68ay943add08750e226%40mail.gmail.com">
8 <META NAME="robots" CONTENT="index,nofollow">
9 <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
10 <LINK REL="Previous" HREF="005604.html">
11 <LINK REL="Next" HREF="005606.html">
12 </HEAD>
13 <BODY BGCOLOR="#ffffff">
14 <H1>[IRCServices] Kick war with ChanServ, for the 135175631861th time..</H1>
15 <B>Andrew Church</B>
16 <A HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20Kick%20war%20with%20ChanServ%2C%0A%09for%20the%20135175631861th%20time..&In-Reply-To=b19eae4e0801051548ldcfe68ay943add08750e226%40mail.gmail.com"
17 TITLE="[IRCServices] Kick war with ChanServ, for the 135175631861th time..">achurch at achurch.org
18 </A><BR>
19 <I>Sun Jan 6 08:52:34 PST 2008</I>
20 <P><UL>
21 <LI>Previous message: <A HREF="005604.html">[IRCServices] Kick war with ChanServ, for the 135175631861th time..
22 </A></li>
23 <LI>Next message: <A HREF="005606.html">[IRCServices] Kick war with ChanServ, for the 135175631861th time..
24 </A></li>
25 <LI> <B>Messages sorted by:</B>
26 <a href="date.html#5605">[ date ]</a>
27 <a href="thread.html#5605">[ thread ]</a>
28 <a href="subject.html#5605">[ subject ]</a>
29 <a href="author.html#5605">[ author ]</a>
30 </LI>
31 </UL>
32 <HR>
33 <!--beginarticle-->
34 <PRE>&gt;<i>I understand it must be frustrating to have an issue like this that's
35 </I>&gt;<i>so hard to track down, but it is equally frustrating to get bit in the
36 </I>&gt;<i>ass by it. Isn't it wise to assume that if they are joining an
37 </I>&gt;<i>existing channel that a ban matching them doesn't exist anyway
38 </I>&gt;<i>(otherwise how are they joining?)
39 </I>
40 +e, +I, explicit INVITE, possibly other methods. Originally, I didn't
41 bother checking for the ban, but apparently it caused a problem, because
42 I added the check in 4.5pre0:
43
44 2001/01/11 Fixed duplicate adding of bans when auto-kicking a user
45 from a channel. Reported by James &lt;<A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">daemus at evilcode.com</A>&gt;
46 --- chanserv.c 11 Jan 2001 00:03:56 -0000 1.10
47 +++ chanserv.c 11 Jan 2001 04:29:13 -0000 1.11
48 @@ -670,10 +670,13 @@
49 #else
50 }
51 #endif
52 - av[1] = &quot;+b&quot;;
53 - av[2] = mask;
54 - send_cmd(s_ChanServ, &quot;MODE %s +b %s %lu&quot;, chan, mask, time(NULL));
55 - do_cmode(s_ChanServ, 3, av);
56 + /* Apparently invites can get around bans, so check for ban first */
57 + if (!chan_has_ban(mask)) {
58 + av[1] = &quot;+b&quot;;
59 + av[2] = mask;
60 + send_cmd(s_ChanServ, &quot;MODE %s +b %s %lu&quot;, chan, mask, time(NULL));
61 + do_cmode(s_ChanServ, 3, av);
62 + }
63 free(mask);
64 send_cmd(s_ChanServ, &quot;KICK %s %s :%s&quot;, chan, user-&gt;nick, reason);
65 if (stay) {
66
67 The list archives are down at the moment, so I can't check exactly what
68 the problem was, whether it was a serious issue or just cosmetic; I'm
69 hesitant to remove the check without knowing more. (Of course, you're
70 welcome to try removing it yourself and seeing what happens.)
71
72 --Andrew Church
73 <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
74 <A HREF="http://achurch.org/">http://achurch.org/</A>
75 </PRE>
76
77
78 <!--endarticle-->
79 <HR>
80 <P><UL>
81 <!--threads-->
82 <LI>Previous message: <A HREF="005604.html">[IRCServices] Kick war with ChanServ, for the 135175631861th time..
83 </A></li>
84 <LI>Next message: <A HREF="005606.html">[IRCServices] Kick war with ChanServ, for the 135175631861th time..
85 </A></li>
86 <LI> <B>Messages sorted by:</B>
87 <a href="date.html#5605">[ date ]</a>
88 <a href="thread.html#5605">[ thread ]</a>
89 <a href="subject.html#5605">[ subject ]</a>
90 <a href="author.html#5605">[ author ]</a>
91 </LI>
92 </UL>
93
94 </body></html>