software/RELEASES/ircservices/achurch.org/services/lists/ircservices/2008/005661.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] Patch: Flush write buffer on connect
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20Patch%3A%20Flush%20write%20buffer%20on%20connect&In-Reply-To=4925DA72.8020806%40barton.de">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="005660.html">
  11    <LINK REL="Next"  HREF="005662.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] Patch: Flush write buffer on connect</H1>
  15     <B>Andrew Church</B>
  16     <A HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20Patch%3A%20Flush%20write%20buffer%20on%20connect&In-Reply-To=4925DA72.8020806%40barton.de"
  17        TITLE="[IRCServices] Patch: Flush write buffer on connect">achurch at achurch.org
  18        </A><BR>
  19     <I>Fri Nov 21 11:48:08 PST 2008</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="005660.html">[IRCServices] Patch: Flush write buffer on connect
  22 </A></li>
  23         <LI>Next message: <A HREF="005662.html">[IRCServices] Patch: Flush write buffer on connect
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#5661">[ date ]</a>
  27               <a href="thread.html#5661">[ thread ]</a>
  28               <a href="subject.html#5661">[ subject ]</a>
  29               <a href="author.html#5661">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>Sorry, I'm busy with work at the moment and don't have the time to
  35 investigate the issue in detail.  I'll take a closer look when I do
  36 have time.
  37
  38   --Andrew Church
  39     <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
  40     <A HREF="http://achurch.org/">http://achurch.org/</A>
  41
  42 &gt;<i>Hi all!
  43 </I>&gt;<i>
  44 </I>&gt;<i>Any comments to this patch?
  45 </I>&gt;<i>
  46 </I>&gt;<i>Regards
  47 </I>&gt;<i>Alex
  48 </I>&gt;<i>
  49 </I>&gt;<i>Am 11.11.2008 18:14, Alexander Barton schrieb:
  50 </I>&gt;<i>
  51 </I>&gt;&gt;<i> Hi!
  52 </I>&gt;&gt;<i>
  53 </I>&gt;&gt;<i> The attached patch fixes the problem that IRCServices don't flush the
  54 </I>&gt;&gt;<i> write buffer when the connection to the server is establised and data
  55 </I>&gt;&gt;<i> has already been written to the buffer.
  56 </I>&gt;&gt;<i>
  57 </I>&gt;&gt;<i> This caused the server to disconnect IRCServices after a timeout
  58 </I>&gt;&gt;<i> because of no data has been sent. Solution has been to send
  59 </I>&gt;&gt;<i> IRCServices a HUP signal right after starting it. I was able to
  60 </I>&gt;&gt;<i> reproduce this problem on all of my machines (Linux on HPPA, Linux on
  61 </I>&gt;&gt;<i> amd64, and Mac OS X on i386).
  62 </I>&gt;&gt;<i>
  63 </I>&gt;&gt;<i> I think these messages describe the same problem:
  64 </I>&gt;&gt;<i> &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005283.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005283.html</A>&gt;
  65 </I>&gt;&gt;<i> &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005288.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005288.html</A>&gt;
  66 </I>&gt;&gt;<i> &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005318.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005318.html</A>&gt;
  67 </I>&gt;&gt;<i> &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005319.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005319.html</A>&gt;
  68 </I>&gt;&gt;<i> &lt;<A HREF="http://lists.ircservices.za.net/pipermail/ircservices/2007/005287.html">http://lists.ircservices.za.net/pipermail/ircservices/2007/005287.html</A>&gt;
  69 </I>&gt;&gt;<i>
  70 </I>&gt;&gt;<i> Regards
  71 </I>&gt;&gt;<i> Alex
  72 </I>&gt;&gt;<i>
  73 </I>&gt;&gt;<i>
  74 </I>&gt;&gt;<i> diff -rup ircservices-5.1.13-orig/sockets.c ircservices-5.1.13/sockets.c
  75 </I>&gt;&gt;<i> --- ircservices-5.1.13-orig/sockets.c   2008-11-07 18:11:57.000000000
  76 </I>&gt;&gt;<i> +0100
  77 </I>&gt;&gt;<i> +++ ircservices-5.1.13/sockets.c        2008-11-09 15:53:35.000000000 +0100
  78 </I>&gt;&gt;<i> @@ -691,6 +691,10 @@ void check_sockets(void)
  79 </I>&gt;&gt;<i>                  }
  80 </I>&gt;&gt;<i>                  s-&gt;flags &amp;= ~SF_CONNECTING;
  81 </I>&gt;&gt;<i>                  s-&gt;flags |= SF_CONNECTED;
  82 </I>&gt;&gt;<i> +
  83 </I>&gt;&gt;<i> +               /* Flush already cached data for this socket */
  84 </I>&gt;&gt;<i> +               flush_write_buffer(s);
  85 </I>&gt;&gt;<i> +
  86 </I>&gt;&gt;<i>                  FD_CLR(i, &amp;write_fds);
  87 </I>&gt;&gt;<i>                  if (!(s-&gt;flags &amp; SF_MUTE))
  88 </I>&gt;&gt;<i>                      FD_SET(i, &amp;sock_fds);
  89 </I>&gt;&gt;<i>
  90 </I>&gt;<i>
  91 </I>&gt;<i>
  92 </I>&gt;<i>------------------------------------------------------------------
  93 </I>&gt;<i>To unsubscribe or change your subscription options, visit:
  94 </I>&gt;<i><A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">http://lists.ircservices.za.net/mailman/listinfo/ircservices</A>
  95 </I></PRE>
  96
  97
  98
  99
 100
 101 <!--endarticle-->
 102     <HR>
 103     <P><UL>
 104         <!--threads-->
 105         <LI>Previous message: <A HREF="005660.html">[IRCServices] Patch: Flush write buffer on connect
 106 </A></li>
 107         <LI>Next message: <A HREF="005662.html">[IRCServices] Patch: Flush write buffer on connect
 108 </A></li>
 109          <LI> <B>Messages sorted by:</B>
 110               <a href="date.html#5661">[ date ]</a>
 111               <a href="thread.html#5661">[ thread ]</a>
 112               <a href="subject.html#5661">[ subject ]</a>
 113               <a href="author.html#5661">[ author ]</a>
 114          </LI>
 115        </UL>
 116
 117 </body></html>