software/RELEASES/ircservices/achurch.org/services/lists/ircservices/2005/005042.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] akick not setting channel ban
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20akick%20not%20setting%20channel%20ban&In-Reply-To=4324efa5.16566%40msgid.achurch.org">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="005041.html">
  11    <LINK REL="Next"  HREF="005032.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] akick not setting channel ban</H1>
  15     <B>Aragon Gouveia</B>
  16     <A HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20akick%20not%20setting%20channel%20ban&In-Reply-To=4324efa5.16566%40msgid.achurch.org"
  17        TITLE="[IRCServices] akick not setting channel ban">aragon at phat.za.net
  18        </A><BR>
  19     <I>Mon Sep 12 14:21:05 PDT 2005</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="005041.html">[IRCServices] akick not setting channel ban
  22 </A></li>
  23         <LI>Next message: <A HREF="005032.html">[IRCServices] Config file splitting
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#5042">[ date ]</a>
  27               <a href="thread.html#5042">[ thread ]</a>
  28               <a href="subject.html#5042">[ subject ]</a>
  29               <a href="author.html#5042">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>Agreed it could be a network desync.  Thanks for the patch.  Will apply it
  35 and let you know the results.
  36
  37
  38
  39 |<i> By Andrew Church &lt;<A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>&gt;
  40 </I>|<i>                                          [ 2005-09-12 05:02 +0200 ]
  41 </I>&gt;<i> &gt;I suspect that some of the irc servers in the network drop a ban
  42 </I>&gt;<i> &gt;silently, resulting in services having this ban on their list, which
  43 </I>&gt;<i> &gt;is desynched from the rest of the network in this case. I've seen
  44 </I>&gt;<i> &gt;similar situations with old hybrid servers and other services, but who
  45 </I>&gt;<i> &gt;knows..
  46 </I>&gt;<i>
  47 </I>&gt;<i>      That's an interesting possibility.  To the original poster: try
  48 </I>&gt;<i> applying the following patch to Services, then recompiling and restarting
  49 </I>&gt;<i> in debug mode (ircservices -debug).  When you see the bug happening, check
  50 </I>&gt;<i> the logfile and see if the ban in question is listed.  (Also, if you could
  51 </I>&gt;<i> privately send me the full debug logfile for further analysis I'd
  52 </I>&gt;<i> appreciate it.)
  53 </I>&gt;<i>
  54 </I>&gt;<i>   --Andrew Church
  55 </I>&gt;<i>     <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
  56 </I>&gt;<i>     <A HREF="http://achurch.org/">http://achurch.org/</A>
  57 </I>&gt;<i>
  58 </I>&gt;<i> ---------------------------------------------------------------------------
  59 </I>&gt;<i>
  60 </I>&gt;<i> Index: channels.c
  61 </I>&gt;<i> ===================================================================
  62 </I>&gt;<i> RCS file: /var/local/cvsroot/ircservices/channels.c,v
  63 </I>&gt;<i> retrieving revision 2.43.2.1
  64 </I>&gt;<i> diff -u -r2.43.2.1 channels.c
  65 </I>&gt;<i> --- channels.c      6 Jan 2005 17:15:11 -0000       2.43.2.1
  66 </I>&gt;<i> +++ channels.c      12 Sep 2005 03:01:04 -0000
  67 </I>&gt;<i> @@ -192,22 +192,33 @@
  68 </I>&gt;<i>
  69 </I>&gt;<i>      t = strchr(ban, '!');
  70 </I>&gt;<i>      i = 0;
  71 </I>&gt;<i> +    if (debug)
  72 </I>&gt;<i> +   log(&quot;find_ban([%s],[%s])&quot;, chan-&gt;name, ban);
  73 </I>&gt;<i>      ARRAY_FOREACH (i, chan-&gt;bans) {
  74 </I>&gt;<i> +   if (debug)
  75 </I>&gt;<i> +       log(&quot;... checking [%s]&quot;, chan-&gt;bans[i]);
  76 </I>&gt;<i>     s = strchr(chan-&gt;bans[i], '!');
  77 </I>&gt;<i>     if (s &amp;&amp; t) {
  78 </I>&gt;<i>         if (s-(chan-&gt;bans[i]) == t-ban
  79 </I>&gt;<i>          &amp;&amp; irc_strnicmp(chan-&gt;bans[i], ban, s-(chan-&gt;bans[i])) == 0
  80 </I>&gt;<i>          &amp;&amp; stricmp(s+1, t+1) == 0
  81 </I>&gt;<i>         ) {
  82 </I>&gt;<i> +           if (debug)
  83 </I>&gt;<i> +               log(&quot;... found!&quot;);
  84 </I>&gt;<i>             return i;
  85 </I>&gt;<i>         }
  86 </I>&gt;<i>     } else if (!s &amp;&amp; !t) {
  87 </I>&gt;<i>         /* Bans without '!' should be impossible; just
  88 </I>&gt;<i>          * do a case-insensitive compare */
  89 </I>&gt;<i> -       if (stricmp(chan-&gt;bans[i], ban) == 0)
  90 </I>&gt;<i> +       if (stricmp(chan-&gt;bans[i], ban) == 0) {
  91 </I>&gt;<i> +           if (debug)
  92 </I>&gt;<i> +               log(&quot;... found!&quot;);
  93 </I>&gt;<i>             return i;
  94 </I>&gt;<i> +       }
  95 </I>&gt;<i>     }
  96 </I>&gt;<i>      }
  97 </I>&gt;<i> +    if (debug)
  98 </I>&gt;<i> +   log(&quot;... NOT found&quot;);
  99 </I>&gt;<i>      return -1;
 100 </I>&gt;<i>  }
 101 </I>&gt;<i>
 102 </I>&gt;<i> ------------------------------------------------------------------
 103 </I>&gt;<i> To unsubscribe or change your subscription options, visit:
 104 </I>&gt;<i> <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">http://lists.ircservices.za.net/mailman/listinfo/ircservices</A>
 105 </I></PRE>
 106
 107
 108 <!--endarticle-->
 109     <HR>
 110     <P><UL>
 111         <!--threads-->
 112         <LI>Previous message: <A HREF="005041.html">[IRCServices] akick not setting channel ban
 113 </A></li>
 114         <LI>Next message: <A HREF="005032.html">[IRCServices] Config file splitting
 115 </A></li>
 116          <LI> <B>Messages sorted by:</B>
 117               <a href="date.html#5042">[ date ]</a>
 118               <a href="thread.html#5042">[ thread ]</a>
 119               <a href="subject.html#5042">[ subject ]</a>
 120               <a href="author.html#5042">[ author ]</a>
 121          </LI>
 122        </UL>
 123
 124 </body></html>