software/RELEASES/ircservices/achurch.org/services/lists/ircservices/2005/005041.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] akick not setting channel ban
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20akick%20not%20setting%20channel%20ban&In-Reply-To=ce6d53600509111444a3684ab%40mail.gmail.com">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="005040.html">
  11    <LINK REL="Next"  HREF="005042.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] akick not setting channel ban</H1>
  15     <B>Andrew Church</B>
  16     <A HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20akick%20not%20setting%20channel%20ban&In-Reply-To=ce6d53600509111444a3684ab%40mail.gmail.com"
  17        TITLE="[IRCServices] akick not setting channel ban">achurch at achurch.org
  18        </A><BR>
  19     <I>Mon Sep 12 11:51:18 PDT 2005</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="005040.html">[IRCServices] akick not setting channel ban
  22 </A></li>
  23         <LI>Next message: <A HREF="005042.html">[IRCServices] akick not setting channel ban
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#5041">[ date ]</a>
  27               <a href="thread.html#5041">[ thread ]</a>
  28               <a href="subject.html#5041">[ subject ]</a>
  29               <a href="author.html#5041">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>&gt;<i>I suspect that some of the irc servers in the network drop a ban
  35 </I>&gt;<i>silently, resulting in services having this ban on their list, which
  36 </I>&gt;<i>is desynched from the rest of the network in this case. I've seen
  37 </I>&gt;<i>similar situations with old hybrid servers and other services, but who
  38 </I>&gt;<i>knows..
  39 </I>
  40      That's an interesting possibility.  To the original poster: try
  41 applying the following patch to Services, then recompiling and restarting
  42 in debug mode (ircservices -debug).  When you see the bug happening, check
  43 the logfile and see if the ban in question is listed.  (Also, if you could
  44 privately send me the full debug logfile for further analysis I'd
  45 appreciate it.)
  46
  47   --Andrew Church
  48     <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
  49     <A HREF="http://achurch.org/">http://achurch.org/</A>
  50
  51 ---------------------------------------------------------------------------
  52
  53 Index: channels.c
  54 ===================================================================
  55 RCS file: /var/local/cvsroot/ircservices/channels.c,v
  56 retrieving revision 2.43.2.1
  57 diff -u -r2.43.2.1 channels.c
  58 --- channels.c  6 Jan 2005 17:15:11 -0000       2.43.2.1
  59 +++ channels.c  12 Sep 2005 03:01:04 -0000
  60 @@ -192,22 +192,33 @@
  61
  62      t = strchr(ban, '!');
  63      i = 0;
  64 +    if (debug)
  65 +       log(&quot;find_ban([%s],[%s])&quot;, chan-&gt;name, ban);
  66      ARRAY_FOREACH (i, chan-&gt;bans) {
  67 +       if (debug)
  68 +           log(&quot;... checking [%s]&quot;, chan-&gt;bans[i]);
  69         s = strchr(chan-&gt;bans[i], '!');
  70         if (s &amp;&amp; t) {
  71             if (s-(chan-&gt;bans[i]) == t-ban
  72              &amp;&amp; irc_strnicmp(chan-&gt;bans[i], ban, s-(chan-&gt;bans[i])) == 0
  73              &amp;&amp; stricmp(s+1, t+1) == 0
  74             ) {
  75 +               if (debug)
  76 +                   log(&quot;... found!&quot;);
  77                 return i;
  78             }
  79         } else if (!s &amp;&amp; !t) {
  80             /* Bans without '!' should be impossible; just
  81              * do a case-insensitive compare */
  82 -           if (stricmp(chan-&gt;bans[i], ban) == 0)
  83 +           if (stricmp(chan-&gt;bans[i], ban) == 0) {
  84 +               if (debug)
  85 +                   log(&quot;... found!&quot;);
  86                 return i;
  87 +           }
  88         }
  89      }
  90 +    if (debug)
  91 +       log(&quot;... NOT found&quot;);
  92      return -1;
  93  }
  94
  95 </PRE>
  96
  97
  98
  99 <!--endarticle-->
 100     <HR>
 101     <P><UL>
 102         <!--threads-->
 103         <LI>Previous message: <A HREF="005040.html">[IRCServices] akick not setting channel ban
 104 </A></li>
 105         <LI>Next message: <A HREF="005042.html">[IRCServices] akick not setting channel ban
 106 </A></li>
 107          <LI> <B>Messages sorted by:</B>
 108               <a href="date.html#5041">[ date ]</a>
 109               <a href="thread.html#5041">[ thread ]</a>
 110               <a href="subject.html#5041">[ subject ]</a>
 111               <a href="author.html#5041">[ author ]</a>
 112          </LI>
 113        </UL>
 114
 115 </body></html>