software/RELEASES/ircservices/achurch.org/services/lists/ircservices/2005/004959.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] problem with /cs unban
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20problem%20with%20/cs%20unban&In-Reply-To=42796fd4.43116%40msgid.achurch.org">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="004958.html">
  11    <LINK REL="Next"  HREF="004942.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] problem with /cs unban</H1>
  15     <B>Craig Edwards</B>
  16     <A HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20problem%20with%20/cs%20unban&In-Reply-To=42796fd4.43116%40msgid.achurch.org"
  17        TITLE="[IRCServices] problem with /cs unban">brain at winbot.co.uk
  18        </A><BR>
  19     <I>Wed May  4 18:21:09 PDT 2005</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="004958.html">[IRCServices] problem with /cs unban
  22 </A></li>
  23         <LI>Next message: <A HREF="004942.html">[IRCServices] NSRequireEmail question
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#4959">[ date ]</a>
  27               <a href="thread.html#4959">[ thread ]</a>
  28               <a href="subject.html#4959">[ subject ]</a>
  29               <a href="author.html#4959">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>the bug was in my own code, i havent had chance to reply
  35
  36 thanks for your time and sorry for wasting it :p
  37
  38 Brain
  39
  40 Andrew Church wrote:
  41 &gt;&gt;<i>Ive found a problem with how ircservices matches bans for /cs unban.
  42 </I>&gt;&gt;<i>Whilst writing a protocol module i noticed that if a protocol module
  43 </I>&gt;&gt;<i>supplies ip addresses for connecting users, ALL channel bans will be
  44 </I>&gt;&gt;<i>checked against user-&gt;ip, not user-&gt;fakehost or user-&gt;host! This means
  45 </I>&gt;&gt;<i>that the ban just outright fails. This is a pretty old version (5.0.41)
  46 </I>&gt;&gt;<i>- has it since been fixed?
  47 </I>&gt;<i>
  48 </I>&gt;<i>
  49 </I>&gt;<i>      I can't see that such a bug was ever there; the code first checks
  50 </I>&gt;<i> against the host and fakehost regardless of protocol, then checks the IP
  51 </I>&gt;<i> address if the protocol supplies it.
  52 </I>&gt;<i>
  53 </I>&gt;<i>   --Andrew Church
  54 </I>&gt;<i>     <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
  55 </I>&gt;<i>     <A HREF="http://achurch.org/">http://achurch.org/</A>
  56 </I>&gt;<i> ------------------------------------------------------------------
  57 </I>&gt;<i> To unsubscribe or change your subscription options, visit:
  58 </I>&gt;<i> <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">http://lists.ircservices.za.net/mailman/listinfo/ircservices</A>
  59 </I>&gt;<i>
  60 </I>&gt;<i>
  61 </I>
  62 --
  63 WinBot IRC client developer: <A HREF="http://www.winbot.co.uk">http://www.winbot.co.uk</A>
  64 ChatSpike - The users network: <A HREF="http://www.chatspike.net">http://www.chatspike.net</A>
  65 InspIRCd - Modular IRC server: <A HREF="http://www.inspircd.org">http://www.inspircd.org</A>
  66 Online RPG Developer: <A HREF="http://www.ssod.org">http://www.ssod.org</A>
  67 --
  68 </PRE>
  69
  70
  71 <!--endarticle-->
  72     <HR>
  73     <P><UL>
  74         <!--threads-->
  75         <LI>Previous message: <A HREF="004958.html">[IRCServices] problem with /cs unban
  76 </A></li>
  77         <LI>Next message: <A HREF="004942.html">[IRCServices] NSRequireEmail question
  78 </A></li>
  79          <LI> <B>Messages sorted by:</B>
  80               <a href="date.html#4959">[ date ]</a>
  81               <a href="thread.html#4959">[ thread ]</a>
  82               <a href="subject.html#4959">[ subject ]</a>
  83               <a href="author.html#4959">[ author ]</a>
  84          </LI>
  85        </UL>
  86
  87 </body></html>