software/RELEASES/ircservices/achurch.org/services/lists/ircservices/2005/004917.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] Bug in NickServ listlinks
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20Bug%20in%20NickServ%20listlinks&In-Reply-To=42484222.3070707%40frostycoolslug.com">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="004916.html">
  11    <LINK REL="Next"  HREF="004920.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] Bug in NickServ listlinks</H1>
  15     <B>Craig McLure</B>
  16     <A HREF="mailto:ircservices%40ircservices.esper.net?Subject=%5BIRCServices%5D%20Bug%20in%20NickServ%20listlinks&In-Reply-To=42484222.3070707%40frostycoolslug.com"
  17        TITLE="[IRCServices] Bug in NickServ listlinks">Craig at frostycoolslug.com
  18        </A><BR>
  19     <I>Mon Mar 28 10:09:30 PST 2005</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="004916.html">[IRCServices] Bug in NickServ listlinks
  22 </A></li>
  23         <LI>Next message: <A HREF="004920.html">[IRCServices] Bug in NickServ listlinks
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#4917">[ date ]</a>
  27               <a href="thread.html#4917">[ thread ]</a>
  28               <a href="subject.html#4917">[ subject ]</a>
  29               <a href="author.html#4917">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>My mistake, the code went in the wrong place..
  35
  36 Find the Section:
  37
  38 -- Code Snippit (Line 208) --
  39          if (!(ni = u-&gt;ni) || !(ngi = u-&gt;ngi) || ngi ==
  40 NICKGROUPINFO_INVALID) {
  41              notice_lang(s_NickServ, u, NICK_NOT_REGISTERED);
  42              return;
  43          }
  44 -- Code Snippit --
  45
  46 And replace it with:
  47
  48 -- Code Snippit --
  49          if (!(ni = u-&gt;ni) || !(ngi = u-&gt;ngi) || ngi ==
  50 NICKGROUPINFO_INVALID) {
  51              notice_lang(s_NickServ, u, NICK_NOT_REGISTERED);
  52              return;
  53          } else if (!user_identified(u)) {
  54              notice_lang(s_NickServ, u, NICK_IDENTIFY_REQUIRED, s_NickServ);
  55              return;
  56          }
  57
  58 -- End Code Snippit --
  59
  60 and remove the text on line 197
  61
  62 My appoligies for the mixup.
  63
  64 --
  65 With this new fix in place, if a user attempts to /ns listlinks they get:
  66
  67 (19:04:37)  &#8250;&#8250; [ NickServ (<A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">services at chatspike.net</A>) ] Password
  68 authentication required for that command.
  69 (19:04:37)  &#8250;&#8250; [ NickServ (<A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">services at chatspike.net</A>) ] Retry after typing
  70 /msg NickServ IDENTIFY password.
  71
  72 (I have an annoying habit of not testing code before submitting it :/)
  73
  74 Sorry again.
  75
  76
  77 /****************************************
  78   *     Craig &quot;FrostyCoolSlug&quot; McLure
  79   *       <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">Craig at FrostyCoolSlug.com</A>
  80   * InspIRCd   - <A HREF="http://www.inspircd.org">http://www.inspircd.org</A>
  81   * ChatSpike  - <A HREF="http://www.chatspike.net">http://www.chatspike.net</A>
  82   ****************************************/
  83
  84 Craig McLure wrote:
  85 &gt;<i> Well spotted, If your looking for an immediate fix, find
  86 </I>&gt;<i> ircservices-5.0.xx/modules/nickserv/link.c
  87 </I>&gt;<i>
  88 </I>&gt;<i> and add the following at line 197
  89 </I>&gt;<i>
  90 </I>&gt;<i> --- CODE SNIPPIT ---
  91 </I>&gt;<i>     } else if (!user_identified(u)) {
  92 </I>&gt;<i>         notice_lang(s_NickServ, u, NICK_IDENTIFY_REQUIRED, s_NickServ);
  93 </I>&gt;<i>         return;
  94 </I>&gt;<i>
  95 </I>&gt;<i> --- END CODE SNIPPIT ---
  96 </I>&gt;<i>
  97 </I>&gt;<i> (You should be able to paste all that, including the line break into
  98 </I>&gt;<i> like 197, and everything will fall into alignment)
  99 </I>&gt;<i>
 100 </I>&gt;<i> I'm sure andy will include this fix in the next release of services :)
 101 </I>&gt;<i> /****************************************
 102 </I>&gt;<i>  *     Craig &quot;FrostyCoolSlug&quot; McLure
 103 </I>&gt;<i>  *       <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">Craig at FrostyCoolSlug.com</A>
 104 </I>&gt;<i>  * InspIRCd   - <A HREF="http://www.inspircd.org">http://www.inspircd.org</A>
 105 </I>&gt;<i>  * ChatSpike  - <A HREF="http://www.chatspike.net">http://www.chatspike.net</A>
 106 </I>&gt;<i>  ****************************************/
 107 </I>&gt;<i>
 108 </I>&gt;<i> Katarn wrote:
 109 </I>&gt;<i>
 110 </I>&gt;&gt;<i> Hi,
 111 </I>&gt;&gt;<i>
 112 </I>&gt;&gt;<i> It was brought to my attention by a user the other day, that NickServ's
 113 </I>&gt;&gt;<i> listlinks feature works for any nickname, without identifying for the
 114 </I>&gt;&gt;<i> nick. By default, only services operators or above are supposed to be
 115 </I>&gt;&gt;<i> able
 116 </I>&gt;&gt;<i> to do this I believe.
 117 </I>&gt;&gt;<i> Basically, any person can come on with any nick that they want to see all
 118 </I>&gt;&gt;<i> the linked nicks for, and use &quot;/msg nickserv listlinks&quot; to see all the
 119 </I>&gt;&gt;<i> nicknames linked to that nick, if they have not identified at all.
 120 </I>&gt;&gt;<i> -Katarn
 121 </I>&gt;&gt;<i>
 122 </I>&gt;&gt;<i>
 123 </I>&gt;&gt;<i> ------------------------------------------------------------------
 124 </I>&gt;&gt;<i> To unsubscribe or change your subscription options, visit:
 125 </I>&gt;&gt;<i> <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">http://lists.ircservices.za.net/mailman/listinfo/ircservices</A>
 126 </I>&gt;&gt;<i>
 127 </I>&gt;&gt;<i>
 128 </I>&gt;<i>
 129 </I>&gt;<i> ------------------------------------------------------------------
 130 </I>&gt;<i> To unsubscribe or change your subscription options, visit:
 131 </I>&gt;<i> <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices">http://lists.ircservices.za.net/mailman/listinfo/ircservices</A>
 132 </I>&gt;<i>
 133 </I>&gt;<i>
 134 </I>
 135 </PRE>
 136
 137
 138
 139
 140
 141
 142
 143
 144
 145 <!--endarticle-->
 146     <HR>
 147     <P><UL>
 148         <!--threads-->
 149         <LI>Previous message: <A HREF="004916.html">[IRCServices] Bug in NickServ listlinks
 150 </A></li>
 151         <LI>Next message: <A HREF="004920.html">[IRCServices] Bug in NickServ listlinks
 152 </A></li>
 153          <LI> <B>Messages sorted by:</B>
 154               <a href="date.html#4917">[ date ]</a>
 155               <a href="thread.html#4917">[ thread ]</a>
 156               <a href="subject.html#4917">[ subject ]</a>
 157               <a href="author.html#4917">[ author ]</a>
 158          </LI>
 159        </UL>
 160
 161 </body></html>