software/RELEASES/ircservices/achurch.org/services/lists/ircservices/2000/000683.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices] patch
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20patch&In-Reply-To=">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="000682.html">
  11    <LINK REL="Next"  HREF="000685.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices] patch</H1>
  15     <B>Mircea Damian</B>
  16     <A HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20patch&In-Reply-To="
  17        TITLE="[IRCServices] patch">dmircea at linux.kappa.ro
  18        </A><BR>
  19     <I>Sat Aug 12 07:18:19 PDT 2000</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="000682.html">[IRCServices] running the services
  22 </A></li>
  23         <LI>Next message: <A HREF="000685.html">[IRCServices] patch
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#683">[ date ]</a>
  27               <a href="thread.html#683">[ thread ]</a>
  28               <a href="subject.html#683">[ subject ]</a>
  29               <a href="author.html#683">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>Hello,
  35
  36 Here is a small patch against the latest version of ircservices (4.4.5)
  37 which fixes two things:
  38
  39 - password encryption when compiled with gcc-2.7.2.x: the problem is that
  40   the buffers need to be initialized to 0 and by default they are full of
  41   garbage
  42
  43 - fix a possible smalloc(0) in sessions.c when it reads the exceptions
  44   which is possible to be an empty =&gt; nexceptions = 0 =&gt; smalloc(0);
  45   obviuous solution was to move smalloc after the check
  46
  47
  48 diff -r -u ircservices-4.4.5-clean/encrypt.c ircservices-4.4.5/encrypt.c
  49 --- ircservices-4.4.5-clean/encrypt.c   Sat Jan 29 07:17:51 2000
  50 +++ ircservices-4.4.5/encrypt.c Wed Aug  9 17:35:48 2000
  51 @@ -356,6 +356,11 @@
  52
  53      if (size &lt; 16)
  54         return -1;
  55 +
  56 +    memset(&amp;context, 0, sizeof(context));
  57 +    memset(&amp;digest, 0, sizeof(digest));
  58 +
  59 +
  60      MD5Init(&amp;context);
  61      MD5Update(&amp;context, src, len);
  62      MD5Final(digest, &amp;context);
  63 diff -r -u ircservices-4.4.5-clean/sessions.c ircservices-4.4.5/sessions.c
  64 --- ircservices-4.4.5-clean/sessions.c  Wed Mar 15 09:15:01 2000
  65 +++ ircservices-4.4.5/sessions.c        Wed Aug  9 17:30:22 2000
  66 @@ -381,11 +381,11 @@
  67        case 7:
  68          SAFE(read_int16(&amp;n, f));
  69          nexceptions = n;
  70 -        exceptions = smalloc(sizeof(Exception) * nexceptions);
  71          if (!nexceptions) {
  72              close_db(f);
  73              return;
  74          }
  75 +        exceptions = smalloc(sizeof(Exception) * nexceptions);
  76          for (i = 0; i &lt; nexceptions; i++) {
  77              SAFE(read_string(&amp;exceptions[i].mask, f));
  78              SAFE(read_int16(&amp;tmp16, f));
  79
  80 --
  81 Mircea Damian
  82 E-mails: <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">dmircea at kappa.ro</A>, <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">dmircea at roedu.net</A>
  83 WebPage: <A HREF="http://taz.mania.k.ro/~dmircea/">http://taz.mania.k.ro/~dmircea/</A>
  84
  85 ---------------------------------------------------------------
  86 To unsubscribe, send email to <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">majordomo at ender.shadowfire.org</A>
  87 with &quot;unsubscribe ircservices&quot; in the body, without the quotes.
  88
  89
  90 </PRE>
  91
  92 <!--endarticle-->
  93     <HR>
  94     <P><UL>
  95         <!--threads-->
  96         <LI>Previous message: <A HREF="000682.html">[IRCServices] running the services
  97 </A></li>
  98         <LI>Next message: <A HREF="000685.html">[IRCServices] patch
  99 </A></li>
 100          <LI> <B>Messages sorted by:</B>
 101               <a href="date.html#683">[ date ]</a>
 102               <a href="thread.html#683">[ thread ]</a>
 103               <a href="subject.html#683">[ subject ]</a>
 104               <a href="author.html#683">[ author ]</a>
 105          </LI>
 106        </UL>
 107
 108 </body></html>