software/RELEASES/ircservices/achurch.org/services/lists/ircservices-coding/2008/003326.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices Coding] [IRCServices] akick not setting channel ban
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices-coding%40ircservices.za.net?Subject=%5BIRCServices%20Coding%5D%20%5BIRCServices%5D%20akick%20not%20setting%20channel%20ban&In-Reply-To=20081125115253.GB2825%40phat.za.net">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="003325.html">
  11    <LINK REL="Next"  HREF="003328.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices Coding] [IRCServices] akick not setting channel ban</H1>
  15     <B>Aragon Gouveia</B>
  16     <A HREF="mailto:ircservices-coding%40ircservices.za.net?Subject=%5BIRCServices%20Coding%5D%20%5BIRCServices%5D%20akick%20not%20setting%20channel%20ban&In-Reply-To=20081125115253.GB2825%40phat.za.net"
  17        TITLE="[IRCServices Coding] [IRCServices] akick not setting channel ban">aragon at phat.za.net
  18        </A><BR>
  19     <I>Tue Nov 25 12:59:27 PST 2008</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="003325.html">[IRCServices Coding] [IRCServices] akick not setting channel ban
  22 </A></li>
  23         <LI>Next message: <A HREF="003328.html">[IRCServices Coding] [IRCServices] akick not setting channel ban
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#3326">[ date ]</a>
  27               <a href="thread.html#3326">[ thread ]</a>
  28               <a href="subject.html#3326">[ subject ]</a>
  29               <a href="author.html#3326">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>|<i> By Aragon Gouveia &lt;<A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices-coding">aragon at phat.za.net</A>&gt;
  35 </I>|<i>                                          [ 2008-11-25 14:10 +0200 ]
  36 </I>&gt;<i> So I've changed do_cmode:
  37 </I>&gt;<i>
  38 </I>&gt;<i> case 'b':
  39 </I>&gt;<i> if (add) {
  40 </I>&gt;<i>     int i = find_ban(chan, av[0]);
  41 </I>&gt;<i>     if (i == -1) {
  42 </I>&gt;<i>             ARRAY_EXTEND(chan-&gt;bans);
  43 </I>&gt;<i>             chan-&gt;bans[chan-&gt;bans_count-1] = sstrdup(av[0]);
  44 </I>&gt;<i>     }
  45 </I>&gt;<i>
  46 </I>&gt;<i>
  47 </I>&gt;<i> Which I've tested with some oper assisted relinking and things look much
  48 </I>&gt;<i> better now.  I believe 5.1's do_cmode will cause the same problems (it looks
  49 </I>&gt;<i> the same as 5.0's).
  50 </I>
  51 Below is a diff against 5.1.13 that I reworked a little better than above.
  52 Not sure if the extra logging is desirable, and I'm assuming do_cmode() and
  53 find_ban() work the same in 5.1. :)
  54
  55
  56 Regards,
  57 Aragon
  58
  59
  60
  61 --- channels.c.orig     Tue Nov 25 22:48:24 2008
  62 +++ channels.c  Tue Nov 25 22:53:56 2008
  63 @@ -360,11 +360,16 @@
  64                  break;
  65
  66                case 'b':
  67 +                int i = find_ban(chan, av[0]);
  68                  if (add) {
  69 -                    ARRAY_EXTEND(chan-&gt;bans);
  70 -                    chan-&gt;bans[chan-&gt;bans_count-1] = sstrdup(av[0]);
  71 +                    if (i == -1) {
  72 +                        ARRAY_EXTEND(chan-&gt;bans);
  73 +                        chan-&gt;bans[chan-&gt;bans_count-1] = sstrdup(av[0]);
  74 +                    } else {
  75 +                        log(&quot;channel: MODE %s +b %s: ban already exists&quot;,
  76 +                            chan-&gt;name, *av);
  77 +                    }
  78                  } else {
  79 -                    int i = find_ban(chan, av[0]);
  80                      if (i &gt;= 0) {
  81                          free(chan-&gt;bans[i]);
  82                          ARRAY_REMOVE(chan-&gt;bans, i);
  83 </PRE>
  84
  85
  86
  87 <!--endarticle-->
  88     <HR>
  89     <P><UL>
  90         <!--threads-->
  91         <LI>Previous message: <A HREF="003325.html">[IRCServices Coding] [IRCServices] akick not setting channel ban
  92 </A></li>
  93         <LI>Next message: <A HREF="003328.html">[IRCServices Coding] [IRCServices] akick not setting channel ban
  94 </A></li>
  95          <LI> <B>Messages sorted by:</B>
  96               <a href="date.html#3326">[ date ]</a>
  97               <a href="thread.html#3326">[ thread ]</a>
  98               <a href="subject.html#3326">[ subject ]</a>
  99               <a href="author.html#3326">[ author ]</a>
 100          </LI>
 101        </UL>
 102
 103 </body></html>