software/RELEASES/ircservices/achurch.org/services/lists/ircservices-coding/2006/003236.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> Debug patch (Re: [IRCServices Coding] SET RESTRICTED,
   5         and possibly AKICK flaw)
   6    </TITLE>
   7    <LINK REL="Index" HREF="index.html" >
   8    <LINK REL="made" HREF="mailto:ircservices-coding%40ircservices.esper.net?Subject=Debug%20patch%20%28Re%3A%20%5BIRCServices%20Coding%5D%20SET%20RESTRICTED%2C%0A%09and%20possibly%20AKICK%20flaw%29&In-Reply-To=4419C864.9090309%40gmail.com">
   9    <META NAME="robots" CONTENT="index,nofollow">
  10    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  11    <LINK REL="Previous"  HREF="003240.html">
  12    <LINK REL="Next"  HREF="003241.html">
  13  </HEAD>
  14  <BODY BGCOLOR="#ffffff">
  15    <H1>Debug patch (Re: [IRCServices Coding] SET RESTRICTED,
  16         and possibly AKICK flaw)</H1>
  17     <B>Andrew Church</B>
  18     <A HREF="mailto:ircservices-coding%40ircservices.esper.net?Subject=Debug%20patch%20%28Re%3A%20%5BIRCServices%20Coding%5D%20SET%20RESTRICTED%2C%0A%09and%20possibly%20AKICK%20flaw%29&In-Reply-To=4419C864.9090309%40gmail.com"
  19        TITLE="Debug patch (Re: [IRCServices Coding] SET RESTRICTED,
  20         and possibly AKICK flaw)">achurch at achurch.org
  21        </A><BR>
  22     <I>Sun Mar 19 17:47:59 PST 2006</I>
  23     <P><UL>
  24         <LI>Previous message: <A HREF="003240.html">[IRCServices Coding] SET RESTRICTED, and possibly AKICK flaw
  25 </A></li>
  26         <LI>Next message: <A HREF="003241.html">[IRCServices Coding] Re: GLOBOPS error on server and services
  27 </A></li>
  28          <LI> <B>Messages sorted by:</B>
  29               <a href="date.html#3236">[ date ]</a>
  30               <a href="thread.html#3236">[ thread ]</a>
  31               <a href="subject.html#3236">[ subject ]</a>
  32               <a href="author.html#3236">[ author ]</a>
  33          </LI>
  34        </UL>
  35     <HR>
  36 <!--beginarticle-->
  37 <PRE>     With regard to the AKICK issue, if someone could apply the patch below
  38 to modules/chanserv/check.c and post the debug log messages generated when
  39 the problem occurs, I'd appreciate it.
  40
  41   --Andrew Church
  42     <A HREF="http://lists.ircservices.za.net/mailman/listinfo/ircservices-coding">achurch at achurch.org</A>
  43     <A HREF="http://achurch.org/">http://achurch.org/</A>
  44
  45 ---------------------------------------------------------------------------
  46
  47 Index: modules/chanserv/check.c
  48 ===================================================================
  49 RCS file: /var/local/cvsroot/ircservices/modules/chanserv/check.c,v
  50 retrieving revision 2.59.2.8
  51 diff -u -r2.59.2.8 check.c
  52 --- modules/chanserv/check.c    8 Jan 2006 16:48:13 -0000       2.59.2.8
  53 +++ modules/chanserv/check.c    19 Mar 2006 08:50:18 -0000
  54 @@ -410,6 +410,8 @@
  55         clear_channel(c, CLEAR_EXCEPTS, user);
  56      /* Apparently invites can get around bans, so check for ban first */
  57      if (!chan_has_ban(chan, mask)) {
  58 +       module_log(&quot;[DEBUG] check_kick: adding ban [%s] to channel [%s]&quot;
  59 +                  &quot; for nick [%s]&quot;, mask, chan, user-&gt;nick);
  60         send_cmode_cmd(s_ChanServ, chan, &quot;+b %s&quot;, mask);
  61         if (c) {
  62             char *av[3];
  63 @@ -418,6 +420,21 @@
  64             av[2] = mask;
  65             do_cmode(s_ChanServ, 3, av);
  66         }
  67 +    } else {
  68 +       module_log(&quot;[DEBUG] check_kick: NOT adding ban [%s] to channel [%s]&quot;
  69 +                  &quot; for user [%s]&quot;, mask, chan, user-&gt;nick);
  70 +       module_log(&quot;[DEBUG]    ban list:&quot;);
  71 +       if (c) {
  72 +           int i;
  73 +           ARRAY_FOREACH (i, c-&gt;bans)
  74 +               module_log(&quot;[DEBUG]       %s&quot;, c-&gt;bans[i]);
  75 +       }
  76 +       module_log(&quot;[DEBUG]    exception list:&quot;);
  77 +       if (c) {
  78 +           int i;
  79 +           ARRAY_FOREACH (i, c-&gt;excepts)
  80 +               module_log(&quot;[DEBUG]       %s&quot;, c-&gt;bans[i]);
  81 +       }
  82      }
  83      free(mask);
  84      send_channel_cmd(s_ChanServ, &quot;KICK %s %s :%s&quot;, chan, user-&gt;nick, reason);
  85 </PRE>
  86
  87
  88
  89
  90
  91
  92 <!--endarticle-->
  93     <HR>
  94     <P><UL>
  95         <!--threads-->
  96         <LI>Previous message: <A HREF="003240.html">[IRCServices Coding] SET RESTRICTED, and possibly AKICK flaw
  97 </A></li>
  98         <LI>Next message: <A HREF="003241.html">[IRCServices Coding] Re: GLOBOPS error on server and services
  99 </A></li>
 100          <LI> <B>Messages sorted by:</B>
 101               <a href="date.html#3236">[ date ]</a>
 102               <a href="thread.html#3236">[ thread ]</a>
 103               <a href="subject.html#3236">[ subject ]</a>
 104               <a href="author.html#3236">[ author ]</a>
 105          </LI>
 106        </UL>
 107
 108 </body></html>