software/RELEASES/ircservices/achurch.org/services/lists/ircservices-coding/2001/000074.html

   1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
   2 <HTML>
   3  <HEAD>
   4    <TITLE> [IRCServices Coding] A bug i think...
   5    </TITLE>
   6    <LINK REL="Index" HREF="index.html" >
   7    <LINK REL="made" HREF="mailto:ircservices-coding%40ircservices.za.net?Subject=%5BIRCServices%20Coding%5D%20A%20bug%20i%20think...&In-Reply-To=">
   8    <META NAME="robots" CONTENT="index,nofollow">
   9    <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
  10    <LINK REL="Previous"  HREF="000069.html">
  11    <LINK REL="Next"  HREF="000075.html">
  12  </HEAD>
  13  <BODY BGCOLOR="#ffffff">
  14    <H1>[IRCServices Coding] A bug i think...</H1>
  15     <B>Andrew Church</B>
  16     <A HREF="mailto:ircservices-coding%40ircservices.za.net?Subject=%5BIRCServices%20Coding%5D%20A%20bug%20i%20think...&In-Reply-To="
  17        TITLE="[IRCServices Coding] A bug i think...">achurch at achurch.org
  18        </A><BR>
  19     <I>Wed Dec 26 10:30:20 PST 2001</I>
  20     <P><UL>
  21         <LI>Previous message: <A HREF="000069.html">[IRCServices Coding] Services 5.0 alpha 9 released
  22 </A></li>
  23         <LI>Next message: <A HREF="000075.html">[IRCServices Coding] Services 5.0 alpha 9 released
  24 </A></li>
  25          <LI> <B>Messages sorted by:</B>
  26               <a href="date.html#74">[ date ]</a>
  27               <a href="thread.html#74">[ thread ]</a>
  28               <a href="subject.html#74">[ subject ]</a>
  29               <a href="author.html#74">[ author ]</a>
  30          </LI>
  31        </UL>
  32     <HR>
  33 <!--beginarticle-->
  34 <PRE>&gt;<i>I was playing with alpha8 last night, and discovered this and wasn't
  35 </I>&gt;<i>quite sure if it is whats supposed to happen.  The session limit was
  36 </I>&gt;<i>set two 3 and i had one client loaded, Ron885, and the other one
  37 </I>&gt;<i>connecting, Ron885_...
  38 </I>[...]
  39 &gt;<i>it seems as if the session list gets messed up... because afterwards i
  40 </I>&gt;<i>had one client connected and did /os session view and it said 3 of 3
  41 </I>&gt;<i>when there was only one connected...
  42 </I>
  43      This is because the session/exception callback gets called before the
  44 S-line one, leaving &quot;ghost&quot; users in the session count.  Fixed, thanks.
  45 Patch is as follows (not tested):
  46
  47 --- modules/operserv/sessions.c 24 Dec 2001 13:20:09 -0000      2.30
  48 +++ modules/operserv/sessions.c 26 Dec 2001 01:27:15 -0000
  49 @@ -728,7 +728,13 @@
  50         return 0;
  51      }
  52
  53 -    if (!add_callback(NULL, &quot;user check&quot;, check_sessions)
  54 +    /* Add user check callback at priority -10 so it runs after all the
  55 +     * autokill/S-line/whatever checks (otherwise we get users added to
  56 +     * sessions and then killed by S-lines, leaving the session count
  57 +     * jacked up).  FIXME: we really really need to document places where
  58 +     * we use callback priorities.
  59 +     */
  60 +    if (!add_callback_pri(NULL, &quot;user check&quot;, check_sessions, -10)
  61       || !add_callback(NULL, &quot;user delete&quot;, remove_session)
  62       || !add_callback(NULL, &quot;save data&quot;, do_save_data)
  63       || !add_callback(NULL, &quot;expire&quot;, expire_exceptions)
  64
  65   --Andrew Church
  66     <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices-coding">achurch at achurch.org</A>
  67     <A HREF="http://achurch.org/">http://achurch.org/</A>
  68
  69 </PRE>
  70
  71 <!--endarticle-->
  72     <HR>
  73     <P><UL>
  74         <!--threads-->
  75         <LI>Previous message: <A HREF="000069.html">[IRCServices Coding] Services 5.0 alpha 9 released
  76 </A></li>
  77         <LI>Next message: <A HREF="000075.html">[IRCServices Coding] Services 5.0 alpha 9 released
  78 </A></li>
  79          <LI> <B>Messages sorted by:</B>
  80               <a href="date.html#74">[ date ]</a>
  81               <a href="thread.html#74">[ thread ]</a>
  82               <a href="subject.html#74">[ subject ]</a>
  83               <a href="author.html#74">[ author ]</a>
  84          </LI>
  85        </UL>
  86
  87 </body></html>