[irc.git] / software / RELEASES / ircservices / achurch.org / services / lists / ircservices / 2001 / 002167.html

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
 <HEAD>
   <TITLE> [IRCServices] A ilttle suggestion for set mlock
   </TITLE>
   <LINK REL="Index" HREF="index.html" >
   <LINK REL="made" HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20A%20ilttle%20suggestion%20for%20set%20mlock&In-Reply-To=3b6b51e5.14331%40achurch.org">
   <META NAME="robots" CONTENT="index,nofollow">
   <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
   <LINK REL="Previous"  HREF="002166.html">
   <LINK REL="Next"  HREF="002168.html">
 </HEAD>
 <BODY BGCOLOR="#ffffff">
   <H1>[IRCServices] A ilttle suggestion for set mlock</H1>
    <B>Ekim Engin</B> 
    <A HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20A%20ilttle%20suggestion%20for%20set%20mlock&In-Reply-To=3b6b51e5.14331%40achurch.org"
       TITLE="[IRCServices] A ilttle suggestion for set mlock">EEngin at t-online.de
       </A><BR>
    <I>Sat Aug  4 05:05:00 PDT 2001</I>
    <P><UL>
        <LI>Previous message: <A HREF="002166.html">[IRCServices] A ilttle suggestion for set mlock
</A></li>
        <LI>Next message: <A HREF="002168.html">[IRCServices] A ilttle suggestion for set mlock
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#2167">[ date ]</a>
              <a href="thread.html#2167">[ thread ]</a>
              <a href="subject.html#2167">[ subject ]</a>
              <a href="author.html#2167">[ author ]</a>
         </LI>
       </UL>
    <HR>  
<!--beginarticle-->
<PRE>Hi again, 
well i am not quite sure if this really is that confusing. I am
compleatly against changing the current behavior due to backwards (and
thus script) compatibility. But as s.o. using services myself, and
having enough ppl. on #help channels ask about this. I found out, that a
modify function is quite easier to explain to them as letting them do an
ns info (or doing it myself) and explainng that they have to take this
modes
And modfiy them theirselfs. IRC has become a plave where memorizing
isused to learn things, not understanding or thinking :( ))

Well i am using the following simple function change myself:

--- snip chanserv.c - line: 1943 ---
static void do_set_mlock(User *u, ChannelInfo *ci, char *param)
{
    char *s, modebuf[32], *end, c;
    int add = -1;	/* 1 if adding, 0 if deleting, -1 if neither */
    int32 newlock_on = 0, newlock_off = 0, newlock_limit = 0;
    char *newlock_key = NULL;

    while (*param) {
	if (*param != '+' &amp;&amp; *param != '-' &amp;&amp; *param != '=' &amp;&amp; add &lt; 0)
{
	    param++;
	    continue;
	}
	switch ((c = *param++)) {
	  case '+':
	    add = 1;
	    break;
	  case '-':
	    add = 0;
	    break;
        case '=': 
	    if (add == -1) {
		newlock_on = ci-&gt;mlock_on;
		newlock_off = ci-&gt;mlock_off;
	    }
          break;
    	  case 'k':
--- snip ---

This fullfils my needs for using = to modify and +,- as usual to set the
modes..
But sure its up to you...

Greets
Ekim

---
Chat begins as it ends - without reason 

&gt;<i> -----Original Message-----
</I>&gt;<i> From: <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">ircservices-admin at ircservices.za.net</A> 
</I>&gt;<i> [mailto:<A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">ircservices-admin at ircservices.za.net</A>] On Behalf Of 
</I>&gt;<i> Andrew Church
</I>&gt;<i> Sent: Saturday, August 04, 2001 3:33 AM
</I>&gt;<i> To: <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">ircservices at ircservices.za.net</A>
</I>&gt;<i> Subject: Re: [IRCServices] A ilttle suggestion for set mlock
</I>&gt;<i> 
</I>&gt;<i> 
</I>&gt;<i>      This is something I've been thinking about for a while, 
</I>&gt;<i> but my major concern is that it will be too confusing for the 
</I>&gt;<i> users.  Particularly seeing as the MLOCK command isn't really 
</I>&gt;<i> used that often, it seems simpler and more easily 
</I>&gt;<i> understandable to me to just have a &quot;set&quot; command and not a 
</I>&gt;<i> &quot;modify&quot; command as well.  And I have to say the &quot;=&quot; proposal 
</I>&gt;<i> isn't very intuitive either... if anything, I'd want = to be 
</I>&gt;<i> for setting, and no &quot;=&quot; to mean changing, but that doesn't 
</I>&gt;<i> solve the original problem of the confusingness of having 
</I>&gt;<i> both ways, plus it raises additional problems by changing 
</I>&gt;<i> established practice.
</I>&gt;<i> 
</I>&gt;<i>   --Andrew Church
</I>&gt;<i>     <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
</I>&gt;<i>     <A HREF="http://achurch.org/">http://achurch.org/</A>
</I>&gt;<i>  
</I>

</PRE>

<!--endarticle-->
    <HR>
    <P><UL>
        <!--threads-->
	<LI>Previous message: <A HREF="002166.html">[IRCServices] A ilttle suggestion for set mlock
</A></li>
	<LI>Next message: <A HREF="002168.html">[IRCServices] A ilttle suggestion for set mlock
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#2167">[ date ]</a>
              <a href="thread.html#2167">[ thread ]</a>
              <a href="subject.html#2167">[ subject ]</a>
              <a href="author.html#2167">[ author ]</a>
         </LI>
       </UL>

</body></html>
Commit	Line	Data
3bd189cb JR	1	<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
	2	<HTML>
	3	<HEAD>
	4	<TITLE> [IRCServices] A ilttle suggestion for set mlock
	5	</TITLE>
	6	<LINK REL="Index" HREF="index.html" >
	7	<LINK REL="made" HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20A%20ilttle%20suggestion%20for%20set%20mlock&In-Reply-To=3b6b51e5.14331%40achurch.org">
	8	<META NAME="robots" CONTENT="index,nofollow">
	9	<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
	10	<LINK REL="Previous" HREF="002166.html">
	11	<LINK REL="Next" HREF="002168.html">
	12	</HEAD>
	13	<BODY BGCOLOR="#ffffff">
	14	<H1>[IRCServices] A ilttle suggestion for set mlock</H1>
	15	<B>Ekim Engin</B>
	16	<A HREF="mailto:ircservices%40ircservices.za.net?Subject=%5BIRCServices%5D%20A%20ilttle%20suggestion%20for%20set%20mlock&In-Reply-To=3b6b51e5.14331%40achurch.org"
	17	TITLE="[IRCServices] A ilttle suggestion for set mlock">EEngin at t-online.de
	18	</A><BR>
	19	<I>Sat Aug 4 05:05:00 PDT 2001</I>
	20	<P><UL>
	21	<LI>Previous message: <A HREF="002166.html">[IRCServices] A ilttle suggestion for set mlock
	22	</A></li>
	23	<LI>Next message: <A HREF="002168.html">[IRCServices] A ilttle suggestion for set mlock
	24	</A></li>
	25	<LI> <B>Messages sorted by:</B>
	26	<a href="date.html#2167">[ date ]</a>
	27	<a href="thread.html#2167">[ thread ]</a>
	28	<a href="subject.html#2167">[ subject ]</a>
	29	<a href="author.html#2167">[ author ]</a>
	30	</LI>
	31	</UL>
	32	<HR>
	33	<!--beginarticle-->
	34	<PRE>Hi again,
	35	well i am not quite sure if this really is that confusing. I am
	36	compleatly against changing the current behavior due to backwards (and
	37	thus script) compatibility. But as s.o. using services myself, and
	38	having enough ppl. on #help channels ask about this. I found out, that a
	39	modify function is quite easier to explain to them as letting them do an
	40	ns info (or doing it myself) and explainng that they have to take this
	41	modes
	42	And modfiy them theirselfs. IRC has become a plave where memorizing
	43	isused to learn things, not understanding or thinking :( ))
	44
	45	Well i am using the following simple function change myself:
	46
	47	--- snip chanserv.c - line: 1943 ---
	48	static void do_set_mlock(User u, ChannelInfo ci, char *param)
	49	{
	50	char s, modebuf[32], end, c;
	51	int add = -1; /* 1 if adding, 0 if deleting, -1 if neither */
	52	int32 newlock_on = 0, newlock_off = 0, newlock_limit = 0;
	53	char *newlock_key = NULL;
	54
	55	while (*param) {
	56	if (param != '+' && param != '-' && *param != '=' && add < 0)
	57	{
	58	param++;
	59	continue;
	60	}
	61	switch ((c = *param++)) {
	62	case '+':
	63	add = 1;
	64	break;
65	case '-':
66	add = 0;
67	break;
68	case '=':
69	if (add == -1) {
70	newlock_on = ci->mlock_on;
71	newlock_off = ci->mlock_off;
72	}
73	break;
74	case 'k':
75	--- snip ---
76
77	This fullfils my needs for using = to modify and +,- as usual to set the
78	modes..
79	But sure its up to you...
80
81	Greets
82	Ekim
83
84	---
85	Chat begins as it ends - without reason
86
87	><i> -----Original Message-----
88	</I>><i> From: <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">ircservices-admin at ircservices.za.net</A>
89	</I>><i> [mailto:<A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">ircservices-admin at ircservices.za.net</A>] On Behalf Of
90	</I>><i> Andrew Church
91	</I>><i> Sent: Saturday, August 04, 2001 3:33 AM
92	</I>><i> To: <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">ircservices at ircservices.za.net</A>
93	</I>><i> Subject: Re: [IRCServices] A ilttle suggestion for set mlock
94	</I>><i>
95	</I>><i>
96	</I>><i> This is something I've been thinking about for a while,
97	</I>><i> but my major concern is that it will be too confusing for the
98	</I>><i> users. Particularly seeing as the MLOCK command isn't really
99	</I>><i> used that often, it seems simpler and more easily
100	</I>><i> understandable to me to just have a "set" command and not a
101	</I>><i> "modify" command as well. And I have to say the "=" proposal
102	</I>><i> isn't very intuitive either... if anything, I'd want = to be
103	</I>><i> for setting, and no "=" to mean changing, but that doesn't
104	</I>><i> solve the original problem of the confusingness of having
105	</I>><i> both ways, plus it raises additional problems by changing
106	</I>><i> established practice.
107	</I>><i>
108	</I>><i> --Andrew Church
109	</I>><i> <A HREF="http://www.ircservices.za.net/mailman/listinfo/ircservices">achurch at achurch.org</A>
110	</I>><i> <A HREF="http://achurch.org/">http://achurch.org/</A>
111	</I>><i>
112	</I>
113
114	</PRE>
115
116	<!--endarticle-->
117	<HR>
118	<P><UL>
119	<!--threads-->
120	<LI>Previous message: <A HREF="002166.html">[IRCServices] A ilttle suggestion for set mlock
121	</A></li>
122	<LI>Next message: <A HREF="002168.html">[IRCServices] A ilttle suggestion for set mlock
123	</A></li>
124	<LI> <B>Messages sorted by:</B>
125	<a href="date.html#2167">[ date ]</a>
126	<a href="thread.html#2167">[ thread ]</a>
127	<a href="subject.html#2167">[ subject ]</a>
128	<a href="author.html#2167">[ author ]</a>
129	</LI>
130	</UL>
131
132	</body></html>