From: Jaime Marquínez Ferrándiz <redacted>
Date: Fri, 10 Jan 2014 18:39:42 +0000 (+0100)
Subject: [brightcove] The ‘id’ attribute is not always present in the object tag (fixes #2132)
X-Git-Tag: 2021.01.07~12361
X-Git-Url: https://jfr.im/git/yt-dlp.git/commitdiff_plain/db22af36eced51efdd59ad71cb2220382c58817b?ds=sidebyside

[brightcove] The ‘id’ attribute is not always present in the object tag (fixes #2132)

It looks like the ‘flashId’ parameter is not needed.
---

diff --git a/youtube_dl/extractor/brightcove.py b/youtube_dl/extractor/brightcove.py
index 4ba3f7c42..8ac38f4aa 100644
--- a/youtube_dl/extractor/brightcove.py
+++ b/youtube_dl/extractor/brightcove.py
@@ -86,9 +86,9 @@ def _build_brighcove_url(cls, object_str):
 
         object_doc = xml.etree.ElementTree.fromstring(object_str)
         assert 'BrightcoveExperience' in object_doc.attrib['class']
-        params = {'flashID': object_doc.attrib['id'],
-                  'playerID': find_xpath_attr(object_doc, './param', 'name', 'playerID').attrib['value'],
-                  }
+        params = {
+            'playerID': find_xpath_attr(object_doc, './param', 'name', 'playerID').attrib['value'],
+        }
         def find_param(name):
             node = find_xpath_attr(object_doc, './param', 'name', name)
             if node is not None: