From: pukkandan <redacted>
Date: Wed, 24 May 2023 17:35:20 +0000 (+0530)
Subject: [jsinterp] Do not compile regex
X-Git-Tag: 2023.06.21~109
X-Git-Url: https://jfr.im/git/yt-dlp.git/commitdiff_plain/7aeda6cc9e73ada0b0a0b6a6748c66bef63a20a8

[jsinterp] Do not compile regex
---

diff --git a/test/test_jsinterp.py b/test/test_jsinterp.py
index 96274116b..4d44e6efe 100644
--- a/test/test_jsinterp.py
+++ b/test/test_jsinterp.py
@@ -8,7 +8,6 @@
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 import math
-import re
 
 from yt_dlp.jsinterp import JS_Undefined, JSInterpreter
 
@@ -275,7 +274,9 @@ def test_object(self):
 
     def test_regex(self):
         self._test('function f() { let a=/,,[/,913,/](,)}/; }', None)
+        self._test('function f() { let a=/,,[/,913,/](,)}/; return a; }', R'/,,[/,913,/](,)}/0')
 
+        R'''  # We are not compiling regex
         jsi = JSInterpreter('function f() { let a=/,,[/,913,/](,)}/; return a; }')
         self.assertIsInstance(jsi.call_function('f'), re.Pattern)
 
@@ -287,6 +288,7 @@ def test_regex(self):
 
         jsi = JSInterpreter(R'function f() { let a=[/[)\\]/]; return a[0]; }')
         self.assertEqual(jsi.call_function('f').pattern, r'[)\\]')
+        '''
 
     @unittest.skip('Not implemented')
     def test_replace(self):
diff --git a/yt_dlp/jsinterp.py b/yt_dlp/jsinterp.py
index 1ef1f0823..7c7940efd 100644
--- a/yt_dlp/jsinterp.py
+++ b/yt_dlp/jsinterp.py
@@ -352,8 +352,10 @@ def interpret_statement(self, stmt, local_vars, allow_recursion=100):
             inner, outer = self._separate(expr, expr[0], 1)
             if expr[0] == '/':
                 flags, outer = self._regex_flags(outer)
+                # We don't support regex methods yet, so no point compiling it
+                inner = f'{inner}/{flags}'
                 # Avoid https://github.com/python/cpython/issues/74534
-                inner = re.compile(inner[1:].replace('[[', r'[\['), flags=flags)
+                # inner = re.compile(inner[1:].replace('[[', r'[\['), flags=flags)
             else:
                 inner = json.loads(js_to_json(f'{inner}{expr[0]}', strict=True))
             if not outer: