]> jfr.im git - yt-dlp.git/blame - test/test_download.py
[test:download] Raise on network errors (#10283)
[yt-dlp.git] / test / test_download.py
CommitLineData
cc52de43 1#!/usr/bin/env python3
54007a45 2
44a5f171
PH
3# Allow direct execution
4import os
5import sys
6import unittest
f8271158 7
44a5f171
PH
8sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9
ac668111 10
f2e8dbcc 11import collections
ac668111 12import hashlib
13import json
ac668111 14
dd508b7c 15from test.helper import (
0990305d 16 assertGreaterEqual,
060ac762 17 expect_info_dict,
70b7e3fb 18 expect_warnings,
dd508b7c 19 get_params,
ff14fc49 20 gettestcases,
f2e8dbcc 21 getwebpagetestcases,
060ac762 22 is_download_test,
060ac762 23 try_rm,
dd508b7c 24)
54007a45 25
ac668111 26import yt_dlp.YoutubeDL # isort: split
f8271158 27from yt_dlp.extractor import get_info_extractor
227bf1a3 28from yt_dlp.networking.exceptions import HTTPError, TransportError
7a5c1cfe 29from yt_dlp.utils import (
44a5f171
PH
30 DownloadError,
31 ExtractorError,
32 UnavailableVideoError,
661c9a1d 33 YoutubeDLError,
f8271158 34 format_bytes,
f2e8dbcc 35 join_nonempty,
44a5f171 36)
fd5ff020 37
8cc83b8d
FV
38RETRIES = 3
39
5f6a1245 40
7a5c1cfe 41class YoutubeDL(yt_dlp.YoutubeDL):
fd5ff020 42 def __init__(self, *args, **kwargs):
fd5ff020 43 self.to_stderr = self.to_screen
0eaf520d 44 self.processed_info_dicts = []
86e5f3ed 45 super().__init__(*args, **kwargs)
5f6a1245 46
f0500bd1 47 def report_warning(self, message, *args, **kwargs):
be95cac1
FV
48 # Don't accept warnings during tests
49 raise ExtractorError(message)
5f6a1245 50
0eaf520d 51 def process_info(self, info_dict):
f46e2f9d 52 self.processed_info_dicts.append(info_dict.copy())
86e5f3ed 53 return super().process_info(info_dict)
1535ac2a 54
5f6a1245 55
fd5ff020
FV
56def _file_md5(fn):
57 with open(fn, 'rb') as f:
58 return hashlib.md5(f.read()).hexdigest()
59
582be358 60
f2e8dbcc 61normal_test_cases = gettestcases()
62webpage_test_cases = getwebpagetestcases()
63tests_counter = collections.defaultdict(collections.Counter)
6b47c7f2 64
0eaf520d 65
060ac762 66@is_download_test
1535ac2a 67class TestDownload(unittest.TestCase):
8936f68a
YCH
68 # Parallel testing in nosetests. See
69 # http://nose.readthedocs.org/en/latest/doc_tests/test_multiprocess/multiprocess.html
70 _multiprocess_shared_ = True
71
744435f2 72 maxDiff = None
5f6a1245 73
243c57cf 74 COMPLETED_TESTS = {}
75
c6c22e98
JH
76 def __str__(self):
77 """Identify each test with the `add_ie` attribute, if available."""
f2e8dbcc 78 cls, add_ie = type(self), getattr(self, self._testMethodName).add_ie
79 return f'{self._testMethodName} ({cls.__module__}.{cls.__name__}){f" [{add_ie}]" if add_ie else ""}:'
c6c22e98 80
fd5ff020 81
5f6a1245
JW
82# Dynamically generate tests
83
8936f68a 84def generator(test_case, tname):
1535ac2a 85 def test_template(self):
243c57cf 86 if self.COMPLETED_TESTS.get(tname):
87 return
88 self.COMPLETED_TESTS[tname] = True
7a5c1cfe 89 ie = yt_dlp.extractor.get_info_extractor(test_case['name'])()
655c4100 90 other_ies = [get_info_extractor(ie_key)() for ie_key in test_case.get('add_ie', [])]
e8ee972c
PH
91 is_playlist = any(k.startswith('playlist') for k in test_case)
92 test_cases = test_case.get(
93 'playlist', [] if is_playlist else [test_case])
94
bc2884af 95 def print_skipping(reason):
add96eb9 96 print('Skipping {}: {}'.format(test_case['name'], reason))
6d1b3489 97 self.skipTest(reason)
98
9ee2b5f6 99 if not ie.working():
bc2884af 100 print_skipping('IE marked as not _WORKING')
e8ee972c
PH
101
102 for tc in test_cases:
661c9a1d 103 if tc.get('expected_exception'):
104 continue
e8ee972c 105 info_dict = tc.get('info_dict', {})
0855702f 106 params = tc.get('params', {})
107 if not info_dict.get('id'):
d7118397 108 raise Exception(f'Test {tname} definition incorrect - "id" key is not present')
495322b9 109 elif not info_dict.get('ext') and info_dict.get('_type', 'video') == 'video':
0855702f 110 if params.get('skip_download') and params.get('ignore_no_formats_error'):
111 continue
d7118397 112 raise Exception(f'Test {tname} definition incorrect - "ext" key must be present to define the output file')
e8ee972c 113
fd5ff020 114 if 'skip' in test_case:
bc2884af 115 print_skipping(test_case['skip'])
6d1b3489 116
9ee2b5f6
JMF
117 for other_ie in other_ies:
118 if not other_ie.working():
add96eb9 119 print_skipping(f'test depends on {other_ie.ie_key()}IE, marked as not WORKING')
0eaf520d 120
44a5f171 121 params = get_params(test_case.get('params', {}))
8936f68a 122 params['outtmpl'] = tname + '_' + params['outtmpl']
e8ee972c 123 if is_playlist and 'playlist' not in test_case:
65d49afa 124 params.setdefault('extract_flat', 'in_playlist')
c9bd6518
AK
125 params.setdefault('playlistend', test_case.get(
126 'playlist_mincount', test_case.get('playlist_count', -2) + 1))
e8ee972c 127 params.setdefault('skip_download', True)
0eaf520d 128
ac35c266 129 ydl = YoutubeDL(params, auto_init=False)
023fa8c4 130 ydl.add_default_info_extractors()
bffbd5f0 131 finished_hook_called = set()
5f6a1245 132
bffbd5f0
PH
133 def _hook(status):
134 if status['status'] == 'finished':
135 finished_hook_called.add(status['filename'])
933605d7 136 ydl.add_progress_hook(_hook)
70b7e3fb 137 expect_warnings(ydl, test_case.get('expected_warnings', []))
5c892b0b 138
702665c0 139 def get_tc_filename(tc):
ad3dc496 140 return ydl.prepare_filename(dict(tc.get('info_dict', {})))
702665c0 141
28570840 142 res_dict = None
5f6a1245 143
661c9a1d 144 def match_exception(err):
145 expected_exception = test_case.get('expected_exception')
146 if not expected_exception:
147 return False
148 if err.__class__.__name__ == expected_exception:
149 return True
add96eb9 150 return any(exc.__class__.__name__ == expected_exception for exc in err.exc_info)
661c9a1d 151
28570840
PH
152 def try_rm_tcs_files(tcs=None):
153 if tcs is None:
154 tcs = test_cases
155 for tc in tcs:
702665c0
JMF
156 tc_filename = get_tc_filename(tc)
157 try_rm(tc_filename)
158 try_rm(tc_filename + '.part')
4eb92208 159 try_rm(os.path.splitext(tc_filename)[0] + '.info.json')
702665c0 160 try_rm_tcs_files()
5c892b0b 161 try:
dd508b7c
FV
162 try_num = 1
163 while True:
8cc83b8d 164 try:
3bef10a5 165 # We're not using .download here since that is just a shim
e8ee972c
PH
166 # for outside error handling, and returns the exit code
167 # instead of the result dict.
308cfe0a
S
168 res_dict = ydl.extract_info(
169 test_case['url'],
170 force_generic_extractor=params.get('force_generic_extractor', False))
8cc83b8d 171 except (DownloadError, ExtractorError) as err:
8cc83b8d 172 # Check if the exception is not a network related one
3d2623a8 173 if not isinstance(err.exc_info[1], (TransportError, UnavailableVideoError)) or (isinstance(err.exc_info[1], HTTPError) and err.exc_info[1].status == 503):
661c9a1d 174 if match_exception(err):
175 return
d7118397 176 err.msg = f'{getattr(err, "msg", err)} ({tname})'
8cc83b8d
FV
177 raise
178
dd508b7c 179 if try_num == RETRIES:
54a63e80 180 raise
dd508b7c 181
86e5f3ed 182 print(f'Retrying: {try_num} failed tries\n\n##########\n\n')
dd508b7c
FV
183
184 try_num += 1
661c9a1d 185 except YoutubeDLError as err:
186 if match_exception(err):
187 return
188 raise
8cc83b8d
FV
189 else:
190 break
5c892b0b 191
e8ee972c 192 if is_playlist:
880ee801 193 self.assertTrue(res_dict['_type'] in ['playlist', 'multi_video'])
d6e6a422 194 self.assertTrue('entries' in res_dict)
f74b341d 195 expect_info_dict(self, res_dict, test_case.get('info_dict', {}))
d6e6a422 196
e8ee972c 197 if 'playlist_mincount' in test_case:
0990305d
PH
198 assertGreaterEqual(
199 self,
e8ee972c
PH
200 len(res_dict['entries']),
201 test_case['playlist_mincount'],
202 'Expected at least %d in playlist %s, but got only %d' % (
203 test_case['playlist_mincount'], test_case['url'],
204 len(res_dict['entries'])))
829476b8
PH
205 if 'playlist_count' in test_case:
206 self.assertEqual(
207 len(res_dict['entries']),
208 test_case['playlist_count'],
28570840 209 'Expected %d entries in playlist %s, but got %d.' % (
22a6f150 210 test_case['playlist_count'],
28570840 211 test_case['url'],
22a6f150
PH
212 len(res_dict['entries']),
213 ))
28570840
PH
214 if 'playlist_duration_sum' in test_case:
215 got_duration = sum(e['duration'] for e in res_dict['entries'])
216 self.assertEqual(
217 test_case['playlist_duration_sum'], got_duration)
e8ee972c 218
364a69e8
S
219 # Generalize both playlists and single videos to unified format for
220 # simplicity
221 if 'entries' not in res_dict:
222 res_dict['entries'] = [res_dict]
223
80b2fdf9 224 for tc_num, tc in enumerate(test_cases):
364a69e8
S
225 tc_res_dict = res_dict['entries'][tc_num]
226 # First, check test cases' data against extracted data alone
80b2fdf9 227 expect_info_dict(self, tc_res_dict, tc.get('info_dict', {}))
495322b9 228 if tc_res_dict.get('_type', 'video') != 'video':
229 continue
364a69e8 230 # Now, check downloaded file consistency
702665c0 231 tc_filename = get_tc_filename(tc)
511eda8e 232 if not test_case.get('params', {}).get('skip_download', False):
702665c0
JMF
233 self.assertTrue(os.path.exists(tc_filename), msg='Missing file ' + tc_filename)
234 self.assertTrue(tc_filename in finished_hook_called)
08a36c35
S
235 expected_minsize = tc.get('file_minsize', 10000)
236 if expected_minsize is not None:
237 if params.get('test'):
238 expected_minsize = max(expected_minsize, 10000)
239 got_fsize = os.path.getsize(tc_filename)
240 assertGreaterEqual(
241 self, got_fsize, expected_minsize,
add96eb9 242 f'Expected {tc_filename} to be at least {format_bytes(expected_minsize)}, '
243 f'but it\'s only {format_bytes(got_fsize)} ')
08a36c35
S
244 if 'md5' in tc:
245 md5_for_file = _file_md5(tc_filename)
374560f0 246 self.assertEqual(tc['md5'], md5_for_file)
364a69e8
S
247 # Finally, check test cases' data again but this time against
248 # extracted data from info JSON file written during processing
4eb92208 249 info_json_fn = os.path.splitext(tc_filename)[0] + '.info.json'
f744c0f3
PH
250 self.assertTrue(
251 os.path.exists(info_json_fn),
add96eb9 252 f'Missing info file {info_json_fn}')
86e5f3ed 253 with open(info_json_fn, encoding='utf-8') as infof:
5c892b0b 254 info_dict = json.load(infof)
f74b341d 255 expect_info_dict(self, info_dict, tc.get('info_dict', {}))
5c892b0b 256 finally:
702665c0 257 try_rm_tcs_files()
d6e6a422 258 if is_playlist and res_dict is not None and res_dict.get('entries'):
28570840
PH
259 # Remove all other files that may have been extracted if the
260 # extractor returns full results even with extract_flat
261 res_tcs = [{'info_dict': e} for e in res_dict['entries']]
262 try_rm_tcs_files(res_tcs)
227bf1a3 263 ydl.close()
1535ac2a 264 return test_template
fd5ff020 265
582be358 266
5f6a1245 267# And add them to TestDownload
f2e8dbcc 268def inject_tests(test_cases, label=''):
269 for test_case in test_cases:
270 name = test_case['name']
271 tname = join_nonempty('test', name, label, tests_counter[name][label], delim='_')
272 tests_counter[name][label] += 1
cdab8aa3 273
f2e8dbcc 274 test_method = generator(test_case, tname)
275 test_method.__name__ = tname
276 test_method.add_ie = ','.join(test_case.get('add_ie', []))
277 setattr(TestDownload, test_method.__name__, test_method)
cdab8aa3 278
243c57cf 279
f2e8dbcc 280inject_tests(normal_test_cases)
281
282# TODO: disable redirection to the IE to ensure we are actually testing the webpage extraction
283inject_tests(webpage_test_cases, 'webpage')
284
285
286def batch_generator(name):
243c57cf 287 def test_template(self):
f2e8dbcc 288 for label, num_tests in tests_counter[name].items():
289 for i in range(num_tests):
290 test_name = join_nonempty('test', name, label, i, delim='_')
291 try:
292 getattr(self, test_name)()
293 except unittest.SkipTest:
294 print(f'Skipped {test_name}')
243c57cf 295
296 return test_template
297
298
f2e8dbcc 299for name in tests_counter:
300 test_method = batch_generator(name)
243c57cf 301 test_method.__name__ = f'test_{name}_all'
302 test_method.add_ie = ''
303 setattr(TestDownload, test_method.__name__, test_method)
f2e8dbcc 304del test_method
243c57cf 305
306
cdab8aa3
PH
307if __name__ == '__main__':
308 unittest.main()