X-Git-Url: https://jfr.im/git/solanum.git/blobdiff_plain/e241d7979cf8c251efbb66523b41e104804fd27c..fa33bdd14d0683c72f89ee931be1e888d22f80b9:/modules/m_whois.c

diff --git a/modules/m_whois.c b/modules/m_whois.c
index 796d3084..d82f65fa 100644
--- a/modules/m_whois.c
+++ b/modules/m_whois.c
@@ -30,10 +30,10 @@
 #include "ircd.h"
 #include "numeric.h"
 #include "s_conf.h"
+#include "s_user.h"
 #include "s_serv.h"
 #include "send.h"
 #include "match.h"
-#include "s_conf.h"
 #include "logger.h"
 #include "msg.h"
 #include "parse.h"
@@ -60,12 +60,14 @@ struct Message whois_msgtab = {
 int doing_whois_hook;
 int doing_whois_global_hook;
 int doing_whois_channel_visibility_hook;
+int doing_whois_show_idle_hook;
 
 mapi_clist_av1 whois_clist[] = { &whois_msgtab, NULL };
 mapi_hlist_av1 whois_hlist[] = {
 	{ "doing_whois",			&doing_whois_hook },
 	{ "doing_whois_global",			&doing_whois_global_hook },
 	{ "doing_whois_channel_visibility",	&doing_whois_channel_visibility_hook },
+	{ "doing_whois_show_idle",		&doing_whois_show_idle_hook },
 	{ NULL, NULL }
 };
 
@@ -89,7 +91,7 @@ m_whois(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_
 			return;
 		}
 
-		if(!IsOper(source_p))
+		if(!IsOperGeneral(source_p))
 		{
 			/* seeing as this is going across servers, we should limit it */
 			if((last_used + ConfigFileEntry.pace_wait_simple) > rb_current_time() || !ratelimit_client(source_p, 2))
@@ -224,15 +226,7 @@ static void
 single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 {
 	char buf[BUFSIZE];
-	rb_dlink_node *ptr;
-	struct membership *msptr;
-	struct Channel *chptr;
-	int cur_len = 0;
-	int mlen;
-	char *t;
-	int tlen;
 	hook_data_client hdata;
-	int extra_space = 0;
 	struct sockaddr_in ip4;
 
 	if(target_p->user == NULL)
@@ -245,7 +239,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 			   target_p->name, target_p->username,
 			   target_p->host, target_p->info);
 
-	cur_len = mlen = sprintf(buf, form_str(RPL_WHOISCHANNELS),
+	send_multiline_init(source_p, " ", form_str(RPL_WHOISCHANNELS),
 				    get_id(&me, source_p), get_id(source_p, source_p),
 				    target_p->name);
 
@@ -253,53 +247,45 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 	 * in full names; note that serverhiding may require more space
 	 * for a different server name (not done here) -- jilles
 	 */
-	if (!MyConnect(source_p))
-	{
-		extra_space = strlen(source_p->name) - 9;
-		if (extra_space < 0)
-			extra_space = 0;
-		extra_space += strlen(me.name) - 2; /* make sure >= 0 */
-		cur_len += extra_space;
-	}
-
-	t = buf + mlen;
+	send_multiline_remote_pad(source_p, &me);
+	send_multiline_remote_pad(source_p, source_p);
 
 	hdata.client = source_p;
 	hdata.target = target_p;
 
 	if (!IsService(target_p))
 	{
-		RB_DLINK_FOREACH(ptr, target_p->user->channel.head)
+		hook_data_channel_visibility hdata_vis;
+		rb_dlink_node *ps, *pt;
+		struct Channel *chptr;
+		struct membership *ms, *mt;
+
+		hdata_vis.client = source_p;
+		hdata_vis.target = target_p;
+
+		ITER_COMM_CHANNELS(ps, pt, source_p->user->channel.head, target_p->user->channel.head, ms, mt, chptr)
 		{
-			msptr = ptr->data;
-			chptr = msptr->chptr;
+			if (mt == NULL)
+				continue;
 
-			hdata.chptr = chptr;
+			hdata_vis.chptr = chptr;
+			hdata_vis.clientms = ms;
+			hdata_vis.targetms = mt;
+			hdata_vis.approved = ms != NULL || PubChannel(chptr);
 
-			hdata.approved = ShowChannel(source_p, chptr);
-			call_hook(doing_whois_channel_visibility_hook, &hdata);
+			call_hook(doing_whois_channel_visibility_hook, &hdata_vis);
 
-			if(hdata.approved || operspy)
+			if(hdata_vis.approved || operspy)
 			{
-				if((cur_len + strlen(chptr->chname) + 3) > (BUFSIZE - 5))
-				{
-					sendto_one(source_p, "%s", buf);
-					cur_len = mlen + extra_space;
-					t = buf + mlen;
-				}
-
-				tlen = sprintf(t, "%s%s%s ",
-						hdata.approved ? "" : "!",
-						find_channel_status(msptr, 1),
+				send_multiline_item(source_p, "%s%s%s",
+						hdata_vis.approved ? "" : "!",
+						find_channel_status(mt, 1),
 						chptr->chname);
-				t += tlen;
-				cur_len += tlen;
 			}
 		}
 	}
 
-	if(cur_len > mlen + extra_space)
-		sendto_one(source_p, "%s", buf);
+	send_multiline_fini(source_p, NULL);
 
 	sendto_one_numeric(source_p, RPL_WHOISSERVER, form_str(RPL_WHOISSERVER),
 			   target_p->name, target_p->servptr->name,
@@ -309,28 +295,39 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 		sendto_one_numeric(source_p, RPL_AWAY, form_str(RPL_AWAY),
 				   target_p->name, target_p->user->away);
 
-	if((!ConfigFileEntry.hide_opers_in_whois || IsOper(source_p)) && SeesOper(target_p, source_p))
+	char *s = NULL;
+	if (IsService(target_p))
 	{
-		sendto_one_numeric(source_p, RPL_WHOISOPERATOR, form_str(RPL_WHOISOPERATOR),
-				   target_p->name,
-				   IsService(target_p) ? ConfigFileEntry.servicestring :
-				   (IsAdmin(target_p) ? GlobalSetOptions.adminstring :
-				    GlobalSetOptions.operstring));
+		s = ConfigFileEntry.servicestring;
 	}
-
-	if(!EmptyString(target_p->user->opername) && IsOper(target_p) && IsOper(source_p))
+	if (!EmptyString(target_p->user->opername) && IsOper(target_p))
 	{
-		char buf[512];
-		const char *privset = "(missing)";
-		if (target_p->user->privset != NULL)
-			privset = target_p->user->privset->name;
-		snprintf(buf, sizeof(buf), "is opered as %s, privset %s",
-			    target_p->user->opername, privset);
-		sendto_one_numeric(source_p, RPL_WHOISSPECIAL, form_str(RPL_WHOISSPECIAL),
-				   target_p->name, buf);
+		if (target_p == source_p || HasPrivilege(source_p, "oper:privs"))
+		{
+			const char *privset = "(missing)";
+			if (target_p->user->privset != NULL)
+				privset = target_p->user->privset->name;
+			snprintf(buf, sizeof buf, "is opered as %s, privset %s", target_p->user->opername, privset);
+			s = buf;
+		}
+		else if (IsOper(source_p) && SeesOper(target_p, source_p))
+		{
+			snprintf(buf, sizeof buf, "is opered as %s", target_p->user->opername);
+			s = buf;
+		}
+		else if (!ConfigFileEntry.hide_opers_in_whois && SeesOper(target_p, source_p))
+		{
+			s = IsAdmin(target_p) ? GlobalSetOptions.adminstring :
+			    GlobalSetOptions.operstring;
+		}
+	}
+	if (s != NULL)
+	{
+		sendto_one_numeric(source_p, RPL_WHOISOPERATOR, form_str(RPL_WHOISOPERATOR),
+				target_p->name, s);
 	}
 
-	if(IsSSLClient(target_p))
+	if(IsSecureClient(target_p))
 	{
 		char cbuf[256] = "is using a secure connection";
 
@@ -340,7 +337,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 
 		sendto_one_numeric(source_p, RPL_WHOISSECURE, form_str(RPL_WHOISSECURE),
 				   target_p->name, cbuf);
-		if((source_p == target_p || IsOper(source_p)) &&
+		if((source_p == target_p || IsOperGeneral(source_p)) &&
 				target_p->certfp != NULL)
 			sendto_one_numeric(source_p, RPL_WHOISCERTFP,
 					form_str(RPL_WHOISCERTFP),
@@ -349,7 +346,7 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 
 	if(MyClient(target_p))
 	{
-		if (IsDynSpoof(target_p) && (IsOper(source_p) || source_p == target_p))
+		if (IsDynSpoof(target_p) && (HasPrivilege(source_p, "auspex:hostname") || source_p == target_p))
 		{
 			/* trick here: show a nonoper their own IP if
 			 * dynamic spoofed but not if auth{} spoofed
@@ -378,14 +375,45 @@ single_whois(struct Client *source_p, struct Client *target_p, int operspy)
 					target_p->name, buf);
 		}
 
+		/* fire the doing_whois_show_idle hook to allow modules to tell us whether to show the idle time */
+		hook_data_client_approval hdata_showidle;
+
+		hdata_showidle.client = source_p;
+		hdata_showidle.target = target_p;
+		hdata_showidle.approved = WHOIS_IDLE_SHOW;
+
+		call_hook(doing_whois_show_idle_hook, &hdata_showidle);
+
 		sendto_one_numeric(source_p, RPL_WHOISIDLE, form_str(RPL_WHOISIDLE),
-				   target_p->name,
-				   (long)(rb_current_time() - target_p->localClient->last),
-				   (unsigned long)target_p->localClient->firsttime);
+			   target_p->name,
+			   hdata_showidle.approved != WHOIS_IDLE_HIDE ? (long)(rb_current_time() - target_p->localClient->last) : 0,
+			   (unsigned long)target_p->localClient->firsttime);
+
+		if (hdata_showidle.approved == WHOIS_IDLE_SHOW)
+			;
+		else if (target_p->umodes & user_modes['I'])
+		{
+			if (hdata_showidle.approved == WHOIS_IDLE_HIDE)
+				/* if the target has hidden their idle time, notify the source */
+				sendto_one_numeric(source_p, RPL_WHOISTEXT, form_str(RPL_WHOISTEXT), target_p->name, "is hiding their idle time");
+			else
+				/* if the target has hidden their idle time, notify the source */
+				sendto_one_numeric(source_p, RPL_WHOISTEXT, form_str(RPL_WHOISTEXT), target_p->name, "is hiding their idle time, but you have auspex");
+		}
+		else
+		{
+			if (hdata_showidle.approved == WHOIS_IDLE_HIDE)
+				/* if the source has hidden their idle time, notify the source that they can't view others' idle times either */
+				sendto_one_numeric(source_p, RPL_WHOISTEXT, form_str(RPL_WHOISTEXT), target_p->name, "has a hidden idle time because your own idle time is hidden");
+			else
+				/* client has auspex to be able to see idle time, but make sure they know that's why they're seeing it */
+				sendto_one_numeric(source_p, RPL_WHOISTEXT, form_str(RPL_WHOISTEXT), target_p->name,
+					"has a hidden idle time because your own idle time is hidden, but you have auspex");
+		}
 	}
 	else
 	{
-		if (IsDynSpoof(target_p) && (IsOper(source_p) || source_p == target_p))
+		if (IsDynSpoof(target_p) && (HasPrivilege(source_p, "auspex:hostname") || source_p == target_p))
 		{
 			ClearDynSpoof(target_p);
 			sendto_one_numeric(source_p, RPL_WHOISHOST,