X-Git-Url: https://jfr.im/git/solanum.git/blobdiff_plain/3fb264ef499f9329978e97b996a2b0465f772854..ea41b24fd4807e3565bf5f8f293e2efc4c20b62d:/modules/m_cap.c

diff --git a/modules/m_cap.c b/modules/m_cap.c
index e050946b..d358a99c 100644
--- a/modules/m_cap.c
+++ b/modules/m_cap.c
@@ -177,10 +177,16 @@ clicap_generate(struct Client *source_p, const char *subcmd, int flags)
 	buf_list[0] = '\0';
 	max_list = sizeof(buf_prefix) - len_prefix - strlen(str_cont);
 
+	for (int pass = 0; pass < 2; pass++)
 	RB_DICTIONARY_FOREACH(entry, &iter, cli_capindex->cap_dict) {
 		struct ClientCapability *clicap = entry->ownerdata;
 		const char *data = NULL;
 
+		if (pass == 0 && !HasCapabilityFlag(entry, CLICAP_FLAGS_PRIORITY))
+			continue;
+		else if (pass == 1 && HasCapabilityFlag(entry, CLICAP_FLAGS_PRIORITY))
+			continue;
+
 		if (flags && !IsCapableEntry(source_p, entry))
 			continue;
 
@@ -200,7 +206,7 @@ clicap_generate(struct Client *source_p, const char *subcmd, int flags)
 
 				if (!(source_p->flags & FLAGS_CLICAP_DATA)) {
 					/* the client doesn't support multiple lines */
-					break;
+					continue;
 				}
 
 				/* doesn't fit in the buffer, output what we have */
@@ -296,16 +302,12 @@ cap_ls(struct Client *source_p, const char *arg)
 static void
 cap_req(struct Client *source_p, const char *arg)
 {
-	static char buf_prefix[DATALEN + 1];
-	static char buf_list[2][DATALEN + 1];
-	const char *str_cont = " * :";
-	const char *str_final = " :";
-	int len_prefix;
-	int max_list;
+	char ack_buf[DATALEN+1];
 	struct CapabilityEntry *cap;
-	int i = 0;
 	int capadd = 0, capdel = 0;
 	int finished = 0, negate;
+	int ret;
+	hook_data_cap_change hdata;
 
 	if(!IsRegistered(source_p))
 		source_p->flags |= FLAGS_CLICAP;
@@ -313,22 +315,19 @@ cap_req(struct Client *source_p, const char *arg)
 	if(EmptyString(arg))
 		return;
 
-	buf_prefix[0] = '\0';
-	len_prefix = rb_snprintf_try_append(buf_prefix, sizeof(buf_prefix),
-			":%s CAP %s ACK",
-			me.name,
-			EmptyString(source_p->name) ? "*" : source_p->name);
+	ret = snprintf(ack_buf, sizeof ack_buf, ":%s CAP %s ACK :%s",
+			me.name, EmptyString(source_p->name)? "*" : source_p->name, arg);
 
-	buf_list[0][0] = '\0';
-	buf_list[1][0] = '\0';
-	max_list = sizeof(buf_prefix) - len_prefix - strlen(str_cont);
+	if (ret < 0 || ret > DATALEN)
+	{
+		sendto_one(source_p, ":%s CAP %s NAK :%s",
+			me.name, EmptyString(source_p->name) ? "*" : source_p->name, arg);
+		return;
+	}
 
 	for(cap = clicap_find(arg, &negate, &finished); cap;
 	    cap = clicap_find(NULL, &negate, &finished))
 	{
-		size_t namelen = strlen(cap->cap);
-		const char *type;
-
 		if(negate)
 		{
 			if(HasCapabilityFlag(cap, CLICAP_FLAGS_STICKY))
@@ -337,7 +336,6 @@ cap_req(struct Client *source_p, const char *arg)
 				break;
 			}
 
-			type = "-";
 			capdel |= (1 << cap->value);
 		}
 		else
@@ -348,42 +346,9 @@ cap_req(struct Client *source_p, const char *arg)
 				break;
 			}
 
-			type = "";
 			capadd |= (1 << cap->value);
 		}
 
-		/* XXX this probably should exclude REQACK'd caps from capadd/capdel, but keep old behaviour for now */
-		if(HasCapabilityFlag(cap, CLICAP_FLAGS_REQACK))
-		{
-			type = "~";
-		}
-
-		for (int attempts = 0; attempts < 2; attempts++) {
-			if (rb_snprintf_try_append(buf_list[i], max_list, "%s%s%s",
-					buf_list[i][0] == '\0' ? "" : " ", /* space between caps */
-					type,
-					cap->cap) < 0
-					&& buf_list[i][0] != '\0') {
-
-				if (!(source_p->flags & FLAGS_CLICAP_DATA)) {
-					/* the client doesn't support multiple lines */
-					break;
-				}
-
-				/* doesn't fit in the buffer, move to the next one */
-				if (i < 2) {
-					i++;
-				} else {
-					/* uh-oh */
-					break;
-				}
-
-				/* reset the buffer and go around the loop one more time */
-				buf_list[i][0] = '\0';
-			} else {
-				break;
-			}
-		}
 	}
 
 	if(!finished)
@@ -393,15 +358,17 @@ cap_req(struct Client *source_p, const char *arg)
 		return;
 	}
 
-	if (i) {
-		sendto_one(source_p, "%s%s%s", buf_prefix, str_cont, buf_list[0]);
-		sendto_one(source_p, "%s%s%s", buf_prefix, str_final, buf_list[1]);
-	} else {
-		sendto_one(source_p, "%s%s%s", buf_prefix, str_final, buf_list[0]);
-	}
+	sendto_one(source_p, "%s", ack_buf);
+
+	hdata.client = source_p;
+	hdata.oldcaps = source_p->localClient->caps;
+	hdata.add = capadd;
+	hdata.del = capdel;
 
 	source_p->localClient->caps |= capadd;
 	source_p->localClient->caps &= ~capdel;
+
+	call_hook(h_cap_change, &hdata);
 }
 
 static struct clicap_cmd