X-Git-Url: https://jfr.im/git/solanum.git/blobdiff_plain/3d0bbdcbe1372dd115ed05d78b32f04bd31ce840..6d58b1d38efff2737357edf9ab84abcf9261baba:/modules/core/m_message.c

diff --git a/modules/core/m_message.c b/modules/core/m_message.c
index 08ccc1d3..3c31554a 100644
--- a/modules/core/m_message.c
+++ b/modules/core/m_message.c
@@ -20,15 +20,12 @@
  *  along with this program; if not, write to the Free Software
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
  *  USA
- *
- *  $Id: m_message.c 3173 2007-01-31 23:57:18Z jilles $
  */
 
 #include "stdinc.h"
 #include "client.h"
 #include "ircd.h"
 #include "numeric.h"
-#include "common.h"
 #include "s_conf.h"
 #include "s_serv.h"
 #include "msg.h"
@@ -43,11 +40,15 @@
 #include "send.h"
 #include "s_newconf.h"
 #include "s_stats.h"
+#include "tgchange.h"
 #include "inline/stringops.h"
 
-static int m_message(int, const char *, struct Client *, struct Client *, int, const char **);
-static int m_privmsg(struct Client *, struct Client *, int, const char **);
-static int m_notice(struct Client *, struct Client *, int, const char **);
+static const char message_desc[] =
+	"Provides the PRIVMSG and NOTICE commands to send messages to users and channels";
+
+static void m_message(enum message_type, struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void m_privmsg(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
+static void m_notice(struct MsgBuf *, struct Client *, struct Client *, int, const char **);
 
 static void expire_tgchange(void *unused);
 static struct ev_entry *expire_tgchange_event;
@@ -67,17 +68,17 @@ moddeinit(void)
 }
 
 struct Message privmsg_msgtab = {
-	"PRIVMSG", 0, 0, 0, MFLG_SLOW | MFLG_UNREG,
+	"PRIVMSG", 0, 0, 0, 0,
 	{mg_unreg, {m_privmsg, 0}, {m_privmsg, 0}, mg_ignore, mg_ignore, {m_privmsg, 0}}
 };
 struct Message notice_msgtab = {
-	"NOTICE", 0, 0, 0, MFLG_SLOW,
+	"NOTICE", 0, 0, 0, 0,
 	{mg_unreg, {m_notice, 0}, {m_notice, 0}, {m_notice, 0}, mg_ignore, {m_notice, 0}}
 };
 
 mapi_clist_av1 message_clist[] = { &privmsg_msgtab, &notice_msgtab, NULL };
 
-DECLARE_MODULE_AV1(message, modinit, moddeinit, message_clist, NULL, NULL, "$Revision: 3173 $");
+DECLARE_MODULE_AV2(message, modinit, moddeinit, message_clist, NULL, NULL, NULL, NULL, message_desc);
 
 struct entity
 {
@@ -86,14 +87,11 @@ struct entity
 	int flags;
 };
 
-static int build_target_list(int p_or_n, const char *command,
+static int build_target_list(enum message_type msgtype,
 			     struct Client *client_p,
 			     struct Client *source_p, const char *nicks_channels, const char *text);
 
-static struct Channel *find_allowing_channel(struct Client *source_p, struct Client *target_p);
-static int flood_attack_client(int p_or_n, struct Client *source_p, struct Client *target_p);
-static int flood_attack_channel(int p_or_n, struct Client *source_p,
-				struct Channel *chptr, char *chname);
+static bool flood_attack_client(enum message_type msgtype, struct Client *source_p, struct Client *target_p);
 
 /* Fifteen seconds should be plenty for a client to reply a ctcp */
 #define LARGE_CTCP_TIME 15
@@ -107,26 +105,26 @@ static int flood_attack_channel(int p_or_n, struct Client *source_p,
 static struct entity targets[512];
 static int ntargets = 0;
 
-static int duplicate_ptr(void *);
+static bool duplicate_ptr(void *);
 
-static void msg_channel(int p_or_n, const char *command,
+static void msg_channel(enum message_type msgtype,
 			struct Client *client_p,
 			struct Client *source_p, struct Channel *chptr, const char *text);
 
-static void msg_channel_opmod(int p_or_n, const char *command,
+static void msg_channel_opmod(enum message_type msgtype,
 			      struct Client *client_p,
 			      struct Client *source_p, struct Channel *chptr,
 			      const char *text);
 
-static void msg_channel_flags(int p_or_n, const char *command,
+static void msg_channel_flags(enum message_type msgtype,
 			      struct Client *client_p,
 			      struct Client *source_p,
 			      struct Channel *chptr, int flags, const char *text);
 
-static void msg_client(int p_or_n, const char *command,
+static void msg_client(enum message_type msgtype,
 		       struct Client *source_p, struct Client *target_p, const char *text);
 
-static void handle_special(int p_or_n, const char *command,
+static void handle_special(enum message_type msgtype,
 			   struct Client *client_p, struct Client *source_p, const char *nick,
 			   const char *text);
 
@@ -148,49 +146,48 @@ static void handle_special(int p_or_n, const char *command,
 ** -db Nov 13, 2000
 **
 */
+const char *cmdname[MESSAGE_TYPE_COUNT] = {
+	[MESSAGE_TYPE_PRIVMSG] = "PRIVMSG",
+	[MESSAGE_TYPE_NOTICE] = "NOTICE",
+};
 
-#define PRIVMSG 0
-#define NOTICE  1
-
-static int
-m_privmsg(struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
+static void
+m_privmsg(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
-	return m_message(PRIVMSG, "PRIVMSG", client_p, source_p, parc, parv);
+	m_message(MESSAGE_TYPE_PRIVMSG, msgbuf_p, client_p, source_p, parc, parv);
 }
 
-static int
-m_notice(struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
+static void
+m_notice(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
-	return m_message(NOTICE, "NOTICE", client_p, source_p, parc, parv);
+	m_message(MESSAGE_TYPE_NOTICE, msgbuf_p, client_p, source_p, parc, parv);
 }
 
 /*
  * inputs	- flag privmsg or notice
- * 		- pointer to command "PRIVMSG" or "NOTICE"
  *		- pointer to client_p
  *		- pointer to source_p
  *		- pointer to channel
  */
-static int
-m_message(int p_or_n,
-	  const char *command,
+static void
+m_message(enum message_type msgtype, struct MsgBuf *msgbuf_p,
 	  struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
 {
 	int i;
 
 	if(parc < 2 || EmptyString(parv[1]))
 	{
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			sendto_one(source_p, form_str(ERR_NORECIPIENT), me.name,
-				   source_p->name, command);
-		return 0;
+				   source_p->name, cmdname[msgtype]);
+		return;
 	}
 
 	if(parc < 3 || EmptyString(parv[2]))
 	{
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
-		return 0;
+		return;
 	}
 
 	/* Finish the flood grace period if theyre not messaging themselves
@@ -199,9 +196,9 @@ m_message(int p_or_n,
 	if(MyClient(source_p) && !IsFloodDone(source_p) && irccmp(source_p->name, parv[1]))
 		flood_endgrace(source_p);
 
-	if(build_target_list(p_or_n, command, client_p, source_p, parv[1], parv[2]) < 0)
+	if(build_target_list(msgtype, client_p, source_p, parv[1], parv[2]) < 0)
 	{
-		return 0;
+		return;
 	}
 
 	for(i = 0; i < ntargets; i++)
@@ -209,29 +206,27 @@ m_message(int p_or_n,
 		switch (targets[i].type)
 		{
 		case ENTITY_CHANNEL:
-			msg_channel(p_or_n, command, client_p, source_p,
+			msg_channel(msgtype, client_p, source_p,
 				    (struct Channel *) targets[i].ptr, parv[2]);
 			break;
 
 		case ENTITY_CHANNEL_OPMOD:
-			msg_channel_opmod(p_or_n, command, client_p, source_p,
+			msg_channel_opmod(msgtype, client_p, source_p,
 				   (struct Channel *) targets[i].ptr, parv[2]);
 			break;
 
 		case ENTITY_CHANOPS_ON_CHANNEL:
-			msg_channel_flags(p_or_n, command, client_p, source_p,
+			msg_channel_flags(msgtype, client_p, source_p,
 					  (struct Channel *) targets[i].ptr,
 					  targets[i].flags, parv[2]);
 			break;
 
 		case ENTITY_CLIENT:
-			msg_client(p_or_n, command, source_p,
+			msg_client(msgtype, source_p,
 				   (struct Client *) targets[i].ptr, parv[2]);
 			break;
 		}
 	}
-
-	return 0;
 }
 
 /*
@@ -249,11 +244,10 @@ m_message(int p_or_n,
  *		  all the classic old bizzare oper privmsg tricks
  *		  are parsed and sent as is, if prefixed with $
  *		  to disambiguate.
- *
  */
 
 static int
-build_target_list(int p_or_n, const char *command, struct Client *client_p,
+build_target_list(enum message_type msgtype, struct Client *client_p,
 		  struct Client *source_p, const char *nicks_channels, const char *text)
 {
 	int type;
@@ -295,7 +289,7 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
 			}
 
 			/* non existant channel */
-			else if(p_or_n != NOTICE)
+			else if(msgtype != MESSAGE_TYPE_NOTICE)
 				sendto_one_numeric(source_p, ERR_NOSUCHNICK,
 						   form_str(ERR_NOSUCHNICK), nick);
 
@@ -347,7 +341,7 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
 			if(EmptyString(nick))
 			{
 				sendto_one(source_p, form_str(ERR_NORECIPIENT),
-					   me.name, source_p->name, command);
+					   me.name, source_p->name, cmdname[msgtype]);
 				continue;
 			}
 
@@ -367,7 +361,7 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
 						   get_id(&me, source_p),
 						   get_id(source_p, source_p),
 						   with_prefix);
-					return (-1);
+					continue;
 				}
 
 				if(!duplicate_ptr(chptr))
@@ -383,7 +377,7 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
 					targets[ntargets++].flags = type;
 				}
 			}
-			else if(p_or_n != NOTICE)
+			else if(msgtype != MESSAGE_TYPE_NOTICE)
 			{
 				sendto_one_numeric(source_p, ERR_NOSUCHNICK,
 						   form_str(ERR_NOSUCHNICK), nick);
@@ -392,12 +386,6 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
 			continue;
 		}
 
-		if(strchr(nick, '@') || (IsOper(source_p) && (*nick == '$')))
-		{
-			handle_special(p_or_n, command, client_p, source_p, nick, text);
-			continue;
-		}
-
 		if(IsServer(client_p) && *nick == '=' && nick[1] == '#')
 		{
 			nick++;
@@ -417,15 +405,21 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
 			}
 
 			/* non existant channel */
-			else if(p_or_n != NOTICE)
+			else if(msgtype != MESSAGE_TYPE_NOTICE)
 				sendto_one_numeric(source_p, ERR_NOSUCHNICK,
 						   form_str(ERR_NOSUCHNICK), nick);
 
 			continue;
 		}
 
+		if(strchr(nick, '@') || (IsOper(source_p) && (*nick == '$')))
+		{
+			handle_special(msgtype, client_p, source_p, nick, text);
+			continue;
+		}
+
 		/* no matching anything found - error if not NOTICE */
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 		{
 			/* dont give this numeric when source is local,
 			 * because its misleading --anfl
@@ -450,25 +444,24 @@ build_target_list(int p_or_n, const char *command, struct Client *client_p,
  * inputs	- pointer to check
  *		- pointer to table of entities
  *		- number of valid entities so far
- * output	- YES if duplicate pointer in table, NO if not.
+ * output	- true if duplicate pointer in table, false if not.
  *		  note, this does the canonize using pointers
  * side effects	- NONE
  */
-static int
+static bool
 duplicate_ptr(void *ptr)
 {
 	int i;
 	for(i = 0; i < ntargets; i++)
 		if(targets[i].ptr == ptr)
-			return YES;
-	return NO;
+			return true;
+	return false;
 }
 
 /*
  * msg_channel
  *
  * inputs	- flag privmsg or notice
- * 		- pointer to command "PRIVMSG" or "NOTICE"
  *		- pointer to client_p
  *		- pointer to source_p
  *		- pointer to channel
@@ -478,62 +471,82 @@ duplicate_ptr(void *ptr)
  * XXX - We need to rework this a bit, it's a tad ugly. --nenolod
  */
 static void
-msg_channel(int p_or_n, const char *command,
+msg_channel(enum message_type msgtype,
 	    struct Client *client_p, struct Client *source_p, struct Channel *chptr,
 	    const char *text)
 {
 	int result;
-	char text2[BUFSIZE];
+	hook_data_privmsg_channel hdata;
 
 	if(MyClient(source_p))
 	{
 		/* idle time shouldnt be reset by notices --fl */
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			source_p->localClient->last = rb_current_time();
 	}
 
-	if(chptr->mode.mode & MODE_NOCOLOR)
+	hdata.msgtype = msgtype;
+	hdata.source_p = source_p;
+	hdata.chptr = chptr;
+	hdata.text = text;
+	hdata.approved = 0;
+
+	call_hook(h_privmsg_channel, &hdata);
+
+	/* memory buffer address may have changed, update pointer */
+	text = hdata.text;
+
+	if (hdata.approved != 0)
+		return;
+
+	/* hook may have reduced the string to nothing. */
+	if (EmptyString(text))
 	{
-		rb_strlcpy(text2, text, BUFSIZE);
-		strip_colour(text2);
-		text = text2;
-		if (EmptyString(text))
-		{
-			/* could be empty after colour stripping and
-			 * that would cause problems later */
-			if(p_or_n != NOTICE)
-				sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
-			return;
-		}
+		/* could be empty after colour stripping and
+		 * that would cause problems later */
+		if(msgtype != MESSAGE_TYPE_NOTICE)
+			sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
+		return;
 	}
 
 	/* chanops and voiced can flood their own channel with impunity */
 	if((result = can_send(chptr, source_p, NULL)))
 	{
+		if(result != CAN_SEND_OPV && MyClient(source_p) &&
+		   !IsOper(source_p) &&
+		   !add_channel_target(source_p, chptr))
+		{
+			sendto_one(source_p, form_str(ERR_TARGCHANGE),
+				   me.name, source_p->name, chptr->chname);
+			return;
+		}
 		if(result == CAN_SEND_OPV ||
-		   !flood_attack_channel(p_or_n, source_p, chptr, chptr->chname))
+		   !flood_attack_channel(msgtype, source_p, chptr, chptr->chname))
 		{
 			sendto_channel_flags(client_p, ALL_MEMBERS, source_p, chptr,
-					     "%s %s :%s", command, chptr->chname, text);
-			if (p_or_n != NOTICE && *text == '\001' &&
-					strncasecmp(text + 1, "ACTION", 6) &&
-					rb_dlink_list_length(&chptr->locmembers) > (unsigned)(GlobalSetOptions.floodcount / 2))
-				source_p->large_ctcp_sent = rb_current_time();
+					     "%s %s :%s", cmdname[msgtype], chptr->chname, text);
 		}
 	}
 	else if(chptr->mode.mode & MODE_OPMODERATE &&
 			(!(chptr->mode.mode & MODE_NOPRIVMSGS) ||
 			 IsMember(source_p, chptr)))
 	{
-		if(!flood_attack_channel(p_or_n, source_p, chptr, chptr->chname))
+		if(MyClient(source_p) && !IsOper(source_p) &&
+		   !add_channel_target(source_p, chptr))
+		{
+			sendto_one(source_p, form_str(ERR_TARGCHANGE),
+				   me.name, source_p->name, chptr->chname);
+			return;
+		}
+		if(!flood_attack_channel(msgtype, source_p, chptr, chptr->chname))
 		{
 			sendto_channel_opmod(client_p, source_p, chptr,
-					     command, text);
+					     cmdname[msgtype], text);
 		}
 	}
 	else
 	{
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			sendto_one_numeric(source_p, ERR_CANNOTSENDTOCHAN,
 					   form_str(ERR_CANNOTSENDTOCHAN), chptr->chname);
 	}
@@ -542,7 +555,6 @@ msg_channel(int p_or_n, const char *command,
  * msg_channel_opmod
  *
  * inputs	- flag privmsg or notice
- * 		- pointer to command "PRIVMSG" or "NOTICE"
  *		- pointer to client_p
  *		- pointer to source_p
  *		- pointer to channel
@@ -552,40 +564,49 @@ msg_channel(int p_or_n, const char *command,
  * XXX - We need to rework this a bit, it's a tad ugly. --nenolod
  */
 static void
-msg_channel_opmod(int p_or_n, const char *command,
+msg_channel_opmod(enum message_type msgtype,
 		  struct Client *client_p, struct Client *source_p,
 		  struct Channel *chptr, const char *text)
 {
-	char text2[BUFSIZE];
+	hook_data_privmsg_channel hdata;
+
+	hdata.msgtype = msgtype;
+	hdata.source_p = source_p;
+	hdata.chptr = chptr;
+	hdata.text = text;
+	hdata.approved = 0;
+
+	call_hook(h_privmsg_channel, &hdata);
+
+	/* memory buffer address may have changed, update pointer */
+	text = hdata.text;
 
-	if(chptr->mode.mode & MODE_NOCOLOR)
+	if (hdata.approved != 0)
+		return;
+
+	/* hook may have reduced the string to nothing. */
+	if (EmptyString(text))
 	{
-		rb_strlcpy(text2, text, BUFSIZE);
-		strip_colour(text2);
-		text = text2;
-		if (EmptyString(text))
-		{
-			/* could be empty after colour stripping and
-			 * that would cause problems later */
-			if(p_or_n != NOTICE)
-				sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
-			return;
-		}
+		/* could be empty after colour stripping and
+		 * that would cause problems later */
+		if(msgtype != MESSAGE_TYPE_NOTICE)
+			sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
+		return;
 	}
 
 	if(chptr->mode.mode & MODE_OPMODERATE &&
 			(!(chptr->mode.mode & MODE_NOPRIVMSGS) ||
 			 IsMember(source_p, chptr)))
 	{
-		if(!flood_attack_channel(p_or_n, source_p, chptr, chptr->chname))
+		if(!flood_attack_channel(msgtype, source_p, chptr, chptr->chname))
 		{
 			sendto_channel_opmod(client_p, source_p, chptr,
-					     command, text);
+					     cmdname[msgtype], text);
 		}
 	}
 	else
 	{
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			sendto_one_numeric(source_p, ERR_CANNOTSENDTOCHAN,
 					   form_str(ERR_CANNOTSENDTOCHAN), chptr->chname);
 	}
@@ -594,9 +615,8 @@ msg_channel_opmod(int p_or_n, const char *command,
 /*
  * msg_channel_flags
  *
- * inputs	- flag 0 if PRIVMSG 1 if NOTICE. RFC 
+ * inputs	- flag 0 if PRIVMSG 1 if NOTICE. RFC
  *		  say NOTICE must not auto reply
- *		- pointer to command, "PRIVMSG" or "NOTICE"
  *		- pointer to client_p
  *		- pointer to source_p
  *		- pointer to channel
@@ -606,11 +626,12 @@ msg_channel_opmod(int p_or_n, const char *command,
  * side effects	- message given channel either chanop or voice
  */
 static void
-msg_channel_flags(int p_or_n, const char *command, struct Client *client_p,
+msg_channel_flags(enum message_type msgtype, struct Client *client_p,
 		  struct Client *source_p, struct Channel *chptr, int flags, const char *text)
 {
 	int type;
 	char c;
+	hook_data_privmsg_channel hdata;
 
 	if(flags & CHFL_VOICE)
 	{
@@ -626,18 +647,37 @@ msg_channel_flags(int p_or_n, const char *command, struct Client *client_p,
 	if(MyClient(source_p))
 	{
 		/* idletime shouldnt be reset by notice --fl */
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			source_p->localClient->last = rb_current_time();
 	}
 
+	hdata.msgtype = msgtype;
+	hdata.source_p = source_p;
+	hdata.chptr = chptr;
+	hdata.text = text;
+	hdata.approved = 0;
+
+	call_hook(h_privmsg_channel, &hdata);
+
+	/* memory buffer address may have changed, update pointer */
+	text = hdata.text;
+
+	if (hdata.approved != 0)
+		return;
+
+	if (EmptyString(text))
+	{
+		/* could be empty after colour stripping and
+		 * that would cause problems later */
+		if(msgtype != MESSAGE_TYPE_NOTICE)
+			sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
+		return;
+	}
+
 	sendto_channel_flags(client_p, type, source_p, chptr, "%s %c%s :%s",
-			     command, c, chptr->chname, text);
+			     cmdname[msgtype], c, chptr->chname, text);
 }
 
-#define PREV_FREE_TARGET(x) ((FREE_TARGET(x) == 0) ? 9 : FREE_TARGET(x) - 1)
-#define PREV_TARGET(i) ((i == 0) ? i = 9 : --i)
-#define NEXT_TARGET(i) ((i == 9) ? i = 0 : ++i)
-
 static void
 expire_tgchange(void *unused)
 {
@@ -658,83 +698,11 @@ expire_tgchange(void *unused)
 	}
 }
 
-static int
-add_target(struct Client *source_p, struct Client *target_p)
-{
-	int i, j;
-	uint32_t hashv;
-
-	/* can msg themselves or services without using any target slots */
-	if(source_p == target_p || IsService(target_p))
-		return 1;
-
-	/* special condition for those who have had PRIVMSG crippled to allow them
-	 * to talk to IRCops still.
-	 *
-	 * XXX: is this controversial?
-	 */
-	if(source_p->localClient->target_last > rb_current_time() && IsOper(target_p))
-		return 1;
-
-	hashv = fnv_hash_upper((const unsigned char *)use_id(target_p), 32);
-
-	if(USED_TARGETS(source_p))
-	{
-		/* hunt for an existing target */
-		for(i = PREV_FREE_TARGET(source_p), j = USED_TARGETS(source_p);
-		    j; --j, PREV_TARGET(i))
-		{
-			if(source_p->localClient->targets[i] == hashv)
-				return 1;
-		}
-
-		/* first message after connect, we may only start clearing
-		 * slots after this message --anfl
-		 */
-		if(!IsTGChange(source_p))
-		{
-			SetTGChange(source_p);
-			source_p->localClient->target_last = rb_current_time();
-		}
-		/* clear as many targets as we can */
-		else if((i = (rb_current_time() - source_p->localClient->target_last) / 60))
-		{
-			if(i > USED_TARGETS(source_p))
-				USED_TARGETS(source_p) = 0;
-			else
-				USED_TARGETS(source_p) -= i;
-
-			source_p->localClient->target_last = rb_current_time();
-		}
-		/* cant clear any, full target list */
-		else if(USED_TARGETS(source_p) == 10)
-		{
-			ServerStats.is_tgch++;
-			add_tgchange(source_p->sockhost);
-			return 0;
-		}
-	}
-	/* no targets in use, reset their target_last so that they cant
-	 * abuse a long idle to get targets back more quickly
-	 */
-	else
-	{
-		source_p->localClient->target_last = rb_current_time();
-		SetTGChange(source_p);
-	}
-
-	source_p->localClient->targets[FREE_TARGET(source_p)] = hashv;
-	NEXT_TARGET(FREE_TARGET(source_p));
-	++USED_TARGETS(source_p);
-	return 1;
-}
-
 /*
  * msg_client
  *
- * inputs	- flag 0 if PRIVMSG 1 if NOTICE. RFC 
+ * inputs	- flag 0 if PRIVMSG 1 if NOTICE. RFC
  *		  say NOTICE must not auto reply
- *		- pointer to command, "PRIVMSG" or "NOTICE"
  * 		- pointer to source_p source (struct Client *)
  *		- pointer to target_p target (struct Client *)
  *		- pointer to text
@@ -742,16 +710,44 @@ add_target(struct Client *source_p, struct Client *target_p)
  * side effects	- message given channel either chanop or voice
  */
 static void
-msg_client(int p_or_n, const char *command,
+msg_client(enum message_type msgtype,
 	   struct Client *source_p, struct Client *target_p, const char *text)
 {
 	int do_floodcount = 0;
+	hook_data_privmsg_user hdata;
 
 	if(MyClient(source_p))
 	{
-		/* reset idle time for message only if its not to self 
+		/*
+		 * XXX: Controversial? Allow target users to send replies
+		 * through a +g.  Rationale is that people can presently use +g
+		 * as a way to taunt users, e.g. harass them and hide behind +g
+		 * as a way of griefing.  --nenolod
+		 */
+		if(msgtype != MESSAGE_TYPE_NOTICE &&
+				(IsSetCallerId(source_p) ||
+				 (IsSetRegOnlyMsg(source_p) && !target_p->user->suser[0])) &&
+				!accept_message(target_p, source_p) &&
+				!IsOper(target_p))
+		{
+			if(rb_dlink_list_length(&source_p->localClient->allow_list) <
+					(unsigned long)ConfigFileEntry.max_accept)
+			{
+				rb_dlinkAddAlloc(target_p, &source_p->localClient->allow_list);
+				rb_dlinkAddAlloc(source_p, &target_p->on_allow_list);
+			}
+			else
+			{
+				sendto_one_numeric(source_p, ERR_OWNMODE,
+						form_str(ERR_OWNMODE),
+						target_p->name, "+g");
+				return;
+			}
+		}
+
+		/* reset idle time for message only if its not to self
 		 * and its not a notice */
-		if(p_or_n != NOTICE)
+		if(msgtype != MESSAGE_TYPE_NOTICE)
 			source_p->localClient->last = rb_current_time();
 
 		/* auto cprivmsg/cnotice */
@@ -762,7 +758,7 @@ msg_client(int p_or_n, const char *command,
 		 * would allow people to start filling up random users
 		 * targets just by ctcping them
 		 */
-		if((p_or_n != NOTICE || *text != '\001') &&
+		if((msgtype != MESSAGE_TYPE_NOTICE || *text != '\001') &&
 		   ConfigFileEntry.target_change && do_floodcount)
 		{
 			if(!add_target(source_p, target_p))
@@ -773,13 +769,16 @@ msg_client(int p_or_n, const char *command,
 			}
 		}
 
-		if (do_floodcount && p_or_n == NOTICE && *text == '\001' &&
+		if (do_floodcount && msgtype == MESSAGE_TYPE_NOTICE && *text == '\001' &&
 				target_p->large_ctcp_sent + LARGE_CTCP_TIME >= rb_current_time())
 			do_floodcount = 0;
 
 		if (do_floodcount &&
-				flood_attack_client(p_or_n, source_p, target_p))
+				flood_attack_client(msgtype, source_p, target_p))
 			return;
+
+		if (IsCapable(source_p, CLICAP_ECHO_MESSAGE) && target_p != source_p)
+			sendto_anywhere_echo(target_p, source_p, cmdname[msgtype], ":%s", text);
 	}
 	else if(source_p->from == target_p->from)
 	{
@@ -789,12 +788,35 @@ msg_client(int p_or_n, const char *command,
 		return;
 	}
 
-	if(MyConnect(source_p) && (p_or_n != NOTICE) && target_p->user && target_p->user->away)
+	if(MyConnect(source_p) && (msgtype != MESSAGE_TYPE_NOTICE) && target_p->user && target_p->user->away)
 		sendto_one_numeric(source_p, RPL_AWAY, form_str(RPL_AWAY),
 				   target_p->name, target_p->user->away);
 
 	if(MyClient(target_p))
 	{
+		hdata.msgtype = msgtype;
+		hdata.source_p = source_p;
+		hdata.target_p = target_p;
+		hdata.text = text;
+		hdata.approved = 0;
+
+		call_hook(h_privmsg_user, &hdata);
+
+		/* buffer location may have changed. */
+		text = hdata.text;
+
+		if (hdata.approved != 0)
+			return;
+
+		if (EmptyString(text))
+		{
+			/* could be empty after colour stripping and
+			 * that would cause problems later */
+			if(msgtype != MESSAGE_TYPE_NOTICE)
+				sendto_one(source_p, form_str(ERR_NOTEXTTOSEND), me.name, source_p->name);
+			return;
+		}
+
 		/* XXX Controversial? allow opers always to send through a +g */
 		if(!IsServer(source_p) && (IsSetCallerId(target_p) ||
 					(IsSetRegOnlyMsg(target_p) && !source_p->user->suser[0])))
@@ -802,14 +824,15 @@ msg_client(int p_or_n, const char *command,
 			/* Here is the anti-flood bot/spambot code -db */
 			if(accept_message(source_p, target_p) || IsOper(source_p))
 			{
+				add_reply_target(target_p, source_p);
 				sendto_one(target_p, ":%s!%s@%s %s %s :%s",
 					   source_p->name,
 					   source_p->username,
-					   source_p->host, command, target_p->name, text);
+					   source_p->host, cmdname[msgtype], target_p->name, text);
 			}
 			else if (IsSetRegOnlyMsg(target_p) && !source_p->user->suser[0])
 			{
-				if (p_or_n != NOTICE)
+				if (msgtype != MESSAGE_TYPE_NOTICE)
 					sendto_one_numeric(source_p, ERR_NONONREG,
 							form_str(ERR_NONONREG),
 							target_p->name);
@@ -817,7 +840,7 @@ msg_client(int p_or_n, const char *command,
 			else
 			{
 				/* check for accept, flag recipient incoming message */
-				if(p_or_n != NOTICE)
+				if(msgtype != MESSAGE_TYPE_NOTICE)
 				{
 					sendto_one_numeric(source_p, ERR_TARGUMODEG,
 							   form_str(ERR_TARGUMODEG),
@@ -827,11 +850,12 @@ msg_client(int p_or_n, const char *command,
 				if((target_p->localClient->last_caller_id_time +
 				    ConfigFileEntry.caller_id_wait) < rb_current_time())
 				{
-					if(p_or_n != NOTICE)
+					if(msgtype != MESSAGE_TYPE_NOTICE)
 						sendto_one_numeric(source_p, RPL_TARGNOTIFY,
 								   form_str(RPL_TARGNOTIFY),
 								   target_p->name);
 
+					add_reply_target(target_p, source_p);
 					sendto_one(target_p, form_str(RPL_UMODEGMSG),
 						   me.name, target_p->name, source_p->name,
 						   source_p->username, source_p->host);
@@ -841,40 +865,28 @@ msg_client(int p_or_n, const char *command,
 			}
 		}
 		else
-			sendto_anywhere(target_p, source_p, command, ":%s", text);
+		{
+			add_reply_target(target_p, source_p);
+			sendto_anywhere(target_p, source_p, cmdname[msgtype], ":%s", text);
+		}
 	}
 	else
-		sendto_anywhere(target_p, source_p, command, ":%s", text);
+		sendto_anywhere(target_p, source_p, cmdname[msgtype], ":%s", text);
 
 	return;
 }
 
-static struct Channel *
-find_allowing_channel(struct Client *source_p, struct Client *target_p)
-{
-	rb_dlink_node *ptr;
-	struct membership *msptr;
-
-	RB_DLINK_FOREACH(ptr, source_p->user->channel.head)
-	{
-		msptr = ptr->data;
-		if (is_chanop_voiced(msptr) && IsMember(target_p, msptr->chptr))
-			return msptr->chptr;
-	}
-	return NULL;
-}
-
 /*
  * flood_attack_client
  * inputs       - flag 0 if PRIVMSG 1 if NOTICE. RFC
- *                say NOTICE must not auto reply
- *              - pointer to source Client 
+ *                says NOTICE must not auto reply
+ *              - pointer to source Client
  *		- pointer to target Client
- * output	- 1 if target is under flood attack
+ * output	- true if target is under flood attack
  * side effects	- check for flood attack on target target_p
  */
-static int
-flood_attack_client(int p_or_n, struct Client *source_p, struct Client *target_p)
+static bool
+flood_attack_client(enum message_type msgtype, struct Client *source_p, struct Client *target_p)
 {
 	int delta;
 
@@ -911,76 +923,19 @@ flood_attack_client(int p_or_n, struct Client *source_p, struct Client *target_p
 				/* add a bit of penalty */
 				target_p->received_number_of_privmsgs += 2;
 			}
-			if(MyClient(source_p) && (p_or_n != NOTICE))
+			if(MyClient(source_p) && (msgtype != MESSAGE_TYPE_NOTICE))
 				sendto_one(source_p,
 					   ":%s NOTICE %s :*** Message to %s throttled due to flooding",
 					   me.name, source_p->name, target_p->name);
-			return 1;
+			return true;
 		}
 		else
 			target_p->received_number_of_privmsgs++;
 	}
 
-	return 0;
-}
-
-/*
- * flood_attack_channel
- * inputs       - flag 0 if PRIVMSG 1 if NOTICE. RFC
- *                says NOTICE must not auto reply
- *              - pointer to source Client 
- *		- pointer to target channel
- * output	- 1 if target is under flood attack
- * side effects	- check for flood attack on target chptr
- */
-static int
-flood_attack_channel(int p_or_n, struct Client *source_p, struct Channel *chptr, char *chname)
-{
-	int delta;
-
-	if(GlobalSetOptions.floodcount && MyClient(source_p))
-	{
-		if((chptr->first_received_message_time + 1) < rb_current_time())
-		{
-			delta = rb_current_time() - chptr->first_received_message_time;
-			chptr->received_number_of_privmsgs -= delta;
-			chptr->first_received_message_time = rb_current_time();
-			if(chptr->received_number_of_privmsgs <= 0)
-			{
-				chptr->received_number_of_privmsgs = 0;
-				chptr->flood_noticed = 0;
-			}
-		}
-
-		if((chptr->received_number_of_privmsgs >= GlobalSetOptions.floodcount)
-		   || chptr->flood_noticed)
-		{
-			if(chptr->flood_noticed == 0)
-			{
-				sendto_realops_snomask(SNO_BOTS, *chptr->chname == '&' ? L_ALL : L_NETWIDE,
-						     "Possible Flooder %s[%s@%s] on %s target: %s",
-						     source_p->name, source_p->username,
-						     source_p->orighost,
-						     source_p->servptr->name, chptr->chname);
-				chptr->flood_noticed = 1;
-
-				/* Add a bit of penalty */
-				chptr->received_number_of_privmsgs += 2;
-			}
-			if(MyClient(source_p) && (p_or_n != NOTICE))
-				sendto_one(source_p,
-					   ":%s NOTICE %s :*** Message to %s throttled due to flooding",
-					   me.name, source_p->name, chptr->chname);
-			return 1;
-		}
-		else
-			chptr->received_number_of_privmsgs++;
-	}
-
-	return 0;
+	return false;
 }
 
-
 /*
  * handle_special
  *
@@ -998,12 +953,11 @@ flood_attack_channel(int p_or_n, struct Client *source_p, struct Channel *chptr,
  *		  This disambiguates the syntax.
  */
 static void
-handle_special(int p_or_n, const char *command, struct Client *client_p,
+handle_special(enum message_type msgtype, struct Client *client_p,
 	       struct Client *source_p, const char *nick, const char *text)
 {
 	struct Client *target_p;
 	char *server;
-	char *s;
 
 	/* user[%host]@server addressed?
 	 * NOTE: users can send to user@server, but not user%host@server
@@ -1032,7 +986,7 @@ handle_special(int p_or_n, const char *command, struct Client *client_p,
 		if(!IsMe(target_p))
 		{
 			sendto_one(target_p, ":%s %s %s :%s",
-				   get_id(source_p, target_p), command, nick, text);
+				   get_id(source_p, target_p), cmdname[msgtype], nick, text);
 			return;
 		}
 
@@ -1069,7 +1023,7 @@ handle_special(int p_or_n, const char *command, struct Client *client_p,
 		{
 			sendto_one(source_p,
 				   ":%s NOTICE %s :The command %s %s is no longer supported, please use $%s",
-				   me.name, source_p->name, command, nick, nick);
+				   me.name, source_p->name, cmdname[msgtype], nick, nick);
 			return;
 		}
 
@@ -1080,27 +1034,11 @@ handle_special(int p_or_n, const char *command, struct Client *client_p,
 			return;
 		}
 
-		if((s = strrchr(nick, '.')) == NULL)
-		{
-			sendto_one_numeric(source_p, ERR_NOTOPLEVEL,
-					   form_str(ERR_NOTOPLEVEL), nick);
-			return;
-		}
-		while(*++s)
-			if(*s == '.' || *s == '*' || *s == '?')
-				break;
-		if(*s == '*' || *s == '?')
-		{
-			sendto_one_numeric(source_p, ERR_WILDTOPLEVEL,
-					   form_str(ERR_WILDTOPLEVEL), nick);
-			return;
-		}
-
 		sendto_match_butone(IsServer(client_p) ? client_p : NULL, source_p,
 				    nick + 1,
 				    (*nick == '#') ? MATCH_HOST : MATCH_SERVER,
-				    "%s $%s :%s", command, nick, text);
-		if (p_or_n != NOTICE && *text == '\001')
+				    "%s $%s :%s", cmdname[msgtype], nick, text);
+		if (msgtype != MESSAGE_TYPE_NOTICE && *text == '\001')
 			source_p->large_ctcp_sent = rb_current_time();
 		return;
 	}