Merge pull request #288 from edk0/umode-o-split

[solanum.git] / extensions / m_webirc.c

diff --git a/extensions/m_webirc.c b/extensions/m_webirc.c
index b61c403587c8c7eaa57ae9ca601fe3fc67a78178..2937189ea784496d2b5ac4b2006aca39db5a9595 100644 (file)
--- a/extensions/m_webirc.c
+++ b/extensions/m_webirc.c
@@ -64,7 +64,14 @@ struct Message webirc_msgtab = {
 
 mapi_clist_av1 webirc_clist[] = { &webirc_msgtab, NULL };
 
-DECLARE_MODULE_AV2(webirc, NULL, NULL, webirc_clist, NULL, NULL, NULL, NULL, webirc_desc);
+static void new_local_user(void *data);
+mapi_hfn_list_av1 webirc_hfnlist[] = {
+       /* unintuitive but correct--we want to be called first */
+       { "new_local_user", (hookfn) new_local_user, HOOK_LOWEST },
+       { NULL, NULL }
+};
+
+DECLARE_MODULE_AV2(webirc, NULL, NULL, webirc_clist, NULL, webirc_hfnlist, NULL, NULL, webirc_desc);
 
 /*
  * mr_webirc - webirc message handler
@@ -80,6 +87,8 @@ mr_webirc(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *sourc
        const char *encr;
        struct rb_sockaddr_storage addr;
 
+       int secure = 0;
+
        aconf = find_address_conf(client_p->host, client_p->sockhost,
                                IsGotId(client_p) ? client_p->username : "webirc",
                                IsGotId(client_p) ? client_p->username : "webirc",
@@ -98,6 +107,11 @@ mr_webirc(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *sourc
                sendto_one(source_p, "NOTICE * :CGI:IRC auth blocks must have a password");
                return;
        }
+       if (!IsSSL(source_p) && aconf->flags & CONF_FLAGS_NEED_SSL)
+       {
+               sendto_one(source_p, "NOTICE * :Your CGI:IRC block requires TLS");
+               return;
+       }
 
        if (EmptyString(parv[1]))
                encr = "";
@@ -112,7 +126,7 @@ mr_webirc(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *sourc
                return;
        }
 
-       if (rb_inet_pton_sock(parv[4], (struct sockaddr *)&addr) <= 0)
+       if (rb_inet_pton_sock(parv[4], &addr) <= 0)
        {
                sendto_one(source_p, "NOTICE * :Invalid IP");
                return;
@@ -120,6 +134,27 @@ mr_webirc(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *sourc
 
        source_p->localClient->ip = addr;
 
+       if (parc >= 6)
+       {
+               const char *s;
+               for (s = parv[5]; s != NULL; (s = strchr(s, ' ')) && s++)
+               {
+                       if (!ircncmp(s, "secure", 6) && (s[6] == '=' || s[6] == ' ' || s[6] == '\0'))
+                               secure = 1;
+               }
+       }
+
+       if (secure && !IsSSL(source_p))
+       {
+               sendto_one(source_p, "NOTICE * :CGI:IRC is not connected securely; marking you as insecure");
+               secure = 0;
+       }
+
+       if (!secure)
+       {
+               SetInsecure(source_p);
+       }
+
        rb_inet_ntop_sock((struct sockaddr *)&source_p->localClient->ip, source_p->sockhost, sizeof(source_p->sockhost));
 
        if(strlen(parv[3]) <= HOSTLEN)
@@ -140,3 +175,13 @@ mr_webirc(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *sourc
 
        sendto_one(source_p, "NOTICE * :CGI:IRC host/IP set to %s %s", parv[3], parv[4]);
 }
+
+static void
+new_local_user(void *data)
+{
+       struct Client *source_p = data;
+       struct ConfItem *aconf = source_p->localClient->att_conf;
+
+       if (!irccmp(aconf->info.name, "webirc."))
+               exit_client(source_p, source_p, &me, "Cannot log in using a WEBIRC block");
+}